From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: shmobile: BOCK-W: add Ether support
Date: Sun, 26 May 2013 03:40:17 +0400 [thread overview]
Message-ID: <51A14BE1.8050907@cogentembedded.com> (raw)
In-Reply-To: <20130525232257.GA24131@verge.net.au>
Hello.
On 05/26/2013 03:22 AM, Simon Horman wrote:
>>>> Register Ether device from bockw_init(), passing the platform data to it, adding
>>>> only the RMII pin group to bockw_pinctrl_map[]. Although the LINK signal exists
>>>> on the board, it's connected to the link/activity LED output of the PHY, thus
>>>> the link disappears and reappears after each packet. We'd be better off ignoring
>>>> such signal and getting the link state from the PHY indirectly.
>>>> Also, Ether has pin conflict with VIN1, so the latter is not registered when the
>>>> 'sh_eth' driver is enabled now.
>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>>>
>>>> ---
>>>> The patch is atop of Simon's 'renesas.git' repo, 'renesas-next-20130515v2' tag
>>>> and my recent yet unapplied patches.
>>>> Note that it's compile and run time dependent on the current Linus' tree.
>>>> Changes from the original posting:
>>>> - refreshed the patch.
>>> Thanks, would it be possible for you to rebase it on top of
>>> renesas-next-20130523.
>> You mean to base it on this tag without any intervening patches
>> (it is now on top of my patch series)? Anyway, I'll rebase my whole
>> series on this tag as I have time (I'm now working with the SATA
>> driver to try to add to it NCQ support and fixing errors I encounter
>> on the way).
> In general I would prefer for you to post patches that are based on my tree
> without any intervening patches as it makes it significantly easier for me
> to apply them.
It's just that I've accumulated a significant queue of patches pending
merge to you tree. I'll reshuffle the series, if you consider this patch
more urgent than USB/VIN stuff.
WBR, Sergei
next prev parent reply other threads:[~2013-05-25 23:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 21:41 [PATCH v2] ARM: shmobile: BOCK-W: add Ether support Sergei Shtylyov
2013-05-25 5:30 ` Simon Horman
2013-05-25 18:08 ` Sergei Shtylyov
2013-05-25 23:22 ` Simon Horman
2013-05-25 23:40 ` Sergei Shtylyov [this message]
2013-05-26 13:33 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A14BE1.8050907@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).