linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 10/12] ARM: shmobile: r8a7740: Add CPUIdle
Date: Tue, 28 May 2013 08:08:41 +0200	[thread overview]
Message-ID: <51A449E9.5020508@linaro.org> (raw)
In-Reply-To: <20130528035446.GJ13532@quad.lixom.net>

On 05/28/2013 05:54 AM, Olof Johansson wrote:
> On Mon, May 27, 2013 at 01:03:31PM +0200, Daniel Lezcano wrote:
>> On 05/27/2013 10:59 AM, Simon Horman wrote:
>>> From: Bastian Hecht <hechtb@gmail.com>
>>>
>>> We make use of the r8a7740 Suspend To Ram code to plug together a
>>> CPUIdle driver.
>>>
>>> Signed-off-by: Bastian Hecht <hechtb+renesas@gmail.com>
>>> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>>> ---
>>
>> Shouldn't it go through Rafael's tree ? Or does the patch contains some
>> dependencies on a code only visible in the ARM tree ?
> 
> Missing S-o-b from Simon. But this patch clearly builds on the preceding
> one in the series, so merging them independently might not make much
> sense. Getting an ack from Rafael would be nice though.

I was not suggesting to put the driver in the drivers/cpuidle directory
but to merge the driver through Rafael's tree as we decided some weeks
ago [1]. Although having the drivers all over the place does not help to
consolidate the code, so moving them little by little to drivers/cpuidle
makes sense but this is part of another work.

> I was going to say that it should probably go under drivers/cpuidle as
> well, but that just seems silly -- there is practically no code to share
> with any other platform in this small driver, AND there's not really
> any subsystem-internal data exposed. So it might just make more sense
> to keep it under arch/arm instead.
> 
> Likewise, looking at the kirkwood and calxeda drivers under drivers/cpuidle,
> I'm wondering why we thought it was a good idea to merge them there, besides
> getting caught up in the "nothing can live under arch/arm any more" frenzy.

Having the drivers in the drivers/cpuidle directory like drivers/cpufreq
will help to keep a consistency with the code and a single entry point
for upstream and review.

Thanks.
  -- Daniel

[1] https://patchwork.kernel.org/patch/2492841/

-- 
 <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

  reply	other threads:[~2013-05-28  6:08 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-27  8:59 [GIT PULL] Renesas ARM based r8a7740 SoC updates for v3.11 Simon Horman
2013-05-27  8:59 ` [PATCH 01/12] ARM: shmobile: remove "; " from SH_FIXED_RATIO_CLK*() macro Simon Horman
2013-05-27  8:59 ` [PATCH 02/12] ARM: shmobile: r8a7740 pinmux platform device cleanup Simon Horman
2013-05-27  8:59 ` [PATCH 03/12] ARM: shmobile: r8a7740: Add interim sh-eth device name to clocks list Simon Horman
2013-05-27  8:59 ` [PATCH 04/12] ARM: shmobile: r8a7740: Add DT name to clock list for CMT10 Simon Horman
2013-05-28  3:29   ` Olof Johansson
2013-05-28  5:29     ` Simon Horman
2013-05-28  6:22       ` Olof Johansson
2013-05-31  7:57         ` Magnus Damm
2013-05-31 21:39           ` Arnd Bergmann
2013-06-01  4:20             ` Olof Johansson
2013-05-27  8:59 ` [PATCH 05/12] ARM: shmobile: r8a7740: Make private clock arrays static Simon Horman
2013-05-27  8:59 ` [PATCH 06/12] ARM: shmobile: r8a7740: Add I2C DT clock names Simon Horman
2013-05-28  3:30   ` Olof Johansson
2013-05-27  8:59 ` [PATCH 07/12] ARM: shmobile: r8a7740: Add OF support to initialze the GIC Simon Horman
2013-05-28  3:36   ` Olof Johansson
2013-05-27  8:59 ` [PATCH 08/12] ARM: shmobile: r8a7740: Prepare for reference DT setup Simon Horman
2013-05-27  8:59 ` [PATCH 09/12] ARM: shmobile: r8a7740: Add Suspend-To-RAM A3SM Simon Horman
2013-05-28  3:50   ` Olof Johansson
2013-05-28  5:29     ` Simon Horman
2013-05-28 21:20       ` Bastian Hecht
2013-06-04  5:09     ` Simon Horman
2013-06-04 15:34       ` Bastian Hecht
2013-06-06  1:10         ` Simon Horman
2013-05-27  8:59 ` [PATCH 10/12] ARM: shmobile: r8a7740: Add CPUIdle Simon Horman
2013-05-27 11:03   ` Daniel Lezcano
2013-05-28  3:54     ` Olof Johansson
2013-05-28  6:08       ` Daniel Lezcano [this message]
2013-06-04  5:10       ` Simon Horman
2013-05-27  8:59 ` [PATCH 11/12] ARM: shmobile: fix sleep-r8a7740.S miscompiles Simon Horman
2013-05-27  8:59 ` [PATCH 12/12] ARM: shmobile: clock-r8a7740: add TPU PWM support Simon Horman
2013-05-28  3:58 ` [GIT PULL] Renesas ARM based r8a7740 SoC updates for v3.11 Olof Johansson
2013-05-28  5:33   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51A449E9.5020508@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).