From: mkl@pengutronix.de (Marc Kleine-Budde)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx: Remove mxc specific ulpi access ops
Date: Thu, 30 May 2013 14:51:13 +0200 [thread overview]
Message-ID: <51A74B41.5010909@pengutronix.de> (raw)
In-Reply-To: <1369917895-9562-1-git-send-email-mpa@pengutronix.de>
On 05/30/2013 02:44 PM, Markus Pargmann wrote:
> There are ulpi access ops implemented in drivers/usb/phy/phy-ulpi.c.
> mxc access ops implement the same access operations within mach-imx. This
> patch removes the mxc ulpi file and uses phy-ulpi instead for
> imx_otg_ulpi_create.
>
> phy-ulpi successfully tested with i.MX27 Phytec phyCARD-S (pca100).
>
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> arch/arm/mach-imx/Kconfig | 1 +
> arch/arm/mach-imx/Makefile | 1 -
> arch/arm/mach-imx/mach-pca100.c | 4 +-
> arch/arm/mach-imx/ulpi.c | 118 ----------------------------------------
> arch/arm/mach-imx/ulpi.h | 9 ++-
> 5 files changed, 9 insertions(+), 124 deletions(-)
> delete mode 100644 arch/arm/mach-imx/ulpi.c
>
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index ba44328..ca59799 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -58,6 +58,7 @@ config MXC_USE_EPIT
>
> config MXC_ULPI
> bool
> + select USB_ULPI_VIEWPORT
>
> config ARCH_HAS_RNGA
> bool
> diff --git a/arch/arm/mach-imx/Makefile b/arch/arm/mach-imx/Makefile
> index 70ae7c4..dcb8291 100644
> --- a/arch/arm/mach-imx/Makefile
> +++ b/arch/arm/mach-imx/Makefile
> @@ -23,7 +23,6 @@ obj-$(CONFIG_ARCH_MXC_IOMUX_V3) += iomux-v3.o
> obj-$(CONFIG_MXC_TZIC) += tzic.o
> obj-$(CONFIG_MXC_AVIC) += avic.o
>
> -obj-$(CONFIG_MXC_ULPI) += ulpi.o
> obj-$(CONFIG_MXC_USE_EPIT) += epit.o
> obj-$(CONFIG_MXC_DEBUG_BOARD) += 3ds_debugboard.o
>
> diff --git a/arch/arm/mach-imx/mach-pca100.c b/arch/arm/mach-imx/mach-pca100.c
> index b8b15bb..19bb644 100644
> --- a/arch/arm/mach-imx/mach-pca100.c
> +++ b/arch/arm/mach-imx/mach-pca100.c
> @@ -398,8 +398,8 @@ static void __init pca100_init(void)
> imx27_add_fsl_usb2_udc(&otg_device_pdata);
> }
>
> - usbh2_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops,
> - ULPI_OTG_DRVVBUS | ULPI_OTG_DRVVBUS_EXT);
> + usbh2_pdata.otg = imx_otg_ulpi_create(
> + ULPI_OTG_DRVVBUS | ULPI_OTG_DRVVBUS_EXT);
Why don't you keep otg_ulpi_create()?
http://lxr.free-electrons.com/source/include/linux/usb/ulpi.h#L185
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130530/7195f3ed/attachment.sig>
next prev parent reply other threads:[~2013-05-30 12:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 12:44 [PATCH] ARM: imx: Remove mxc specific ulpi access ops Markus Pargmann
2013-05-30 12:51 ` Marc Kleine-Budde [this message]
2013-05-30 12:59 ` Markus Pargmann
2013-05-30 14:46 ` Shawn Guo
2013-05-30 15:03 ` Markus Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A74B41.5010909@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).