From mboxrd@z Thu Jan 1 00:00:00 1970 From: robherring2@gmail.com (Rob Herring) Date: Sat, 01 Jun 2013 15:30:08 -0500 Subject: [PATCH 15/15] OF: remove #ifdef from linux/of_platform.h In-Reply-To: <201306012203.39133.arnd@arndb.de> References: <1370038972-2318779-1-git-send-email-arnd@arndb.de> <1370038972-2318779-16-git-send-email-arnd@arndb.de> <201306012203.39133.arnd@arndb.de> Message-ID: <51AA59D0.7020805@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06/01/2013 03:03 PM, Arnd Bergmann wrote: > On Saturday 01 June 2013, Rob Herring wrote: >> On Fri, May 31, 2013 at 5:22 PM, Arnd Bergmann wrote: >>> A lot of code uses the functions from of_platform.h when built for >>> devicetree-enabled platforms but can also be built without them. >>> In order to avoid using #ifdef everywhere in drivers, this >>> makes all the function declarations visible, which means we >>> can use "if (IS_ENABLED(CONFIG_OF))" in driver code and get build >>> coverage over the code but let the compiler drop the reference >>> in the object code. >>> >>> Signed-off-by: Arnd Bergmann >>> Cc: Grant Likely >>> Cc: Rob Herring >> >> I've got a more complete series for 3.11 that removes OF_DEVICE and >> of_platform_driver completely. I'm waiting on ack from Ben H. > > Ok. Does your series also remove the #ifdef CONFIG_OF part from this > header? No, we still need empty functions. Here is what of_device.h looks like: http://tinyurl.com/l2azz5m BTW, it has your ack. Rob