* [PATCH] ARM: Kirkwood add cpus definition needed by cpufreq driver to dtsi
@ 2013-06-02 21:59 Adam Baker
2013-06-03 5:05 ` Andrew Lunn
2013-06-03 16:25 ` Jason Cooper
0 siblings, 2 replies; 3+ messages in thread
From: Adam Baker @ 2013-06-02 21:59 UTC (permalink / raw)
To: linux-arm-kernel
The Kirkwood CPU Freq driver needs a CPU definition in order for the probe
routine to activate it. Add a suitable definition to kirkwood.dtsi
This definition is only correct for single core SoCs. There is a dual core
SoC in the kirkwood family (88F632X) but the rest of the Kirkwood drivers in
the kernel don't currently support it. If they ever do the cpus definition
would need to be duplicated in each of the SoC specific include files.
Signed-off-by: Adam Baker <linux@baker-net.org.uk>
--- a/arch/arm/boot/dts/kirkwood.dtsi 2013-05-19 22:57:07.000000000 +0100
+++ b/arch/arm/boot/dts/kirkwood.dtsi 2013-05-30 23:32:18.000000000 +0100
@@ -4,6 +4,18 @@
compatible = "marvell,kirkwood";
interrupt-parent = <&intc>;
+ cpus {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ cpu at 0 {
+ device_type = "cpu";
+ compatible = "marvell,feroceon";
+ clocks = <&core_clk 1>, <&core_clk 3>, <&gate_clk 11>;
+ clock-names = "cpu_clk", "ddrclk", "powersave";
+ };
+ };
+
aliases {
gpio0 = &gpio0;
gpio1 = &gpio1;
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ARM: Kirkwood add cpus definition needed by cpufreq driver to dtsi
2013-06-02 21:59 [PATCH] ARM: Kirkwood add cpus definition needed by cpufreq driver to dtsi Adam Baker
@ 2013-06-03 5:05 ` Andrew Lunn
2013-06-03 16:25 ` Jason Cooper
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2013-06-03 5:05 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Jun 02, 2013 at 10:59:50PM +0100, Adam Baker wrote:
> The Kirkwood CPU Freq driver needs a CPU definition in order for the probe
> routine to activate it. Add a suitable definition to kirkwood.dtsi
>
> This definition is only correct for single core SoCs. There is a dual core
> SoC in the kirkwood family (88F632X) but the rest of the Kirkwood drivers in
> the kernel don't currently support it. If they ever do the cpus definition
> would need to be duplicated in each of the SoC specific include files.
>
> Signed-off-by: Adam Baker <linux@baker-net.org.uk>
Tested-by: Andrew Lunn <andrew@lunn.ch>
Andrew
>
>
> --- a/arch/arm/boot/dts/kirkwood.dtsi 2013-05-19 22:57:07.000000000 +0100
> +++ b/arch/arm/boot/dts/kirkwood.dtsi 2013-05-30 23:32:18.000000000 +0100
> @@ -4,6 +4,18 @@
> compatible = "marvell,kirkwood";
> interrupt-parent = <&intc>;
>
> + cpus {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + cpu at 0 {
> + device_type = "cpu";
> + compatible = "marvell,feroceon";
> + clocks = <&core_clk 1>, <&core_clk 3>, <&gate_clk 11>;
> + clock-names = "cpu_clk", "ddrclk", "powersave";
> + };
> + };
> +
> aliases {
> gpio0 = &gpio0;
> gpio1 = &gpio1;
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ARM: Kirkwood add cpus definition needed by cpufreq driver to dtsi
2013-06-02 21:59 [PATCH] ARM: Kirkwood add cpus definition needed by cpufreq driver to dtsi Adam Baker
2013-06-03 5:05 ` Andrew Lunn
@ 2013-06-03 16:25 ` Jason Cooper
1 sibling, 0 replies; 3+ messages in thread
From: Jason Cooper @ 2013-06-03 16:25 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Jun 02, 2013 at 10:59:50PM +0100, Adam Baker wrote:
> The Kirkwood CPU Freq driver needs a CPU definition in order for the probe
> routine to activate it. Add a suitable definition to kirkwood.dtsi
>
> This definition is only correct for single core SoCs. There is a dual core
> SoC in the kirkwood family (88F632X) but the rest of the Kirkwood drivers in
> the kernel don't currently support it. If they ever do the cpus definition
> would need to be duplicated in each of the SoC specific include files.
>
> Signed-off-by: Adam Baker <linux@baker-net.org.uk>
hmm, diffstat is missing. Please make sure you are using git
format-patch properly in the future.
After cleaning up some minor whitespace (needed leading tabs), applied
to mvebu/dt
thx,
Jason.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-03 16:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-02 21:59 [PATCH] ARM: Kirkwood add cpus definition needed by cpufreq driver to dtsi Adam Baker
2013-06-03 5:05 ` Andrew Lunn
2013-06-03 16:25 ` Jason Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox