linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tushar.behera@linaro.org (Tushar Behera)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: S5P64X0: Remove duplicate uncompress code
Date: Mon, 03 Jun 2013 09:48:07 +0530	[thread overview]
Message-ID: <51AC18FF.9010108@linaro.org> (raw)
In-Reply-To: <51A9B3BC.9000405@gmail.com>

On 06/01/2013 02:11 PM, Sylwester Nawrocki wrote:
> Hi,
> 
> On 05/31/2013 01:49 PM, Tushar Behera wrote:
>> The uncompress code in S5P64X0 is almost same as the uncompress code
>> defined in plat-samsung. Better to reuse that code.
>>
>> Signed-off-by: Tushar Behera<tushar.behera@linaro.org>
>> ---
>>   arch/arm/mach-s5p64x0/include/mach/uncompress.h |  163
>> ++---------------------
>>   1 file changed, 8 insertions(+), 155 deletions(-)
> 
> Not sure if you are aware of it, Tomasz has already posted a patch that
> removes this duplicated code: https://patchwork.kernel.org/patch/2589331
> I think that patch is not yet merged though.
> 
> Regards,
> Sylwester

Tomasz,

I had somehow missed that mail.

The patch that I have additionally makes calculation of uart_base
conditional on DEBUG_LL in line with the rest of the patches.

Would you mind re-spining your patch with those changes?

Alternately, I can take your patch and do above modifications in them.

Let me know your opinion on this.

-- 
Tushar Behera

  reply	other threads:[~2013-06-03  4:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-31 11:49 [PATCH 0/3] Consolidate uncompress code for Samsung platform Tushar Behera
2013-05-31 11:49 ` [PATCH 1/3] ARM: EXYNOS: uncompress - print debug messages if DEBUG_LL is defined Tushar Behera
2013-06-01  3:59   ` Olof Johansson
2013-06-03  4:57     ` Tushar Behera
2013-05-31 11:49 ` [PATCH 2/3] ARM: SAMSUNG: Consolidate uncompress subroutine Tushar Behera
2013-06-01  4:00   ` Olof Johansson
2013-05-31 11:49 ` [PATCH 3/3] ARM: S5P64X0: Remove duplicate uncompress code Tushar Behera
2013-06-01  8:41   ` Sylwester Nawrocki
2013-06-03  4:18     ` Tushar Behera [this message]
2013-06-03 11:40       ` Tomasz Figa
2013-06-03 11:55         ` Tushar Behera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51AC18FF.9010108@linaro.org \
    --to=tushar.behera@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).