From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 2/3] ARM: shmobile: r8a7778: add USB support
Date: Tue, 04 Jun 2013 14:22:03 +0400 [thread overview]
Message-ID: <51ADBFCB.8040206@cogentembedded.com> (raw)
In-Reply-To: <87zjv64eg1.wl%kuninori.morimoto.gx@renesas.com>
Hello.
On 04-06-2013 9:45, Kuninori Morimoto wrote:
>>> The ohci/ehci resource will be used vainly if platform doesn't have USB
>> The platform device resources are never used vainly. And remember
>> that if PHY doesn't get registered, OHCI/EHCI won't get probed
>> successfully either -- mind the usb_power_on() platform method.
> ?
> Could you please teach me who/how/when free resource memory
> which was kmemdup'ed by platform_device_add_xxx()
> (and kmalloc'ed dma_mask) on platform_device_register_full() ??
I don't think there's a need to free them. The EHCI/OHCI devices
are always there after all.
>>> ohci/ehci and phy should be registered in same time/function.
>> I just copied your approach from the R8A7779 code.
> Ahh, yes, indeed
Moreover, from our prior testing, I'm afraid registering USB PHY
and EHCI/OHCI in one function wouldn't work. Unless maybe if it's done
from the init_late() machine's method...
> Best regards
> ---
> Kuninori Morimoto
WBR, Sergei
next prev parent reply other threads:[~2013-06-04 10:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-01 22:06 [PATCH v8 0/3] Add USB support to R8A7778/BOCK-W Sergei Shtylyov
2013-06-01 22:10 ` [PATCH v8 2/3] ARM: shmobile: r8a7778: add USB support Sergei Shtylyov
2013-06-03 0:24 ` Kuninori Morimoto
2013-06-03 10:14 ` Sergei Shtylyov
2013-06-04 5:45 ` Kuninori Morimoto
2013-06-04 10:22 ` Sergei Shtylyov [this message]
2013-06-05 0:17 ` Kuninori Morimoto
2013-06-01 22:12 ` [PATCH v8 3/3] ARM: shmobile: BOCK-W: " Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ADBFCB.8040206@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).