linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: gang.chen@asianux.com (Chen Gang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm64: kernel: compiling issue, need delete read_current_timer().
Date: Sat, 08 Jun 2013 12:37:30 +0800	[thread overview]
Message-ID: <51B2B50A.1050305@asianux.com> (raw)
In-Reply-To: <51A32F40.1050309@asianux.com>

Hello Maintainers:

Please help check it, when you have time.

Thanks.

On 05/27/2013 06:02 PM, Chen Gang wrote:
> Hello Maintainers:
> 
> Please help check this patch whether OK, when you have time.
> 
> Thanks.
> 
> On 05/21/2013 05:46 PM, Chen Gang wrote:
>>
>> Under arm64, we will calibrate the delay loop statically using a known
>> timer frequency, so delete read_current_timer(), or it will cause
>> compiling issue with allmodconfig.
>>
>> The related error:
>>   ERROR: "read_current_timer" [lib/rbtree_test.ko] undefined!
>>   ERROR: "read_current_timer" [lib/interval_tree_test.ko] undefined!
>>   ERROR: "read_current_timer" [fs/ext4/ext4.ko] undefined!
>>   ERROR: "read_current_timer" [crypto/tcrypt.ko] undefined!
>>
>>
>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>> ---
>>  arch/arm64/include/asm/timex.h |    6 +++---
>>  arch/arm64/kernel/time.c       |    6 ------
>>  2 files changed, 3 insertions(+), 9 deletions(-)
>>
>> diff --git a/arch/arm64/include/asm/timex.h b/arch/arm64/include/asm/timex.h
>> index b24a31a..81a076e 100644
>> --- a/arch/arm64/include/asm/timex.h
>> +++ b/arch/arm64/include/asm/timex.h
>> @@ -16,14 +16,14 @@
>>  #ifndef __ASM_TIMEX_H
>>  #define __ASM_TIMEX_H
>>  
>> +#include <asm/arch_timer.h>
>> +
>>  /*
>>   * Use the current timer as a cycle counter since this is what we use for
>>   * the delay loop.
>>   */
>> -#define get_cycles()	({ cycles_t c; read_current_timer(&c); c; })
>> +#define get_cycles()	arch_counter_get_cntvct()
>>  
>>  #include <asm-generic/timex.h>
>>  
>> -#define ARCH_HAS_READ_CURRENT_TIMER
>> -
>>  #endif
>> diff --git a/arch/arm64/kernel/time.c b/arch/arm64/kernel/time.c
>> index a551f88..03dc371 100644
>> --- a/arch/arm64/kernel/time.c
>> +++ b/arch/arm64/kernel/time.c
>> @@ -68,12 +68,6 @@ unsigned long long notrace sched_clock(void)
>>  	return arch_timer_read_counter() * sched_clock_mult;
>>  }
>>  
>> -int read_current_timer(unsigned long *timer_value)
>> -{
>> -	*timer_value = arch_timer_read_counter();
>> -	return 0;
>> -}
>> -
>>  void __init time_init(void)
>>  {
>>  	u32 arch_timer_rate;
>>
> 
> 


-- 
Chen Gang

Asianux Corporation

  reply	other threads:[~2013-06-08  4:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-20  6:48 [PATCH] arm64: kernel: compiling issue, need 'EXPORT_SYMBOL_GPL(read_current_timer)' Chen Gang
2013-05-20  7:15 ` Marc Zyngier
2013-05-20  9:56   ` Will Deacon
2013-05-21  4:06     ` Chen Gang
2013-05-21  6:13       ` Marc Zyngier
2013-05-21  8:41         ` Chen Gang
2013-05-21  8:58           ` Marc Zyngier
2013-05-21  9:26             ` Chen Gang
2013-05-21  8:53       ` Will Deacon
2013-05-21  9:27         ` Chen Gang
2013-05-21  9:46         ` [PATCH v2] arm64: kernel: compiling issue, need delete read_current_timer() Chen Gang
2013-05-27 10:02           ` Chen Gang
2013-06-08  4:37             ` Chen Gang [this message]
2013-06-10  8:57               ` Will Deacon
2013-06-13  1:12                 ` Chen Gang
2013-06-10  8:57               ` Marc Zyngier
2013-06-13  1:13                 ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51B2B50A.1050305@asianux.com \
    --to=gang.chen@asianux.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).