From mboxrd@z Thu Jan  1 00:00:00 1970
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
Date: Mon, 10 Jun 2013 16:35:25 +0400
Subject: [PATCH 6/6] mtd: ofpart: add compatible check for child nodes
In-Reply-To: <1370860014-1770-7-git-send-email-josh.wu@atmel.com>
References: <1370860014-1770-1-git-send-email-josh.wu@atmel.com>
 <1370860014-1770-7-git-send-email-josh.wu@atmel.com>
Message-ID: <51B5C80D.2030303@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

hello.

On 10-06-2013 14:26, Josh Wu wrote:

> If the child node has compatible property then it is a driver not partition.

> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> ---
>   drivers/mtd/ofpart.c |   14 +++++++++++++-
>   1 file changed, 13 insertions(+), 1 deletion(-)


> diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c
> index 553d6d6..61ce1f8 100644
> --- a/drivers/mtd/ofpart.c
> +++ b/drivers/mtd/ofpart.c
[...]
> @@ -40,8 +44,13 @@ static int parse_ofpart_partitions(struct mtd_info *master,
>   	/* First count the subnodes */
>   	pp = NULL;
>   	nr_parts = 0;
> -	while ((pp = of_get_next_child(node, pp)))
> +	while ((pp = of_get_next_child(node, pp))) {

    Assignment in *while*? Is scripts/checkpatch.pl happy about that?

> +		int len;

    Empty line wouldn't hurt here, after declaration.

> +		if (node_has_compatible(pp, &len))
> +			continue;
> +
>   		nr_parts++;
> +	}
>
>   	if (nr_parts == 0)
>   		return 0;

WBR, Sergei