linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: csd@broadcom.com (Christian Daudt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clocksource: kona: adapt to CLOCKSOURCE_OF_DECLARE change
Date: Tue, 11 Jun 2013 11:47:51 -0700	[thread overview]
Message-ID: <51B770D7.6000000@broadcom.com> (raw)
In-Reply-To: <3174210.ZivUajNGev@wuerfel>

On 13-05-31 01:59 PM, Arnd Bergmann wrote:
> The CLOCKSOURCE_OF_DECLARE functions now take a device_node pointer
> as their argument, as of the clksrc/cleanup branch in arm-soc.
> This patch adapts the bcm_kona_timer driver to the new interface.
>
> This causes an annoying but harmless build-time warning, it would
> be nice to have this fixed in 3.10.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Christian Daudt <csd@broadcom.com>
> Cc: John Stultz <john.stultz@linaro.org>
> ---
> diff --git a/drivers/clocksource/bcm_kona_timer.c b/drivers/clocksource/bcm_kona_timer.c
> index 350f493..ba3d859 100644
> --- a/drivers/clocksource/bcm_kona_timer.c
> +++ b/drivers/clocksource/bcm_kona_timer.c
> @@ -103,16 +103,10 @@ static const struct of_device_id bcm_timer_ids[] __initconst = {
>   	{},
>   };
>   
> -static void __init kona_timers_init(void)
> +static void __init kona_timers_init(struct device_node *node)
>   {
> -	struct device_node *node;
>   	u32 freq;
>   
> -	node = of_find_matching_node(NULL, bcm_timer_ids);
> -
> -	if (!node)
> -		panic("No timer");
> -
>   	if (!of_property_read_u32(node, "clock-frequency", &freq))
>   		arch_timer_rate = freq;
>   	else
> @@ -199,13 +193,12 @@ static struct irqaction kona_timer_irq = {
>   	.handler = kona_timer_interrupt,
>   };
>   
> -static void __init kona_timer_init(void)
> +static void __init kona_timer_init(struct device_node *node)
>   {
> -	kona_timers_init();
> +	kona_timers_init(node);
>   	kona_timer_clockevents_init();
>   	setup_irq(timers.tmr_irq, &kona_timer_irq);
>   	kona_timer_set_next_event((arch_timer_rate / HZ), NULL);
>   }
>   
> -CLOCKSOURCE_OF_DECLARE(bcm_kona, "bcm,kona-timer",
> -	kona_timer_init);
> +CLOCKSOURCE_OF_DECLARE(bcm_kona, "bcm,kona-timer", kona_timer_init);
>
>
Acked-by: Christian Daudt <csd@broadcom.com>

Do you want this for 3.10 or should I add to my 3.11 tree ?
  Thanks,
    csd

  reply	other threads:[~2013-06-11 18:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-31 20:59 [PATCH] clocksource: kona: adapt to CLOCKSOURCE_OF_DECLARE change Arnd Bergmann
2013-06-11 18:47 ` Christian Daudt [this message]
2013-06-19 23:47   ` Arnd Bergmann
  -- strict thread matches above, loose matches on Subject: below --
2013-04-23 15:54 [PATCH] ARM: allmodconfig regressions in linux-next Arnd Bergmann
2013-04-23 15:54 ` [PATCH] clocksource: kona: adapt to CLOCKSOURCE_OF_DECLARE change Arnd Bergmann
2013-04-26 15:42   ` Christian Daudt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51B770D7.6000000@broadcom.com \
    --to=csd@broadcom.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).