linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jarkko.nikula@bitmer.com (Jarkko Nikula)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/8] ARM: OMAP2+: hwmod: Remove remaining DMA channel definitions
Date: Sun, 16 Jun 2013 18:35:13 +0300	[thread overview]
Message-ID: <51BDDB31.2000200@bitmer.com> (raw)
In-Reply-To: <20130615150650.GB27629@arwen.pp.htv.fi>

Hi Felipe

On 06/15/2013 06:06 PM, Felipe Balbi wrote:
> On Sat, Jun 15, 2013 at 11:31:04AM +0300, Jarkko Nikula wrote:
>> Last remaining DMA channel definitions in arch/arm/mach-omap2/dma.h
>> are used only by omap_hwmod_2xxx_3xxx_ipblock_data.c and
>> omap_hwmod_3xxx_data.c. Remove them by using directly DMA channel number in
>> hwmod data and drop definitions with a following script:
>>
>> egrep '#define [OMAP|AM35XX].*DMA' arch/arm/mach-omap2/dma.h | cut -f 1,3 \
>> 	| while read i; do \
>> 		DEF=`echo $i |cut -d ' ' -f 2`; \
>> 		CH=`echo $i |cut -d ' ' -f 3`; \
>> 		echo "removing" $DEF; \
>> 		sed -i "s/${DEF}/${CH}/" arch/arm/mach-omap2/omap_hwmod_*.c; \
>> 		sed -i "/${DEF}/d" arch/arm/mach-omap2/dma.h; \
>> 	done
>>
>>  /* DMA channels for 24xx */
> 
> could remove the comments too.
> 
You are right. Actually I was thinking that myself too with this and
omap1 patches but decided to keep manual work and scripts bare minimum
and let final git rm in 4/8 and 8/8 to handle these :-)

-- 
Jarkko

  reply	other threads:[~2013-06-16 15:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-15  8:31 [PATCH 0/8] ARM: OMAP: dma.h and legacy code removal Jarkko Nikula
2013-06-15  8:31 ` [PATCH 1/8] ARM: OMAP2+: Remove AES crypto device DMA channel definitions Jarkko Nikula
2013-06-15  8:31 ` [PATCH 2/8] ARM: OMAP2+: Remove duplicated " Jarkko Nikula
2013-06-15  8:31 ` [PATCH 3/8] ARM: OMAP2+: hwmod: Remove remaining " Jarkko Nikula
2013-06-15 15:06   ` Felipe Balbi
2013-06-16 15:35     ` Jarkko Nikula [this message]
2013-06-17  3:29   ` Paul Walmsley
2013-06-15  8:31 ` [PATCH 4/8] ARM: OMAP2+: Remove dma.h Jarkko Nikula
2013-06-15  8:31 ` [PATCH 5/8] ARM: OMAP1: Remove McBSP DMA channel definitions Jarkko Nikula
2013-06-15  8:31 ` [PATCH 6/8] ARM: OMAP1: Remove duplicated " Jarkko Nikula
2013-06-15  8:31 ` [PATCH 7/8] ARM: OMAP1: Remove legacy irda.h and irda setup from board files Jarkko Nikula
2013-06-15  8:31 ` [PATCH 8/8] ARM: OMAP1: Remove dma.h Jarkko Nikula
2013-06-18  7:13 ` [PATCH 0/8] ARM: OMAP: dma.h and legacy code removal Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51BDDB31.2000200@bitmer.com \
    --to=jarkko.nikula@bitmer.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).