From mboxrd@z Thu Jan 1 00:00:00 1970 From: srinivas.kandagatla@st.com (Srinivas KANDAGATLA) Date: Fri, 21 Jun 2013 07:50:51 +0100 Subject: [PATCH v3 06/10] ARM:stixxxx: Add DEBUG_LL console support In-Reply-To: <201306202055.43189.arnd@arndb.de> References: <1371736996-8770-1-git-send-email-srinivas.kandagatla@st.com> <1371737176-9473-1-git-send-email-srinivas.kandagatla@st.com> <201306202055.43189.arnd@arndb.de> Message-ID: <51C3F7CB.70703@st.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 20/06/13 19:55, Arnd Bergmann wrote: > On Thursday 20 June 2013, Srinivas KANDAGATLA wrote: >> --- a/arch/arm/mach-stixxxx/board-dt.c >> +++ b/arch/arm/mach-stixxxx/board-dt.c >> @@ -11,6 +11,7 @@ >> #include >> #include >> #include >> +#include >> #include >> >> #include "smp.h" >> @@ -42,6 +43,7 @@ static const char *stih41x_dt_match[] __initdata = { >> }; >> >> DT_MACHINE_START(STM, "STiH415/416 SoC with Flattened Device Tree") >> + .map_io = debug_ll_io_init, >> .init_time = stih41x_timer_init, >> .smp = smp_ops(stixxxx_smp_ops), >> .dt_compat = stih41x_dt_match, > > This part of the patch is no longer needed, we do the same when .map_io > is not set. I can see the commit bc37324e "ARM: mmu: Call debug_ll_io_init if no map_io function is specified" in arm-soc.git:for-next branch. That makes sense to take care of this before this patch gets merged. I will remove this line in next spin hopefully very soon. Thanks, srini > > Arnd > >