From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 1/3] iio: Add Nuvoton NAU7802 ADC driver
Date: Sat, 22 Jun 2013 14:02:05 +0200 [thread overview]
Message-ID: <51C5923D.6030609@metafoo.de> (raw)
In-Reply-To: <51C590B5.2060308@kernel.org>
On 06/22/2013 01:55 PM, Jonathan Cameron wrote:
> On 06/20/2013 07:57 PM, Alexandre Belloni wrote:
>> The Nuvoton NAU7802 ADC is a 24-bit 2-channels I2C ADC, with adjustable
>> gain and sampling rates.
>>
> Sorry, somewhat low on time today so only a quick review.
>
> 1) Missing userspace ABI documentation. Also, perhaps min_conversions is
> a little vague? Not that I have a better idea!
I really don't like the name min_conversions either. Isn't this effectively
a decimation filter?
- Lars
next prev parent reply other threads:[~2013-06-22 12:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 18:57 [PATCHv2 0/3] Add support for the Nuvoton NAU7802 ADC to the cfa10049 Alexandre Belloni
2013-06-20 18:57 ` [PATCHv2 1/3] iio: Add Nuvoton NAU7802 ADC driver Alexandre Belloni
2013-06-22 11:55 ` Jonathan Cameron
2013-06-22 12:02 ` Lars-Peter Clausen [this message]
2013-06-22 13:07 ` Alexandre Belloni
2013-06-22 13:20 ` Lars-Peter Clausen
2013-06-22 13:28 ` Alexandre Belloni
2013-06-23 13:54 ` Lars-Peter Clausen
2013-06-23 17:33 ` Jonathan Cameron
2013-06-24 6:41 ` Lars-Peter Clausen
2013-06-24 10:37 ` Alexandre Belloni
2013-06-24 16:41 ` Lars-Peter Clausen
2013-06-24 17:26 ` Alexandre Belloni
2013-06-20 18:57 ` [PATCHv2 2/3] ARM: mxs: cfa10049: Switch bus i2c1 to bitbanging Alexandre Belloni
2013-06-21 22:27 ` Fabio Estevam
2013-07-02 13:29 ` Christoph G. Baumann
2013-07-02 13:57 ` Fabio Estevam
2013-07-02 14:09 ` Christoph G. Baumann
2013-07-02 16:04 ` Fabio Estevam
2013-06-20 18:57 ` [PATCHv2 3/3] ARM: mxs: cfa10049: Add NAU7802 ADCs to the device tree Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C5923D.6030609@metafoo.de \
--to=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).