From: monstr@monstr.eu (Michal Simek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk/zynq/clkc: Add dedicated spinlock for the SWDT
Date: Wed, 26 Jun 2013 11:57:56 +0200 [thread overview]
Message-ID: <51CABB24.7010009@monstr.eu> (raw)
In-Reply-To: <fe16e203-47cf-4465-8a9d-3c3e516d2d5e@VA3EHSMHS028.ehs.local>
On 06/24/2013 05:58 PM, S?ren Brinkmann wrote:
> ping?
>
> On Mon, Jun 17, 2013 at 03:03:46PM -0700, Soren Brinkmann wrote:
>> The clk_mux for the system watchdog timer reused the register lock
>> dedicated to the Ethernet module - for no apparent reason.
>> Add a lock dedicated to the SWDT's clock register to remove this
>> wrong dependency.
>>
>> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
>> ---
>> I don't know how this slipped in...
>> Anyway, the fix depends on armsoc/zynq/clk.
>>
>> S?ren
>>
>> drivers/clk/zynq/clkc.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/clk/zynq/clkc.c b/drivers/clk/zynq/clkc.c
>> index 5c205b6..515a573 100644
>> --- a/drivers/clk/zynq/clkc.c
>> +++ b/drivers/clk/zynq/clkc.c
>> @@ -71,6 +71,7 @@ static DEFINE_SPINLOCK(armpll_lock);
>> static DEFINE_SPINLOCK(ddrpll_lock);
>> static DEFINE_SPINLOCK(iopll_lock);
>> static DEFINE_SPINLOCK(armclk_lock);
>> +static DEFINE_SPINLOCK(swdtclk_lock);
>> static DEFINE_SPINLOCK(ddrclk_lock);
>> static DEFINE_SPINLOCK(dciclk_lock);
>> static DEFINE_SPINLOCK(gem0clk_lock);
>> @@ -293,7 +294,7 @@ static void __init zynq_clk_setup(struct device_node *np)
>> }
>> clks[swdt] = clk_register_mux(NULL, clk_output_name[swdt],
>> swdt_ext_clk_mux_parents, 2, CLK_SET_RATE_PARENT,
>> - SLCR_SWDT_CLK_SEL, 0, 1, 0, &gem0clk_lock);
>> + SLCR_SWDT_CLK_SEL, 0, 1, 0, &swdtclk_lock);
>>
>> /* DDR clocks */
>> clk = clk_register_divider(NULL, "ddr2x_div", "ddrpll", 0,
>> --
>> 1.8.3.1
Applied.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130626/bf56d63c/attachment-0001.sig>
prev parent reply other threads:[~2013-06-26 9:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 22:03 [PATCH] clk/zynq/clkc: Add dedicated spinlock for the SWDT Soren Brinkmann
2013-06-24 15:58 ` Sören Brinkmann
2013-06-26 9:57 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CABB24.7010009@monstr.eu \
--to=monstr@monstr.eu \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).