* [PATCH 1/3] ARM: dts: Put Arndale fixed voltage regulators on a simple-bus
@ 2013-07-01 21:36 Mark Brown
2013-07-01 21:36 ` [PATCH 2/3] ARM: dts: Hook up supplies for Arndale S5M8767 Mark Brown
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Mark Brown @ 2013-07-01 21:36 UTC (permalink / raw)
To: linux-arm-kernel
From: Mark Brown <broonie@linaro.org>
Fixed voltage regulators (and other similar free standing things) are
supposed to go on a simple-bus for DT correctness reasons.
Signed-off-by: Mark Brown <broonie@linaro.org>
---
arch/arm/boot/dts/exynos5250-arndale.dts | 28 +++++++++++++++++-----------
1 file changed, 17 insertions(+), 11 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
index abc7272..68a13a6 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -429,18 +429,24 @@
vdd-supply = <&ldo8_reg>;
};
- mmc_reg: voltage-regulator {
- compatible = "regulator-fixed";
- regulator-name = "VDD_33ON_2.8V";
- regulator-min-microvolt = <2800000>;
- regulator-max-microvolt = <2800000>;
- gpio = <&gpx1 1 1>;
- enable-active-high;
- };
+ regulators {
+ compatible = "simple-bus";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ mmc_reg: voltage-regulator {
+ compatible = "regulator-fixed";
+ regulator-name = "VDD_33ON_2.8V";
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
+ gpio = <&gpx1 1 1>;
+ enable-active-high;
+ };
- reg_hdmi_en: fixedregulator at 0 {
- compatible = "regulator-fixed";
- regulator-name = "hdmi-en";
+ reg_hdmi_en: fixedregulator at 0 {
+ compatible = "regulator-fixed";
+ regulator-name = "hdmi-en";
+ };
};
fixed-rate-clocks {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 2/3] ARM: dts: Hook up supplies for Arndale S5M8767
2013-07-01 21:36 [PATCH 1/3] ARM: dts: Put Arndale fixed voltage regulators on a simple-bus Mark Brown
@ 2013-07-01 21:36 ` Mark Brown
2013-07-01 21:36 ` [PATCH 3/3] ARM: dts: Add WM1811A audio CODEC to Arndale bindings Mark Brown
2013-07-05 23:36 ` [PATCH 1/3] ARM: dts: Put Arndale fixed voltage regulators on a simple-bus Tomasz Figa
2 siblings, 0 replies; 10+ messages in thread
From: Mark Brown @ 2013-07-01 21:36 UTC (permalink / raw)
To: linux-arm-kernel
From: Mark Brown <broonie@linaro.org>
As part of this add nodes for the main wall supply as well as bucks 7
and 8 which are used to drop that down for several of the LDOs.
Signed-off-by: Mark Brown <broonie@linaro.org>
---
arch/arm/boot/dts/exynos5250-arndale.dts | 35 ++++++++++++++++++++++++++++++++
1 file changed, 35 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
index 68a13a6..482f275 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -38,6 +38,26 @@
compatible = "samsung,s5m8767-pmic";
reg = <0x66>;
+ vinb1-supply = <&main_dc_reg>;
+ vinb2-supply = <&main_dc_reg>;
+ vinb3-supply = <&main_dc_reg>;
+ vinb4-supply = <&main_dc_reg>;
+ vinb5-supply = <&main_dc_reg>;
+ vinb6-supply = <&main_dc_reg>;
+ vinb7-supply = <&main_dc_reg>;
+ vinb8-supply = <&main_dc_reg>;
+ vinb9-supply = <&main_dc_reg>;
+
+ vinl1-supply = <&buck7_reg>;
+ vinl2-supply = <&buck7_reg>;
+ vinl3-supply = <&buck7_reg>;
+ vinl4-supply = <&main_dc_reg>;
+ vinl5-supply = <&main_dc_reg>;
+ vinl6-supply = <&main_dc_reg>;
+ vinl7-supply = <&main_dc_reg>;
+ vinl8-supply = <&buck8_reg>;
+ vinl9-supply = <&buck8_reg>;
+
s5m8767,pmic-buck2-dvs-voltage = <1300000>;
s5m8767,pmic-buck3-dvs-voltage = <1100000>;
s5m8767,pmic-buck4-dvs-voltage = <1200000>;
@@ -276,6 +296,16 @@
op_mode = <1>;
};
+ buck7_reg: BUCK7 {
+ regulator-name = "PVDD_BUCK7";
+ regulator-always-on;
+ };
+
+ buck8_reg: BUCK8 {
+ regulator-name = "PVDD_BUCK8";
+ regulator-always-on;
+ };
+
buck9_reg: BUCK9 {
regulator-name = "VDD_33_OFF_EXT1";
regulator-min-microvolt = <750000>;
@@ -434,6 +464,11 @@
#address-cells = <1>;
#size-cells = <0>;
+ main_dc_reg: fixedregulator at 1 {
+ compatible = "regulator-fixed";
+ regulator-name = "MAIN_DC";
+ };
+
mmc_reg: voltage-regulator {
compatible = "regulator-fixed";
regulator-name = "VDD_33ON_2.8V";
--
1.8.3.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 3/3] ARM: dts: Add WM1811A audio CODEC to Arndale bindings
2013-07-01 21:36 [PATCH 1/3] ARM: dts: Put Arndale fixed voltage regulators on a simple-bus Mark Brown
2013-07-01 21:36 ` [PATCH 2/3] ARM: dts: Hook up supplies for Arndale S5M8767 Mark Brown
@ 2013-07-01 21:36 ` Mark Brown
2013-07-01 21:47 ` Fabio Estevam
2013-07-02 5:21 ` Tushar Behera
2013-07-05 23:36 ` [PATCH 1/3] ARM: dts: Put Arndale fixed voltage regulators on a simple-bus Tomasz Figa
2 siblings, 2 replies; 10+ messages in thread
From: Mark Brown @ 2013-07-01 21:36 UTC (permalink / raw)
To: linux-arm-kernel
From: Mark Brown <broonie@linaro.org>
The default audio module for the Arndale has a WM811A on it. Add this to
the device tree bindings.
Signed-off-by: Mark Brown <broonie@linaro.org>
---
arch/arm/boot/dts/exynos5250-arndale.dts | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
index 482f275..75c3065 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -325,7 +325,22 @@
};
i2c at 12C90000 {
- status = "disabled";
+ wm1811a at 11 {
+ compatible = "wlf,wm1811";
+ reg = <0x1a>;
+
+ AVDD2-supply = <&main_dc_reg>;
+ CPVDD-supply = <&main_dc_reg>;
+ DBVDD1-supply = <&main_dc_reg>;
+ DBVDD2-supply = <&main_dc_reg>;
+ DBVDD3-supply = <&main_dc_reg>;
+ LDO1VDD-supply = <&main_dc_reg>;
+ SPKVDD1-supply = <&main_dc_reg>;
+ SPKVDD2-supply = <&main_dc_reg>;
+
+ wlf,ldo1ena = <&gpb0 0 0>;
+ wlf,ldo2ena = <&gpb0 1 0>;
+ };
};
i2c at 12CA0000 {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 3/3] ARM: dts: Add WM1811A audio CODEC to Arndale bindings
2013-07-01 21:36 ` [PATCH 3/3] ARM: dts: Add WM1811A audio CODEC to Arndale bindings Mark Brown
@ 2013-07-01 21:47 ` Fabio Estevam
2013-07-01 22:38 ` Mark Brown
2013-07-02 5:21 ` Tushar Behera
1 sibling, 1 reply; 10+ messages in thread
From: Fabio Estevam @ 2013-07-01 21:47 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jul 1, 2013 at 6:36 PM, Mark Brown <broonie@kernel.org> wrote:
> i2c at 12C90000 {
> - status = "disabled";
> + wm1811a at 11 {
> + compatible = "wlf,wm1811";
> + reg = <0x1a>;
Shouldn't it be reg = <0x11> ? Or wm1811a at 1a ?
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 3/3] ARM: dts: Add WM1811A audio CODEC to Arndale bindings
2013-07-01 21:36 ` [PATCH 3/3] ARM: dts: Add WM1811A audio CODEC to Arndale bindings Mark Brown
2013-07-01 21:47 ` Fabio Estevam
@ 2013-07-02 5:21 ` Tushar Behera
2013-07-02 9:25 ` Mark Brown
1 sibling, 1 reply; 10+ messages in thread
From: Tushar Behera @ 2013-07-02 5:21 UTC (permalink / raw)
To: linux-arm-kernel
On 07/02/2013 03:06 AM, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> The default audio module for the Arndale has a WM811A on it. Add this to
typo: WM1811A
Arndale board also comes with two other audio codec boards - ALC5631Q
and AK4678. Different audio codec boards came with different shipments.
> the device tree bindings.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
> arch/arm/boot/dts/exynos5250-arndale.dts | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
> index 482f275..75c3065 100644
> --- a/arch/arm/boot/dts/exynos5250-arndale.dts
> +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
> @@ -325,7 +325,22 @@
> };
>
> i2c at 12C90000 {
> - status = "disabled";
> + wm1811a at 11 {
> + compatible = "wlf,wm1811";
> + reg = <0x1a>;
> +
> + AVDD2-supply = <&main_dc_reg>;
> + CPVDD-supply = <&main_dc_reg>;
> + DBVDD1-supply = <&main_dc_reg>;
> + DBVDD2-supply = <&main_dc_reg>;
> + DBVDD3-supply = <&main_dc_reg>;
> + LDO1VDD-supply = <&main_dc_reg>;
> + SPKVDD1-supply = <&main_dc_reg>;
> + SPKVDD2-supply = <&main_dc_reg>;
> +
> + wlf,ldo1ena = <&gpb0 0 0>;
> + wlf,ldo2ena = <&gpb0 1 0>;
> + };
> };
>
> i2c at 12CA0000 {
>
--
Tushar Behera
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 3/3] ARM: dts: Add WM1811A audio CODEC to Arndale bindings
2013-07-02 5:21 ` Tushar Behera
@ 2013-07-02 9:25 ` Mark Brown
2013-07-24 1:50 ` Kukjin Kim
0 siblings, 1 reply; 10+ messages in thread
From: Mark Brown @ 2013-07-02 9:25 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jul 02, 2013 at 10:51:36AM +0530, Tushar Behera wrote:
> Arndale board also comes with two other audio codec boards - ALC5631Q
> and AK4678. Different audio codec boards came with different shipments.
This is the default though and since they didn't bother providing any
way of identifying the modules we just have to put them all in the
device tree and hope that the individual CODEC drivers can do runtime
identification (the WM1811A can but I don't know about the other two,
nobody supported them upstream).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130702/4a28b8a7/attachment-0001.sig>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 3/3] ARM: dts: Add WM1811A audio CODEC to Arndale bindings
2013-07-02 9:25 ` Mark Brown
@ 2013-07-24 1:50 ` Kukjin Kim
0 siblings, 0 replies; 10+ messages in thread
From: Kukjin Kim @ 2013-07-24 1:50 UTC (permalink / raw)
To: linux-arm-kernel
Mark Brown wrote:
>
> On Tue, Jul 02, 2013 at 10:51:36AM +0530, Tushar Behera wrote:
>
> > Arndale board also comes with two other audio codec boards - ALC5631Q
> > and AK4678. Different audio codec boards came with different shipments.
>
> This is the default though and since they didn't bother providing any
> way of identifying the modules we just have to put them all in the
> device tree and hope that the individual CODEC drivers can do runtime
> identification (the WM1811A can but I don't know about the other two,
> nobody supported them upstream).
Basically, I agree with Mark Brown's opinion, at this moment would be better
if upstreamed WM1811A could be supported on Arndale and if further
supporting of two codecs is required, we could discuss again next time. And
they should be identified in the kernel at runtime.
- Kukjin
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/3] ARM: dts: Put Arndale fixed voltage regulators on a simple-bus
2013-07-01 21:36 [PATCH 1/3] ARM: dts: Put Arndale fixed voltage regulators on a simple-bus Mark Brown
2013-07-01 21:36 ` [PATCH 2/3] ARM: dts: Hook up supplies for Arndale S5M8767 Mark Brown
2013-07-01 21:36 ` [PATCH 3/3] ARM: dts: Add WM1811A audio CODEC to Arndale bindings Mark Brown
@ 2013-07-05 23:36 ` Tomasz Figa
2013-07-06 9:19 ` Mark Brown
2 siblings, 1 reply; 10+ messages in thread
From: Tomasz Figa @ 2013-07-05 23:36 UTC (permalink / raw)
To: linux-arm-kernel
Hi Mark,
On Monday 01 of July 2013 22:36:37 Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> Fixed voltage regulators (and other similar free standing things) are
> supposed to go on a simple-bus for DT correctness reasons.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
> arch/arm/boot/dts/exynos5250-arndale.dts | 28
> +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11
> deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
> b/arch/arm/boot/dts/exynos5250-arndale.dts index abc7272..68a13a6
> 100644
> --- a/arch/arm/boot/dts/exynos5250-arndale.dts
> +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
> @@ -429,18 +429,24 @@
> vdd-supply = <&ldo8_reg>;
> };
>
> - mmc_reg: voltage-regulator {
> - compatible = "regulator-fixed";
> - regulator-name = "VDD_33ON_2.8V";
> - regulator-min-microvolt = <2800000>;
> - regulator-max-microvolt = <2800000>;
> - gpio = <&gpx1 1 1>;
> - enable-active-high;
> - };
> + regulators {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <0>;
Are the two #properties above really necessary? The regulators that will
be placed here probably don't need any kind of addressing, so it should be
possible to omit them.
> +
> + mmc_reg: voltage-regulator {
I'd suggest suffixing name of this node with an index, like voltage-
regulator-0 to be more future proof, in case of further fixed regulators
being added.
> + compatible = "regulator-fixed";
> + regulator-name = "VDD_33ON_2.8V";
> + regulator-min-microvolt = <2800000>;
> + regulator-max-microvolt = <2800000>;
> + gpio = <&gpx1 1 1>;
> + enable-active-high;
> + };
>
> - reg_hdmi_en: fixedregulator at 0 {
> - compatible = "regulator-fixed";
> - regulator-name = "hdmi-en";
> + reg_hdmi_en: fixedregulator at 0 {
And here I'd use the same convention of suffixes, renaming the node to
voltage-regulator-1 for the sake of consistency.
Best regards,
Tomasz
> + compatible = "regulator-fixed";
> + regulator-name = "hdmi-en";
> + };
> };
>
> fixed-rate-clocks {
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 1/3] ARM: dts: Put Arndale fixed voltage regulators on a simple-bus
2013-07-05 23:36 ` [PATCH 1/3] ARM: dts: Put Arndale fixed voltage regulators on a simple-bus Tomasz Figa
@ 2013-07-06 9:19 ` Mark Brown
0 siblings, 0 replies; 10+ messages in thread
From: Mark Brown @ 2013-07-06 9:19 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Jul 06, 2013 at 01:36:57AM +0200, Tomasz Figa wrote:
> On Monday 01 of July 2013 22:36:37 Mark Brown wrote:
> > + regulators {
> > + compatible = "simple-bus";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> Are the two #properties above really necessary? The regulators that will
> be placed here probably don't need any kind of addressing, so it should be
> possible to omit them.
I believe they're required boilerplate for a correct DT bus.
> > +
> > + mmc_reg: voltage-regulator {
> I'd suggest suffixing name of this node with an index, like voltage-
> regulator-0 to be more future proof, in case of further fixed regulators
> being added.
If you want to rename things that's a separate thing so should be a
separate patch - this patch is just about moving the existing devices
onto a bus.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130706/4f173dbe/attachment.sig>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-07-24 1:50 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-01 21:36 [PATCH 1/3] ARM: dts: Put Arndale fixed voltage regulators on a simple-bus Mark Brown
2013-07-01 21:36 ` [PATCH 2/3] ARM: dts: Hook up supplies for Arndale S5M8767 Mark Brown
2013-07-01 21:36 ` [PATCH 3/3] ARM: dts: Add WM1811A audio CODEC to Arndale bindings Mark Brown
2013-07-01 21:47 ` Fabio Estevam
2013-07-01 22:38 ` Mark Brown
2013-07-02 5:21 ` Tushar Behera
2013-07-02 9:25 ` Mark Brown
2013-07-24 1:50 ` Kukjin Kim
2013-07-05 23:36 ` [PATCH 1/3] ARM: dts: Put Arndale fixed voltage regulators on a simple-bus Tomasz Figa
2013-07-06 9:19 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).