From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm: dts: AM43x: Add usb_otg_hs node
Date: Tue, 09 Jul 2013 19:01:23 +0400 [thread overview]
Message-ID: <51DC25C3.6000901@cogentembedded.com> (raw)
In-Reply-To: <51DC1937.9080302@cogentembedded.com>
Hello.
On 07/09/2013 06:07 PM, Sergei Shtylyov wrote:
>> Adds device node for HS USB Host module for AM437x
>> changes from v1
>> renamed synopsis to snps
>> removed flag tx-fifo-resize
>> Signed-off-by: George Cherian <george.cherian@ti.com>
>> ---
>> arch/arm/boot/dts/am4372.dtsi | 18 ++++++++++++++++++
>> 1 file changed, 18 insertions(+)
>> diff --git a/arch/arm/boot/dts/am4372.dtsi
>> b/arch/arm/boot/dts/am4372.dtsi
>> index ddc1df7..c9e0da8 100644
>> --- a/arch/arm/boot/dts/am4372.dtsi
>> +++ b/arch/arm/boot/dts/am4372.dtsi
>> @@ -64,5 +64,23 @@
>> compatible = "ti,am4372-counter32k","ti,omap-counter32k";
>> reg = <0x44e86000 0x40>;
>> };
>> +
>> + usb_otg_hs1: am4372_dwc3 at 48380000 {
>
> See http://www.devicetree.org/Device_Tree_Usage, "Node Names" section.
>
>> + compatible = "ti,am437x-dwc3";
>> + reg = <0x48380000 0x1ff>;
And I bet this should be 0x200, not 0x1ff. This is length, not upper
limit.
>> + interrupts = <GIC_SPI 172 IRQ_TYPE_LEVEL_HIGH>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + utmi-mode = <1>;
>> + ranges;
>> +
>> + dwc3 at 48390000 {
> The same comment.
>> + compatible = "snps,dwc3";
>> + reg = <0x48390000 0xcfff>;
The same, this should be 0xd000, not 0xcfff.
>> + interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>;
>> + };
>> +
>> + };
>> +
WBR, Sergei
prev parent reply other threads:[~2013-07-09 15:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 9:17 [PATCH v2] arm: dts: AM43x: Add usb_otg_hs node George Cherian
2013-07-09 10:20 ` Felipe Balbi
2013-07-09 11:21 ` George Cherian
2013-07-09 11:27 ` Felipe Balbi
2013-07-09 11:52 ` George Cherian
2013-07-09 12:03 ` Felipe Balbi
2013-07-09 10:32 ` Mohammed, Afzal
2013-07-09 14:07 ` Sergei Shtylyov
2013-07-09 15:01 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DC25C3.6000901@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).