From: khilman@linaro.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] mfd: omap-usb-host: Put pins in IDLE state on suspend
Date: Sun, 14 Jul 2013 14:22:11 +0100 [thread overview]
Message-ID: <51E2A603.1000805@linaro.org> (raw)
In-Reply-To: <1373473380-27515-1-git-send-email-rogerq@ti.com>
On 07/10/2013 05:23 PM, Roger Quadros wrote:
> In order to support wake up from suspend use the pinctrl
> framework to put the USB host pins in IDLE state during suspend.
>
> CC: Samuel Ortiz <sameo@linux.intel.com>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
[...]
> @@ -608,6 +618,14 @@ static int usbhs_omap_probe(struct platform_device *pdev)
> return -ENOMEM;
> }
>
> + if (!dev->pins || !dev->pins->idle_state) {
> + /* If IDLE pins are not available, we can't remote wakeup,
> + * so prevent idling in that case.
> + */
nit: multi-line comment style
Also, if there are no pins, aren't the pinctrl ops nops anyways? IOW,
not sure the need
for this is clear, and it's not mentioned in the changelog.
Kevin
next prev parent reply other threads:[~2013-07-14 13:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 16:17 [PATCH 0/6] USB: Implement runtime idling and remote wakeup for OMAP EHCI controller Roger Quadros
2013-07-10 16:17 ` [PATCH 1/6] ARM: OMAP3: Enable Hardware Save and Restore for USB Host Roger Quadros
2013-07-10 16:22 ` [PATCH 2/6] ARM: dts: omap3beagle-xm: Add idle state pins for USB host Roger Quadros
2013-07-10 16:22 ` [PATCH 3/6] mfd: omap-usb-host: move initialization to module_init() Roger Quadros
2013-07-10 16:23 ` [PATCH 4/6] mfd: omap-usb-host: Put pins in IDLE state on suspend Roger Quadros
2013-07-14 13:22 ` Kevin Hilman [this message]
2013-07-15 8:23 ` Roger Quadros
2013-07-10 16:23 ` [PATCH 5/6] USB: Support wakeup IRQ for suspended controllers Roger Quadros
2013-07-10 18:45 ` Alan Stern
2013-07-11 7:30 ` Roger Quadros
2013-07-10 19:08 ` Alan Stern
2013-07-11 7:30 ` Roger Quadros
2013-07-10 16:23 ` [PATCH 6/6] USB: ehci-omap: Implement suspend/resume Roger Quadros
2013-07-10 19:04 ` Alan Stern
2013-07-11 8:50 ` Roger Quadros
2013-07-11 15:14 ` Alan Stern
2013-07-22 13:16 ` Roger Quadros
2013-07-22 15:18 ` Alan Stern
2013-07-23 9:18 ` Roger Quadros
2013-07-23 14:14 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E2A603.1000805@linaro.org \
--to=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).