From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/2] ARM: dts: twl: Add GPADC data to device tree
Date: Wed, 17 Jul 2013 16:48:34 +0200 [thread overview]
Message-ID: <51E6AEC2.3050308@metafoo.de> (raw)
In-Reply-To: <51E6AB54.103@cogentembedded.com>
On 07/17/2013 04:33 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 17-07-2013 15:12, Oleksandr Kozaruk wrote:
>
>> GPADC is the general purpose ADC present on twl6030.
>> The dt data is interrupt used to trigger end of ADC
>> conversion.
>
>> Signed-off-by: Oleksandr Kozaruk <oleksandr.kozaruk@ti.com>
>> ---
>> arch/arm/boot/dts/twl6030.dtsi | 6 ++++++
>> 1 file changed, 6 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/twl6030.dtsi b/arch/arm/boot/dts/twl6030.dtsi
>> index 2e3bd31..322aa8e 100644
>> --- a/arch/arm/boot/dts/twl6030.dtsi
>> +++ b/arch/arm/boot/dts/twl6030.dtsi
>> @@ -103,4 +103,10 @@
>> compatible = "ti,twl6030-pwmled";
>> #pwm-cells = <2>;
>> };
>> +
>> + adc: twl6030_gpadc {
>
> I was talking about the device name, not label. The "twl6030_gpadc" part.
The compatible property should also be: 'twl6030-gpadc' instead of
'twl6030_gpadc' and you need to add documentation for it.
- Lars
next prev parent reply other threads:[~2013-07-17 14:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 11:12 [PATCH v5 0/2] TWL6030, TWL6032 GPADC driver Oleksandr Kozaruk
2013-07-17 11:12 ` [PATCH v5 1/2] ARM: dts: twl: Add GPADC data to device tree Oleksandr Kozaruk
2013-07-17 14:33 ` Sergei Shtylyov
2013-07-17 14:48 ` Lars-Peter Clausen [this message]
2013-07-17 11:12 ` [PATCH v5 2/2] iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver Oleksandr Kozaruk
2013-07-17 18:04 ` Lars-Peter Clausen
2013-07-18 8:36 ` Oleksandr Kozaruk
2013-07-18 9:48 ` Lars-Peter Clausen
2013-07-19 8:35 ` Oleksandr Kozaruk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E6AEC2.3050308@metafoo.de \
--to=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).