linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: rnayak@ti.com (Rajendra Nayak)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] ARM: OMAP2+: Avoid idling memory controllers with no drivers
Date: Tue, 23 Jul 2013 10:29:22 +0530	[thread overview]
Message-ID: <51EE0DAA.9000203@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1307221746430.10891@utopia.booyaka.com>

On Monday 22 July 2013 11:18 PM, Paul Walmsley wrote:
> Hi
> 
> On Mon, 22 Jul 2013, Rajendra Nayak wrote:
> 
>> Memory controllers in OMAP (like GPMC and EMIF) have the hwmods marked with
>> HWMOD_INIT_NO_IDLE and are left in enabled state post initial setup.
>>
>> Even if they have drivers missing, avoid idling them as part of
>> omap_device_late_idle()
> 
> Since this patch is intended for the -rc series, it's best if you explain 
> here what effects this patch will fix.  i.e., does this fix a crash, a 
> warning, etc?  Also maybe update your series description message?

This patch infact is needed because of 'PATCH 4/4' in the series which makes
sure the omap_device and pm_runtime state are in sync with the hwmod state.

Without that we always had gpmc and emif having the hwmod state as enabled but
omap_device state as disabled and we never hit the issue of omap_device_late_idle()
trying to disable gpmc and emif.

So in short, this does not fix anything in the existing code, but something that
was uncovered by syncing the states across hwmod and omap_device.

regards,
Rajendra

> 
> 
> - Paul
> 

  reply	other threads:[~2013-07-23  4:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-22 10:01 [PATCH 0/4] OMAP2+: Fix boot hang with earlycon enabled Rajendra Nayak
2013-07-22 10:01 ` [PATCH 1/4] ARM: OMAP2+: hwmod: Fix a crash in _setup_reset() with DEBUG_LL Rajendra Nayak
2013-07-22 10:01 ` [PATCH 2/4] serial: omap: enable PM runtime only when its fully configured Rajendra Nayak
2013-07-29  8:44   ` Paul Walmsley
2013-07-29  8:50     ` Rajendra Nayak
2013-07-30  5:16       ` Rajendra Nayak
2013-07-30 10:20         ` Paul Walmsley
2013-07-22 10:01 ` [PATCH 3/4] ARM: OMAP2+: Avoid idling memory controllers with no drivers Rajendra Nayak
2013-07-22 17:48   ` Paul Walmsley
2013-07-23  4:59     ` Rajendra Nayak [this message]
2013-07-22 10:01 ` [PATCH 4/4] ARM: OMAP2+: Sync hwmod state with the pm_runtime and omap_device state Rajendra Nayak
2013-08-05 15:43   ` Kevin Hilman
2013-07-22 14:52 ` [PATCH 0/4] OMAP2+: Fix boot hang with earlycon enabled Mark Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51EE0DAA.9000203@ti.com \
    --to=rnayak@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).