linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: rogerq@ti.com (Roger Quadros)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Do not run dummy_flush_tlb_a15_erratum() on non-Cortex-A15
Date: Tue, 23 Jul 2013 14:13:54 +0300	[thread overview]
Message-ID: <51EE6572.50909@ti.com> (raw)
In-Reply-To: <CAOMZO5Brgj2CzJXqjUfihi-aNxumvamDUGdvZuU94rHMwutCog@mail.gmail.com>

On 07/23/2013 02:02 PM, Fabio Estevam wrote:
> Hi Roger,
> 
> On Tue, Jul 23, 2013 at 5:13 AM, Roger Quadros <rogerq@ti.com> wrote:
> 
>>> -     if (!erratum_a15_798181())
>>> -             return;
>>> -
>>
>> Removing this if statement will cause "ipi_flush_tlb_a15_erratum" to be called
>> on non A15 platforms. So I would just keep it to be safe.
> 
> I just moved the if statement into the the beginning of
> dummy_flush_tlb_a15_erratum(), so ipi_flush_tlb_a15_erratum will not
> be called on non-A15 systems.

It will be called. Please see the code below after your patch is applied.

 static void broadcast_tlb_a15_erratum(void)
 {
 	dummy_flush_tlb_a15_erratum();
 	smp_call_function(ipi_flush_tlb_a15_erratum, NULL, 1);
 }

cheers,
-roger

  reply	other threads:[~2013-07-23 11:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-23  5:19 [PATCH] ARM: Do not run dummy_flush_tlb_a15_erratum() on non-Cortex-A15 Fabio Estevam
2013-07-23  7:04 ` Paul Walmsley
2013-07-23  8:13 ` Roger Quadros
2013-07-23 11:02   ` Fabio Estevam
2013-07-23 11:13     ` Roger Quadros [this message]
2013-07-23 11:07   ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51EE6572.50909@ti.com \
    --to=rogerq@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).