linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: EXYNOS: cpuidle: Skip C1 cpuidle state for exynos5440
Date: Sun, 28 Jul 2013 09:10:09 +0200	[thread overview]
Message-ID: <51F4C3D1.2060901@linaro.org> (raw)
In-Reply-To: <0eaf01ce8863$89d3c4e0$9d7b4ea0$@org>

On 07/24/2013 01:47 PM, Kukjin Kim wrote:
> Amit Daniel Kachhap wrote:
>>
>> This patch skips the deep C1(AFTR -Arm off top running) state for
>> exynos5440
>> soc as this soc does not support this state. All the cpu's only allows the
>> basic
>> C0 state.
>>
>> Signed-off-by: Amit Daniel Kachhap <amit.daniel@samsung.com>
>> ---
>>  arch/arm/mach-exynos/cpuidle.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-
>> exynos/cpuidle.c
>> index 17a18ff..9a776a1 100644
>> --- a/arch/arm/mach-exynos/cpuidle.c
>> +++ b/arch/arm/mach-exynos/cpuidle.c
>> @@ -210,7 +210,7 @@ static int __init exynos4_init_cpuidle(void)
>>  		device->cpu = cpu_id;
>>
>>  		/* Support IDLE only */
>> -		if (cpu_id != 0)
>> +		if (soc_is_exynos5440() || cpu_id != 0)
>>  			device->state_count = 1;
>>
>>  		ret = cpuidle_register_device(device);
>> --
>> 1.7.1
> 
> Applied, thanks.

You shouldn't have. This patch means exynos5540 has no cpuidle driver at
all. It should be fixed in the Kconfig to unselect CONFIG_CPU_IDLE for
an exynos5540.


-- 
 <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

  reply	other threads:[~2013-07-28  7:10 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-12 11:28 [PATCH V2 0/2] ARM: EXYNOS: cpuidle: fixes in exynos cpuidle/PM Amit Daniel Kachhap
2013-06-12 11:28 ` [PATCH V2 1/2] ARM: SAMSUNG: Add SAMSUNG_PM config option to select pm Amit Daniel Kachhap
2013-06-13 12:42   ` Kukjin Kim
2013-06-14  4:25     ` amit daniel kachhap
2013-07-24  4:54   ` Kukjin Kim
2013-07-24  5:58     ` amit daniel kachhap
2013-06-12 11:28 ` [PATCH V2 2/2] ARM: EXYNOS: cpuidle: Allow C1 state only in supported SOC's Amit Daniel Kachhap
2013-07-24  5:15   ` Kukjin Kim
2013-07-24  5:59     ` amit daniel kachhap
2013-07-24  7:36       ` Kukjin Kim
2013-07-24  9:53         ` [PATCH] ARM: EXYNOS: cpuidle: Skip C1 cpuidle state for exynos5440 Amit Daniel Kachhap
2013-07-24 11:47           ` Kukjin Kim
2013-07-28  7:10             ` Daniel Lezcano [this message]
2013-07-28  9:22               ` Tomasz Figa
2013-07-28 10:31                 ` Daniel Lezcano
2013-07-28 10:46                   ` Tomasz Figa
2013-07-29  4:46                   ` amit daniel kachhap
2013-07-29  5:34                     ` Kukjin Kim
2013-07-29  8:33                     ` Tomasz Figa
2013-07-29  9:33                       ` amit daniel kachhap
2013-07-29 10:06                         ` Daniel Lezcano
2013-07-25 11:19           ` Bartlomiej Zolnierkiewicz
2013-07-24  9:55         ` [PATCH V2 2/2] ARM: EXYNOS: cpuidle: Allow C1 state only in supported SOC's amit daniel kachhap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F4C3D1.2060901@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).