linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/9] ARM: dts: omap5-uevm: fixup wrong regulator configuration
Date: Mon, 29 Jul 2013 09:34:37 -0500	[thread overview]
Message-ID: <51F67D7D.9070003@ti.com> (raw)
In-Reply-To: <CADz42=M8LQ=i2q30=JJU+F-Qx89D1PwU7pW3DH7F1iYiC8-pFA@mail.gmail.com>

On 07/29/2013 09:19 AM, Benoit Cousson wrote:
> 2013/7/29 Nishanth Menon <nm at ti.com <mailto:nm@ti.com>>
>
> Well you're lucky I'm now in an area with Wifi and 3G access... last
> week it whould have been impossible to receive it :-)
hehe :)

>
>> All the "fixes" are sharing more than 50% of the changelog
>> content with
>> only 2 changes in the code, so you'd better squash them into one
>> patch
>> to avoid repeating the same thing again and again.
>
>> Reason for keeping them separate was to allow any future git bisect
>> to narrow down to precise patch.
>>     <--->
> Mmm, why? Do you expect some settings to not work or generate crash?

It has worked with a backport to full fledged OS on top and I do not 
expect it to fail, however, I am never sure about how the future issues 
look like :)

>       ARM: dts: omap5-uevm: update SMPS9 settings
>        ARM: dts: omap5-uevm: update and disable unused regulators LDO[28]
>        ARM: dts: omap5-uevm: update LDO1 voltage to 1.5V and settings
>        ARM: dts: omap5-uevm: update LDO3 voltage to 1.5V and settings
>        ARM: dts: omap5-uevm: update LDO4 voltage to 1.5V and settings
>        ARM: dts: omap5-uevm: update LDO6 voltage to 1.2V
>        ARM: dts: omap5-uevm: update LDO7 voltage to 2V and settings
>        ARM: dts: omap5-uevm: update SDCARD LDO9 and resource REGEN3
>     <---->
>
>     Would you have suggestions on what to squash up?
>
>
>
> I guess one patch for all the mandatory fixes, and another one with the
> improvements should be good enough.
>
> Does that sounds OK to you?

patch #1 ARM: dts: omap5-uevm: document regulator signals used on the 
actual board
   -> as is, since it is a documentation patch
Patch #2: ARM: dts: omap5-uevm: fix regulator configurations mandatory 
for SoC
squash of:
-> ARM: dts: omap5-uevm: update LDO1 voltage to 1.5V and settings
-> ARM: dts: omap5-uevm: update LDO3 voltage to 1.5V and settings
-> ARM: dts: omap5-uevm: update LDO4 voltage to 1.5V and settings
-> ARM: dts: omap5-uevm: update LDO6 voltage to 1.2V
-> ARM: dts: omap5-uevm: update LDO7 voltage to 2V and settings
-> ARM: dts: omap5-uevm: update SDCARD LDO9 and resource REGEN3

Patch #3: ARM: dts: omap5-uevm: update optional regulator configurations
squash of:
  -> ARM: dts: omap5-uevm: update SMPS9 settings
  -> ARM: dts: omap5-uevm: update and disable unused regulators LDO[28]

Does that sound fine?
-- 
Regards,
Nishanth Menon

  parent reply	other threads:[~2013-07-29 14:34 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-17 16:45 [PATCH 0/9] ARM: dts: omap5-uevm: fixup wrong regulator configuration Nishanth Menon
2013-07-17 16:45 ` [PATCH 1/9] ARM: dts: omap5-uevm: document regulator signals used on the actual board Nishanth Menon
2013-07-17 16:45 ` [PATCH 2/9] ARM: dts: omap5-uevm: update SMPS9 settings Nishanth Menon
2013-07-17 16:45 ` [PATCH 3/9] ARM: dts: omap5-uevm: update and disable unused regulators LDO[28] Nishanth Menon
2013-07-17 16:45 ` [PATCH 4/9] ARM: dts: omap5-uevm: update LDO1 voltage to 1.5V and settings Nishanth Menon
2013-07-17 16:45 ` [PATCH 5/9] ARM: dts: omap5-uevm: update LDO3 " Nishanth Menon
2013-07-17 16:45 ` [PATCH 6/9] ARM: dts: omap5-uevm: update LDO4 " Nishanth Menon
2013-07-17 16:45 ` [PATCH 7/9] ARM: dts: omap5-uevm: update LDO6 voltage to 1.2V Nishanth Menon
2013-07-17 16:45 ` [PATCH 8/9] ARM: dts: omap5-uevm: update LDO7 voltage to 2V and settings Nishanth Menon
2013-07-17 16:45 ` [PATCH 9/9] ARM: dts: omap5-uevm: update SDCARD LDO9 and resource REGEN3 Nishanth Menon
2013-07-29  9:57 ` [PATCH 0/9] ARM: dts: omap5-uevm: fixup wrong regulator configuration Keerthy
2013-07-29 13:17   ` Nishanth Menon
2013-07-29 13:39     ` Benoit Cousson
2013-07-29 14:13       ` Nishanth Menon
     [not found]         ` <CADz42=M8LQ=i2q30=JJU+F-Qx89D1PwU7pW3DH7F1iYiC8-pFA@mail.gmail.com>
2013-07-29 14:34           ` Nishanth Menon [this message]
2013-07-29 17:03             ` [PATCH V2 0/3] " Nishanth Menon
2013-07-29 17:03               ` [PATCH V2 1/3] ARM: dts: omap5-uevm: document regulator signals used on the actual board Nishanth Menon
2013-07-29 17:03               ` [PATCH V2 2/3] ARM: dts: omap5-uevm: fix regulator configurations mandatory for SoC Nishanth Menon
2013-07-29 17:03               ` [PATCH V2 3/3] ARM: dts: omap5-uevm: update optional/unused regulator configurations Nishanth Menon
2013-07-29 22:18               ` [PATCH V2 0/3] ARM: dts: omap5-uevm: fixup wrong regulator configuration Benoit Cousson
2013-07-30  6:52                 ` Tony Lindgren
2013-07-30 12:18                   ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F67D7D.9070003@ti.com \
    --to=nm@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).