From: holler@ahsoftware.de (Alexander Holler)
To: linux-arm-kernel@lists.infradead.org
Subject: OMAP5912 boot broken by "gpio/omap: don't create an IRQ mapping for every GPIO on DT"
Date: Mon, 29 Jul 2013 17:18:11 +0200 [thread overview]
Message-ID: <51F687B3.7030902@ahsoftware.de> (raw)
In-Reply-To: <51F684F2.5050308@ti.com>
Am 29.07.2013 17:06, schrieb Santosh Shilimkar:
> On Monday 29 July 2013 10:52 AM, Alexander Holler wrote:
>> Am 29.07.2013 14:57, schrieb Santosh Shilimkar:
>>
>>> With some helps from MMC and other guys, we validated the Linus's tip which includes
>>> your patches. It actually doesn't break anything and as OMAP hsmmc maintainer
>>> clarified, the cd-gpios isn't supported yet for DT. While supporting that it
>>> can use appropriate binding whichever works.
>>>
>>> But with OMAP1 breakage reported by Paul, I think we are not left with choice
>>> but to revert those commits. We *must* respect rc rules for the fixes.
>>> *No regression*
>>>
>>> Thanks for your hardwork to cook up those patches but now Linus's W proposal
>>> is going to be generic, hopefully the issue can be address better. Till
>>> then we can't get the ethernet support.
>>
>> The problem never was just the omap_hsmmc driver. I rather would say all drivers which do use GPIOs as IRQs were affected.
>>
>> I've only used the omap_hsmmc driver as example, because that was the driver I've tried to actually use with sd-cards, which is rather impossible without having a working CD-signal. And all code was already there and seems to work (at least during my few tests), so I've just added an entry to the dts to be able to use a mmc-slot as one would expect a mmc-slot does work.
>>
>> If someone wants to test a new feature at the same front, I would suggest to try it out using gpio-keys. That driver should work on almost any architecture/platform/hardware which supports gpios and is small enough to be a good test candidate. Having had a short look at gpio-keys.c, I think the same problems as with omap_hsmmc would have been occured when someone had tried to use that driver with 3.11-rc2.
>>
> The 3 OMAP platforms which supports DT are AM33XX, OMAP4 and OMAP5.
> OMAP3 based boards are getting converted but they are bit far from being
> DT only. So my statement was again from what we support on mainline today
> and those platform don't use gpio-keys. But for testing perspective,
> I guess its good idea.
>
I wonder how you do know that no board with OMAP chips does use gpio-keys?
Does TI restrict their users/customers to only certified drivers? ;)
> As mentioned above, we are going ahead with revert and possible better
> alternative to the root of the problem.
>
> Regards,
> Santosh
> P.S: Please sensibly wrap your email replies to 80 chars so that
> people can read it without scrolling to the end of the line.
Line-wrapping mail readers do exist since some decades and I believe
people should be able to read e-mails with whatever line width they
prefer (and NOT what I prefer). So I never will hard-limit mails to some
specific line width on my side (besides from patch). That's just a very
bad behaviour.
Regards,
Alexander Holler
next prev parent reply other threads:[~2013-07-29 15:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 7:52 OMAP5912 boot broken by "gpio/omap: don't create an IRQ mapping for every GPIO on DT" Paul Walmsley
2013-07-29 9:01 ` Linus Walleij
2013-07-29 9:19 ` Paul Walmsley
2013-07-29 9:19 ` Javier Martinez Canillas
2013-07-29 9:39 ` Javier Martinez Canillas
2013-07-29 12:57 ` Santosh Shilimkar
2013-07-29 14:52 ` Alexander Holler
2013-07-29 15:06 ` Santosh Shilimkar
2013-07-29 15:18 ` Alexander Holler [this message]
2013-07-29 15:23 ` Santosh Shilimkar
2013-07-29 9:47 ` Paul Walmsley
2013-07-29 10:19 ` Javier Martinez Canillas
2013-07-29 11:43 ` Linus Walleij
2013-07-29 12:40 ` Javier Martinez Canillas
2013-07-29 15:26 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F687B3.7030902@ahsoftware.de \
--to=holler@ahsoftware.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox