From mboxrd@z Thu Jan 1 00:00:00 1970 From: b.brezillon@overkiz.com (boris brezillon) Date: Mon, 29 Jul 2013 17:52:16 +0200 Subject: [PATCH] pinctrl: at91: choose appropriate handler for level interrupts In-Reply-To: References: <1374331893-16009-1-git-send-email-b.brezillon@overkiz.com> Message-ID: <51F68FB0.4090507@overkiz.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 29/07/2013 17:42, Linus Walleij wrote: > On Sat, Jul 20, 2013 at 4:51 PM, Boris BREZILLON > wrote: > >> The current implementation handle both edge and level interrupts with the >> 'handle_simple_irq' handler. >> >> Level interrupts are active as long as the pin stays at the configured >> level (low or high). In this case we have to use 'handle_level_irq' which >> mask the interrupt until the handle has treated it. >> >> Signed-off-by: Boris BREZILLON > Nicolas/Jean-Christophe: any opinion on this patch? > > I am tempted to just apply it and see if you react to it :-) Hello, Just for clarification, without this patch the kernel hangs if you request a threaded irq on level state (low or high). This was tested on sama5ek board. Best Regards, Boris > > Yours, > Linus Walleij