* [PATCH 1/9] ARM: dts: omap5-uevm: document regulator signals used on the actual board
2013-07-17 16:45 [PATCH 0/9] ARM: dts: omap5-uevm: fixup wrong regulator configuration Nishanth Menon
@ 2013-07-17 16:45 ` Nishanth Menon
2013-07-17 16:45 ` [PATCH 2/9] ARM: dts: omap5-uevm: update SMPS9 settings Nishanth Menon
` (8 subsequent siblings)
9 siblings, 0 replies; 22+ messages in thread
From: Nishanth Menon @ 2013-07-17 16:45 UTC (permalink / raw)
To: linux-arm-kernel
commit e00c27ef3b4c23e39d0a77b7c8e5be44c28001c7
(ARM: dts: OMAP5: Add Palmas MFD node and regulator nodes)
introduced regulator entries for OMAP5uEVM.
However, currently we use the Palmas regulator names which is used for
different purposes on uEVM. Document the same based on 750-2628-XXX
boards - which is meant to be supported by this dts.
Reported-by: Marc J?ttner <m-juettner@ti.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
---
arch/arm/boot/dts/omap5-uevm.dts | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
index 08b7267..b430b8f 100644
--- a/arch/arm/boot/dts/omap5-uevm.dts
+++ b/arch/arm/boot/dts/omap5-uevm.dts
@@ -282,6 +282,7 @@
regulators {
smps123_reg: smps123 {
+ /* VDD_OPP_MPU */
regulator-name = "smps123";
regulator-min-microvolt = < 600000>;
regulator-max-microvolt = <1500000>;
@@ -290,6 +291,7 @@
};
smps45_reg: smps45 {
+ /* VDD_OPP_MM */
regulator-name = "smps45";
regulator-min-microvolt = < 600000>;
regulator-max-microvolt = <1310000>;
@@ -298,6 +300,7 @@
};
smps6_reg: smps6 {
+ /* VDD_DDR3 - over VDD_SMPS6 */
regulator-name = "smps6";
regulator-min-microvolt = <1200000>;
regulator-max-microvolt = <1200000>;
@@ -306,6 +309,7 @@
};
smps7_reg: smps7 {
+ /* VDDS_1v8_OMAP over VDDS_1v8_MAIN */
regulator-name = "smps7";
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
@@ -314,6 +318,7 @@
};
smps8_reg: smps8 {
+ /* VDD_OPP_CORE */
regulator-name = "smps8";
regulator-min-microvolt = < 600000>;
regulator-max-microvolt = <1310000>;
@@ -322,6 +327,7 @@
};
smps9_reg: smps9 {
+ /* VDDA_2v1_AUD over VDD_2v1 */
regulator-name = "smps9";
regulator-min-microvolt = <2100000>;
regulator-max-microvolt = <2100000>;
@@ -331,6 +337,7 @@
};
smps10_reg: smps10 {
+ /* VBUS_5V_OTG */
regulator-name = "smps10";
regulator-min-microvolt = <5000000>;
regulator-max-microvolt = <5000000>;
@@ -339,6 +346,7 @@
};
ldo1_reg: ldo1 {
+ /* VDDAPHY_CAM: vdda_csiport */
regulator-name = "ldo1";
regulator-min-microvolt = <2800000>;
regulator-max-microvolt = <2800000>;
@@ -347,6 +355,7 @@
};
ldo2_reg: ldo2 {
+ /* VCC_2V8_DISP: Does not go anywhere */
regulator-name = "ldo2";
regulator-min-microvolt = <2900000>;
regulator-max-microvolt = <2900000>;
@@ -355,6 +364,7 @@
};
ldo3_reg: ldo3 {
+ /* VDDAPHY_MDM: vdda_lli */
regulator-name = "ldo3";
regulator-min-microvolt = <3000000>;
regulator-max-microvolt = <3000000>;
@@ -363,6 +373,7 @@
};
ldo4_reg: ldo4 {
+ /* VDDAPHY_DISP: vdda_dsiport/hdmi */
regulator-name = "ldo4";
regulator-min-microvolt = <2200000>;
regulator-max-microvolt = <2200000>;
@@ -371,6 +382,7 @@
};
ldo5_reg: ldo5 {
+ /* VDDA_1V8_PHY: usb/sata/hdmi.. */
regulator-name = "ldo5";
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
@@ -379,6 +391,7 @@
};
ldo6_reg: ldo6 {
+ /* VDDS_1V2_WKUP: hsic/ldo_emu_wkup */
regulator-name = "ldo6";
regulator-min-microvolt = <1500000>;
regulator-max-microvolt = <1500000>;
@@ -387,6 +400,7 @@
};
ldo7_reg: ldo7 {
+ /* VDD_VPP: vpp1 */
regulator-name = "ldo7";
regulator-min-microvolt = <1500000>;
regulator-max-microvolt = <1500000>;
@@ -395,6 +409,7 @@
};
ldo8_reg: ldo8 {
+ /* VDD_3v0: Does not go anywhere */
regulator-name = "ldo8";
regulator-min-microvolt = <1500000>;
regulator-max-microvolt = <1500000>;
@@ -403,6 +418,7 @@
};
ldo9_reg: ldo9 {
+ /* VCC_DV_SDIO: vdds_sdcard */
regulator-name = "ldo9";
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <3300000>;
@@ -411,6 +427,7 @@
};
ldoln_reg: ldoln {
+ /* VDDA_1v8_REF: vdds_osc/mm_l4per.. */
regulator-name = "ldoln";
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
@@ -419,6 +436,7 @@
};
ldousb_reg: ldousb {
+ /* VDDA_3V_USB: VDDA_USBHS33 */
regulator-name = "ldousb";
regulator-min-microvolt = <3250000>;
regulator-max-microvolt = <3250000>;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH 2/9] ARM: dts: omap5-uevm: update SMPS9 settings
2013-07-17 16:45 [PATCH 0/9] ARM: dts: omap5-uevm: fixup wrong regulator configuration Nishanth Menon
2013-07-17 16:45 ` [PATCH 1/9] ARM: dts: omap5-uevm: document regulator signals used on the actual board Nishanth Menon
@ 2013-07-17 16:45 ` Nishanth Menon
2013-07-17 16:45 ` [PATCH 3/9] ARM: dts: omap5-uevm: update and disable unused regulators LDO[28] Nishanth Menon
` (7 subsequent siblings)
9 siblings, 0 replies; 22+ messages in thread
From: Nishanth Menon @ 2013-07-17 16:45 UTC (permalink / raw)
To: linux-arm-kernel
commit e00c27ef3b4c23e39d0a77b7c8e5be44c28001c7
(ARM: dts: OMAP5: Add Palmas MFD node and regulator nodes)
introduced regulator entries for OMAP5uEVM.
However, The regulator information is based on an older temporary
pre-production board variant and does not reflect production board
750-2628-XXX boards.
SMPS9 supplies TWL6040 over VDDA_2v1_AUD. This regulator needs to be
enabled only when audio is active. Since it does not come active by
default, it does not require "always-on" or "boot-on".
Reported-by: Marc J?ttner <m-juettner@ti.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
---
arch/arm/boot/dts/omap5-uevm.dts | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
index b430b8f..6709f1e 100644
--- a/arch/arm/boot/dts/omap5-uevm.dts
+++ b/arch/arm/boot/dts/omap5-uevm.dts
@@ -331,8 +331,6 @@
regulator-name = "smps9";
regulator-min-microvolt = <2100000>;
regulator-max-microvolt = <2100000>;
- regulator-always-on;
- regulator-boot-on;
ti,smps-range = <0x80>;
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH 3/9] ARM: dts: omap5-uevm: update and disable unused regulators LDO[28]
2013-07-17 16:45 [PATCH 0/9] ARM: dts: omap5-uevm: fixup wrong regulator configuration Nishanth Menon
2013-07-17 16:45 ` [PATCH 1/9] ARM: dts: omap5-uevm: document regulator signals used on the actual board Nishanth Menon
2013-07-17 16:45 ` [PATCH 2/9] ARM: dts: omap5-uevm: update SMPS9 settings Nishanth Menon
@ 2013-07-17 16:45 ` Nishanth Menon
2013-07-17 16:45 ` [PATCH 4/9] ARM: dts: omap5-uevm: update LDO1 voltage to 1.5V and settings Nishanth Menon
` (6 subsequent siblings)
9 siblings, 0 replies; 22+ messages in thread
From: Nishanth Menon @ 2013-07-17 16:45 UTC (permalink / raw)
To: linux-arm-kernel
commit e00c27ef3b4c23e39d0a77b7c8e5be44c28001c7
(ARM: dts: OMAP5: Add Palmas MFD node and regulator nodes)
introduced regulator entries for OMAP5uEVM.
However, The regulator information is based on an older temporary
pre-production board variant and does not reflect production board
750-2628-XXX boards - On production boards, LDO2 and 8 are unused.
LDO2 and LDO8 do not go to any peripheral or connector on the board.
Further, these unused regulators should have been 2.8V for LDO2 and
3.0V for LDO8. Mark these LDOs as disabled in the dts until needed.
Reported-by: Marc J?ttner <m-juettner@ti.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
---
arch/arm/boot/dts/omap5-uevm.dts | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
index 6709f1e..87b3e9e 100644
--- a/arch/arm/boot/dts/omap5-uevm.dts
+++ b/arch/arm/boot/dts/omap5-uevm.dts
@@ -355,10 +355,10 @@
ldo2_reg: ldo2 {
/* VCC_2V8_DISP: Does not go anywhere */
regulator-name = "ldo2";
- regulator-min-microvolt = <2900000>;
- regulator-max-microvolt = <2900000>;
- regulator-always-on;
- regulator-boot-on;
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
+ /* Unused */
+ status = "disabled";
};
ldo3_reg: ldo3 {
@@ -409,10 +409,11 @@
ldo8_reg: ldo8 {
/* VDD_3v0: Does not go anywhere */
regulator-name = "ldo8";
- regulator-min-microvolt = <1500000>;
- regulator-max-microvolt = <1500000>;
- regulator-always-on;
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <3000000>;
regulator-boot-on;
+ /* Unused */
+ status = "disabled";
};
ldo9_reg: ldo9 {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH 4/9] ARM: dts: omap5-uevm: update LDO1 voltage to 1.5V and settings
2013-07-17 16:45 [PATCH 0/9] ARM: dts: omap5-uevm: fixup wrong regulator configuration Nishanth Menon
` (2 preceding siblings ...)
2013-07-17 16:45 ` [PATCH 3/9] ARM: dts: omap5-uevm: update and disable unused regulators LDO[28] Nishanth Menon
@ 2013-07-17 16:45 ` Nishanth Menon
2013-07-17 16:45 ` [PATCH 5/9] ARM: dts: omap5-uevm: update LDO3 " Nishanth Menon
` (5 subsequent siblings)
9 siblings, 0 replies; 22+ messages in thread
From: Nishanth Menon @ 2013-07-17 16:45 UTC (permalink / raw)
To: linux-arm-kernel
commit e00c27ef3b4c23e39d0a77b7c8e5be44c28001c7
(ARM: dts: OMAP5: Add Palmas MFD node and regulator nodes)
introduced regulator entries for OMAP5uEVM.
However, The regulator information is based on an older temporary
pre-production board variant and does not reflect production board
750-2628-XXX boards.
LDO1 supplies VDDAPHY_CAM which is OMAP5's vdda_csiporta/b/c. This
can only be supplied at 1.5V or 1.8V and we currently supply 2.8V.
To prevent any potential device damage risk, use the specified
1.5V-1.8V supply.
Remove 'always-on' and 'boot-on' settings here as it is
a 'on need' supply to SoC IP and is not enabled by PMIC by
default at boot.
Reported-by: Marc J?ttner <m-juettner@ti.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
---
arch/arm/boot/dts/omap5-uevm.dts | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
index 87b3e9e..a55f4d8 100644
--- a/arch/arm/boot/dts/omap5-uevm.dts
+++ b/arch/arm/boot/dts/omap5-uevm.dts
@@ -346,10 +346,8 @@
ldo1_reg: ldo1 {
/* VDDAPHY_CAM: vdda_csiport */
regulator-name = "ldo1";
- regulator-min-microvolt = <2800000>;
- regulator-max-microvolt = <2800000>;
- regulator-always-on;
- regulator-boot-on;
+ regulator-min-microvolt = <1500000>;
+ regulator-max-microvolt = <1800000>;
};
ldo2_reg: ldo2 {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH 5/9] ARM: dts: omap5-uevm: update LDO3 voltage to 1.5V and settings
2013-07-17 16:45 [PATCH 0/9] ARM: dts: omap5-uevm: fixup wrong regulator configuration Nishanth Menon
` (3 preceding siblings ...)
2013-07-17 16:45 ` [PATCH 4/9] ARM: dts: omap5-uevm: update LDO1 voltage to 1.5V and settings Nishanth Menon
@ 2013-07-17 16:45 ` Nishanth Menon
2013-07-17 16:45 ` [PATCH 6/9] ARM: dts: omap5-uevm: update LDO4 " Nishanth Menon
` (4 subsequent siblings)
9 siblings, 0 replies; 22+ messages in thread
From: Nishanth Menon @ 2013-07-17 16:45 UTC (permalink / raw)
To: linux-arm-kernel
commit e00c27ef3b4c23e39d0a77b7c8e5be44c28001c7
(ARM: dts: OMAP5: Add Palmas MFD node and regulator nodes)
introduced regulator entries for OMAP5uEVM.
However, The regulator information is based on an older temporary
pre-production board variant and does not reflect production board
750-2628-XXX boards.
LDO3 supplies Low Latency Interface(LLI) hardware module which is a
special hardware to communicate with Modem. However since uEVM is
not setup by default for this communication, this should be disabled
by default.
Further, vdda_lli is supposed to be 1.5V and not 3V.
Reported-by: Marc J?ttner <m-juettner@ti.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
---
arch/arm/boot/dts/omap5-uevm.dts | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
index a55f4d8..c6d560b 100644
--- a/arch/arm/boot/dts/omap5-uevm.dts
+++ b/arch/arm/boot/dts/omap5-uevm.dts
@@ -362,10 +362,11 @@
ldo3_reg: ldo3 {
/* VDDAPHY_MDM: vdda_lli */
regulator-name = "ldo3";
- regulator-min-microvolt = <3000000>;
- regulator-max-microvolt = <3000000>;
- regulator-always-on;
+ regulator-min-microvolt = <1500000>;
+ regulator-max-microvolt = <1500000>;
regulator-boot-on;
+ /* Only if Modem is used */
+ status = "disabled";
};
ldo4_reg: ldo4 {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH 6/9] ARM: dts: omap5-uevm: update LDO4 voltage to 1.5V and settings
2013-07-17 16:45 [PATCH 0/9] ARM: dts: omap5-uevm: fixup wrong regulator configuration Nishanth Menon
` (4 preceding siblings ...)
2013-07-17 16:45 ` [PATCH 5/9] ARM: dts: omap5-uevm: update LDO3 " Nishanth Menon
@ 2013-07-17 16:45 ` Nishanth Menon
2013-07-17 16:45 ` [PATCH 7/9] ARM: dts: omap5-uevm: update LDO6 voltage to 1.2V Nishanth Menon
` (3 subsequent siblings)
9 siblings, 0 replies; 22+ messages in thread
From: Nishanth Menon @ 2013-07-17 16:45 UTC (permalink / raw)
To: linux-arm-kernel
commit e00c27ef3b4c23e39d0a77b7c8e5be44c28001c7
(ARM: dts: OMAP5: Add Palmas MFD node and regulator nodes)
introduced regulator entries for OMAP5uEVM.
However, The regulator information is based on an older temporary
pre-production board variant and does not reflect production board
750-2628-XXX boards.
LDO4 supplies VDDAPHY_DISP which is vdda_dsiporta/c/vdda_hdmi
This can only be supplied at 1.5V or 1.8V and we currently
supply 2.2V.
To prevent any potential device damage risk, use the specified
1.5V-1.8V supply.
Remove 'always-on' and 'boot-on' settings here as it is a 'on need'
supply to SoC IP and is not enabled by PMIC by default at boot.
Reported-by: Marc J?ttner <m-juettner@ti.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
---
arch/arm/boot/dts/omap5-uevm.dts | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
index c6d560b..1550d6a 100644
--- a/arch/arm/boot/dts/omap5-uevm.dts
+++ b/arch/arm/boot/dts/omap5-uevm.dts
@@ -372,10 +372,8 @@
ldo4_reg: ldo4 {
/* VDDAPHY_DISP: vdda_dsiport/hdmi */
regulator-name = "ldo4";
- regulator-min-microvolt = <2200000>;
- regulator-max-microvolt = <2200000>;
- regulator-always-on;
- regulator-boot-on;
+ regulator-min-microvolt = <1500000>;
+ regulator-max-microvolt = <1800000>;
};
ldo5_reg: ldo5 {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH 7/9] ARM: dts: omap5-uevm: update LDO6 voltage to 1.2V
2013-07-17 16:45 [PATCH 0/9] ARM: dts: omap5-uevm: fixup wrong regulator configuration Nishanth Menon
` (5 preceding siblings ...)
2013-07-17 16:45 ` [PATCH 6/9] ARM: dts: omap5-uevm: update LDO4 " Nishanth Menon
@ 2013-07-17 16:45 ` Nishanth Menon
2013-07-17 16:45 ` [PATCH 8/9] ARM: dts: omap5-uevm: update LDO7 voltage to 2V and settings Nishanth Menon
` (2 subsequent siblings)
9 siblings, 0 replies; 22+ messages in thread
From: Nishanth Menon @ 2013-07-17 16:45 UTC (permalink / raw)
To: linux-arm-kernel
commit e00c27ef3b4c23e39d0a77b7c8e5be44c28001c7
(ARM: dts: OMAP5: Add Palmas MFD node and regulator nodes)
introduced regulator entries for OMAP5uEVM.
However, The regulator information is based on an older temporary
pre-production board variant and does not reflect production board
750-2628-XXX boards.
LDO6 supplies the board specified VDDS_1V2_WKUP supply going to
ldo_emu_wkup/vdds_hsic. To stay within the SoC specification supply
1.2V instead of 1.5V.
Reported-by: Marc J?ttner <m-juettner@ti.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
---
arch/arm/boot/dts/omap5-uevm.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
index 1550d6a..3ff5874 100644
--- a/arch/arm/boot/dts/omap5-uevm.dts
+++ b/arch/arm/boot/dts/omap5-uevm.dts
@@ -388,8 +388,8 @@
ldo6_reg: ldo6 {
/* VDDS_1V2_WKUP: hsic/ldo_emu_wkup */
regulator-name = "ldo6";
- regulator-min-microvolt = <1500000>;
- regulator-max-microvolt = <1500000>;
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
regulator-always-on;
regulator-boot-on;
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH 8/9] ARM: dts: omap5-uevm: update LDO7 voltage to 2V and settings
2013-07-17 16:45 [PATCH 0/9] ARM: dts: omap5-uevm: fixup wrong regulator configuration Nishanth Menon
` (6 preceding siblings ...)
2013-07-17 16:45 ` [PATCH 7/9] ARM: dts: omap5-uevm: update LDO6 voltage to 1.2V Nishanth Menon
@ 2013-07-17 16:45 ` Nishanth Menon
2013-07-17 16:45 ` [PATCH 9/9] ARM: dts: omap5-uevm: update SDCARD LDO9 and resource REGEN3 Nishanth Menon
2013-07-29 9:57 ` [PATCH 0/9] ARM: dts: omap5-uevm: fixup wrong regulator configuration Keerthy
9 siblings, 0 replies; 22+ messages in thread
From: Nishanth Menon @ 2013-07-17 16:45 UTC (permalink / raw)
To: linux-arm-kernel
commit e00c27ef3b4c23e39d0a77b7c8e5be44c28001c7
(ARM: dts: OMAP5: Add Palmas MFD node and regulator nodes)
introduced regulator entries for OMAP5uEVM.
However, The regulator information is based on an older temporary
pre-production board variant and does not reflect production board
750-2628-XXX boards.
LDO4 supplies VDD_VPP which is vpp1. This is currently configured for
1.5V which as per data manual "A pulse width of 1000 ns and an amplitude
of 2V is required to program each eFuse bit. Otherwise, VPP1 must not
be supplied".
So, fix the voltage to 2V. and disable the supply since we have no plans
of programming efuse bits - it can only be done once - in factory.
Further it is not enabled by default by PMIC so, 'boot-on' must be
removed, and the 'always-on' needs to be removed to achieve pulsing
if efuse needs to be programmed.
Reported-by: Marc J?ttner <m-juettner@ti.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
---
arch/arm/boot/dts/omap5-uevm.dts | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
index 3ff5874..ef05676 100644
--- a/arch/arm/boot/dts/omap5-uevm.dts
+++ b/arch/arm/boot/dts/omap5-uevm.dts
@@ -397,10 +397,10 @@
ldo7_reg: ldo7 {
/* VDD_VPP: vpp1 */
regulator-name = "ldo7";
- regulator-min-microvolt = <1500000>;
- regulator-max-microvolt = <1500000>;
- regulator-always-on;
- regulator-boot-on;
+ regulator-min-microvolt = <2000000>;
+ regulator-max-microvolt = <2000000>;
+ /* Only for efuse reprograming! */
+ status = "disabled";
};
ldo8_reg: ldo8 {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH 9/9] ARM: dts: omap5-uevm: update SDCARD LDO9 and resource REGEN3
2013-07-17 16:45 [PATCH 0/9] ARM: dts: omap5-uevm: fixup wrong regulator configuration Nishanth Menon
` (7 preceding siblings ...)
2013-07-17 16:45 ` [PATCH 8/9] ARM: dts: omap5-uevm: update LDO7 voltage to 2V and settings Nishanth Menon
@ 2013-07-17 16:45 ` Nishanth Menon
2013-07-29 9:57 ` [PATCH 0/9] ARM: dts: omap5-uevm: fixup wrong regulator configuration Keerthy
9 siblings, 0 replies; 22+ messages in thread
From: Nishanth Menon @ 2013-07-17 16:45 UTC (permalink / raw)
To: linux-arm-kernel
commit e00c27ef3b4c23e39d0a77b7c8e5be44c28001c7
(ARM: dts: OMAP5: Add Palmas MFD node and regulator nodes)
introduced regulator entries for OMAP5uEVM.
However, The regulator information is based on an older temporary
pre-production board variant and does not reflect production board
750-2628-XXX boards.
LDO9 supplies the board specified vdds_sdcard supply going within SoC
specification of 1.8V or 3.0V. Further the supply is controlled by
switch enabled by REGEN3. So, introduce REGEN3 and map sdcard slot to
be powered by LDO9. Remove 'always-on' allowing the LDO to be disabled
on need basis.
Reported-by: Marc J?ttner <m-juettner@ti.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
---
arch/arm/boot/dts/omap5-uevm.dts | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
index ef05676..65d7b60 100644
--- a/arch/arm/boot/dts/omap5-uevm.dts
+++ b/arch/arm/boot/dts/omap5-uevm.dts
@@ -235,7 +235,7 @@
};
&mmc1 {
- vmmc-supply = <&vmmcsd_fixed>;
+ vmmc-supply = <&ldo9_reg>;
bus-width = <4>;
};
@@ -417,8 +417,7 @@
/* VCC_DV_SDIO: vdds_sdcard */
regulator-name = "ldo9";
regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <3300000>;
- regulator-always-on;
+ regulator-max-microvolt = <3000000>;
regulator-boot-on;
};
@@ -439,6 +438,13 @@
regulator-always-on;
regulator-boot-on;
};
+
+ regen3_reg: regen3 {
+ /* REGEN3 controls LDO9 supply to card */
+ regulator-name = "regen3";
+ regulator-always-on;
+ regulator-boot-on;
+ };
};
};
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH 0/9] ARM: dts: omap5-uevm: fixup wrong regulator configuration
2013-07-17 16:45 [PATCH 0/9] ARM: dts: omap5-uevm: fixup wrong regulator configuration Nishanth Menon
` (8 preceding siblings ...)
2013-07-17 16:45 ` [PATCH 9/9] ARM: dts: omap5-uevm: update SDCARD LDO9 and resource REGEN3 Nishanth Menon
@ 2013-07-29 9:57 ` Keerthy
2013-07-29 13:17 ` Nishanth Menon
9 siblings, 1 reply; 22+ messages in thread
From: Keerthy @ 2013-07-29 9:57 UTC (permalink / raw)
To: linux-arm-kernel
Hi Nishanth,
On Wednesday 17 July 2013 10:15 PM, Nishanth Menon wrote:
> Due to wrong older revision of documentation used as reference, we
> seem to have a bunch of LDOs wrongly configured on OMAP5 uEVM. This
> series is based power tree on production board 750-2628-XXX platform.
> Unfortunately, the wrong voltages may be detrimental to OMAP5 as they
> supply hardware blocks at voltages that are out of specification.
This series looks good to me.
Acked-by: J Keerthy <j-keerthy@ti.com>
> Also available at:
> based on v3.11-rc1 tag
> http link: https://github.com/nmenon/linux-2.6-playground/commits/push/omap5-palmas-fixes
> git link: git://github.com/nmenon/linux-2.6-playground.git
> branch: push/omap5-palmas-fixes
>
> Tested with https://patchwork.kernel.org/patch/2545061/
> + https://git.kernel.org/cgit/linux/kernel/git/ssantosh/linux.git/log/?h=for_3.11/out_of_tree/omap5_clk_data
> Test result: http://pastebin.com/YqASYkXG
>
> Relevant documentation:
> - OMAP5 uEVM documentation: https://www.svtronics.com/omap/omap54xx?product_id=33
> - OMAP5432 Data Manual: http://www.ti.com/product/OMAP5432
> - TWL6037 / OTP information: Currently available only under NDA
>
> Nishanth Menon (9):
> ARM: dts: omap5-uevm: document regulator signals used on the actual
> board
> ARM: dts: omap5-uevm: update SMPS9 settings
> ARM: dts: omap5-uevm: update and disable unused regulators LDO[28]
> ARM: dts: omap5-uevm: update LDO1 voltage to 1.5V and settings
> ARM: dts: omap5-uevm: update LDO3 voltage to 1.5V and settings
> ARM: dts: omap5-uevm: update LDO4 voltage to 1.5V and settings
> ARM: dts: omap5-uevm: update LDO6 voltage to 1.2V
> ARM: dts: omap5-uevm: update LDO7 voltage to 2V and settings
> ARM: dts: omap5-uevm: update SDCARD LDO9 and resource REGEN3
>
> arch/arm/boot/dts/omap5-uevm.dts | 78 ++++++++++++++++++++++++--------------
> 1 file changed, 49 insertions(+), 29 deletions(-)
>
Regards,
Keerthy
^ permalink raw reply [flat|nested] 22+ messages in thread* [PATCH 0/9] ARM: dts: omap5-uevm: fixup wrong regulator configuration
2013-07-29 9:57 ` [PATCH 0/9] ARM: dts: omap5-uevm: fixup wrong regulator configuration Keerthy
@ 2013-07-29 13:17 ` Nishanth Menon
2013-07-29 13:39 ` Benoit Cousson
0 siblings, 1 reply; 22+ messages in thread
From: Nishanth Menon @ 2013-07-29 13:17 UTC (permalink / raw)
To: linux-arm-kernel
On 07/29/2013 04:57 AM, Keerthy wrote:
> Hi Nishanth,
>
> On Wednesday 17 July 2013 10:15 PM, Nishanth Menon wrote:
>> Due to wrong older revision of documentation used as reference, we
>> seem to have a bunch of LDOs wrongly configured on OMAP5 uEVM. This
>> series is based power tree on production board 750-2628-XXX platform.
>> Unfortunately, the wrong voltages may be detrimental to OMAP5 as they
>> supply hardware blocks at voltages that are out of specification.
>
> This series looks good to me.
>
> Acked-by: J Keerthy <j-keerthy@ti.com>
Tony, Benoit - this series could prevent OMAP5 from being damaged on
uEVMs with current 3.11 rc - could you suggest what we need to do to get
it in?
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 0/9] ARM: dts: omap5-uevm: fixup wrong regulator configuration
2013-07-29 13:17 ` Nishanth Menon
@ 2013-07-29 13:39 ` Benoit Cousson
2013-07-29 14:13 ` Nishanth Menon
0 siblings, 1 reply; 22+ messages in thread
From: Benoit Cousson @ 2013-07-29 13:39 UTC (permalink / raw)
To: linux-arm-kernel
Hi Nishanth,
On 29/07/2013 15:17, Nishanth Menon wrote:
> On 07/29/2013 04:57 AM, Keerthy wrote:
>> Hi Nishanth,
>>
>> On Wednesday 17 July 2013 10:15 PM, Nishanth Menon wrote:
>>> Due to wrong older revision of documentation used as reference, we
>>> seem to have a bunch of LDOs wrongly configured on OMAP5 uEVM. This
>>> series is based power tree on production board 750-2628-XXX platform.
>>> Unfortunately, the wrong voltages may be detrimental to OMAP5 as they
>>> supply hardware blocks at voltages that are out of specification.
>>
>> This series looks good to me.
>>
>> Acked-by: J Keerthy <j-keerthy@ti.com>
>
> Tony, Benoit - this series could prevent OMAP5 from being damaged on
> uEVMs with current 3.11 rc - could you suggest what we need to do to
> get it in?
I'm still on vacation with no way to pull any patch... but I can still
comment on the series quickly.
It seems to me that this series contains some real fixes that might
damage the board due to hihest voltage than expected and some which are
just improvement like for the SMPS9 or LDO[28]. In theory they should no
go necesseraly to -rc, but, I guess that's fine for that one.
All the "fixes" are sharing more than 50% of the changelog content with
only 2 changes in the code, so you'd better squash them into one patch
to avoid repeating the same thing again and again.
Beside that, I will ack the updated one to allow Tony to push them ASAP.
Regards,
Benoit
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 0/9] ARM: dts: omap5-uevm: fixup wrong regulator configuration
2013-07-29 13:39 ` Benoit Cousson
@ 2013-07-29 14:13 ` Nishanth Menon
[not found] ` <CADz42=M8LQ=i2q30=JJU+F-Qx89D1PwU7pW3DH7F1iYiC8-pFA@mail.gmail.com>
0 siblings, 1 reply; 22+ messages in thread
From: Nishanth Menon @ 2013-07-29 14:13 UTC (permalink / raw)
To: linux-arm-kernel
On 07/29/2013 08:39 AM, Benoit Cousson wrote:
> Hi Nishanth,
>
> On 29/07/2013 15:17, Nishanth Menon wrote:
>> On 07/29/2013 04:57 AM, Keerthy wrote:
>>> Hi Nishanth,
>>>
>>> On Wednesday 17 July 2013 10:15 PM, Nishanth Menon wrote:
>>>> Due to wrong older revision of documentation used as reference, we
>>>> seem to have a bunch of LDOs wrongly configured on OMAP5 uEVM. This
>>>> series is based power tree on production board 750-2628-XXX platform.
>>>> Unfortunately, the wrong voltages may be detrimental to OMAP5 as they
>>>> supply hardware blocks at voltages that are out of specification.
>>>
>>> This series looks good to me.
>>>
>>> Acked-by: J Keerthy <j-keerthy@ti.com>
>>
>> Tony, Benoit - this series could prevent OMAP5 from being damaged on
>> uEVMs with current 3.11 rc - could you suggest what we need to do to
>> get it in?
>
> I'm still on vacation with no way to pull any patch... but I can still
> comment on the series quickly.
Thanks for responding while on vacation.
>
> It seems to me that this series contains some real fixes that might
> damage the board due to hihest voltage than expected and some which are
> just improvement like for the SMPS9 or LDO[28]. In theory they should no
> go necesseraly to -rc, but, I guess that's fine for that one.
>
> All the "fixes" are sharing more than 50% of the changelog content with
> only 2 changes in the code, so you'd better squash them into one patch
> to avoid repeating the same thing again and again.
>
Reason for keeping them separate was to allow any future git bisect to
narrow down to precise patch.
<--->
ARM: dts: omap5-uevm: update SMPS9 settings
ARM: dts: omap5-uevm: update and disable unused regulators LDO[28]
ARM: dts: omap5-uevm: update LDO1 voltage to 1.5V and settings
ARM: dts: omap5-uevm: update LDO3 voltage to 1.5V and settings
ARM: dts: omap5-uevm: update LDO4 voltage to 1.5V and settings
ARM: dts: omap5-uevm: update LDO6 voltage to 1.2V
ARM: dts: omap5-uevm: update LDO7 voltage to 2V and settings
ARM: dts: omap5-uevm: update SDCARD LDO9 and resource REGEN3
<---->
Would you have suggestions on what to squash up?
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 22+ messages in thread