linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] clocksource: Add missing dependency on CONFIG_OF for ARM_ARCH_TIMER
Date: Tue, 30 Jul 2013 12:07:36 +0200	[thread overview]
Message-ID: <51F79068.5050004@linaro.org> (raw)
In-Reply-To: <1374682733-7416-3-git-send-email-jonathan.austin@arm.com>

On 07/24/2013 06:18 PM, Jonathan Austin wrote:
> Initialisation of the ARM Arch timer requires data from the DT. There is no
> fallback initialisation method and hence selecting ARM_ARCH_TIMER without OF
> makes little sense.
> 
> Furthermore, doing so causes a build error because the of_* stubs for
> !CONFIG_OF do not extend to all of the functions being used by this driver,
> and will not be extended unless there are valid use-cases for them to be
> (this is not a valid case).
> 
> Signed-off-by: Jonathan Austin <jonathan.austin@arm.com>
> ---

This falls under the drivers/clocksource umbrella.

Please resend to the maintainers.

Thanks
  -- Daniel

>  drivers/clocksource/Kconfig |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index b7b9b04..4348902 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -72,7 +72,8 @@ config CLKSRC_DBX500_PRCMU_SCHED_CLOCK
>  
>  config ARM_ARCH_TIMER
>  	bool
> -	select CLKSRC_OF if OF
> +	depends on OF
> +	select CLKSRC_OF
>  
>  config ARM_GLOBAL_TIMER
>  	bool
> 


-- 
 <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

  reply	other threads:[~2013-07-30 10:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-24 16:18 [PATCH 0/3] trivial fixes relating to !CONFIG_OF Jonathan Austin
2013-07-24 16:18 ` [PATCH 1/3] PSCI: add missing dependency on CONFIG_OF for PSCI Jonathan Austin
2013-07-24 16:18 ` [PATCH 2/3] clocksource: Add missing dependency on CONFIG_OF for ARM_ARCH_TIMER Jonathan Austin
2013-07-30 10:07   ` Daniel Lezcano [this message]
2013-07-24 16:18 ` [PATCH 3/3] ARM: arch_timer: Add missing include for of_* functions Jonathan Austin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F79068.5050004@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).