From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: OMAP: dss-common: fix Panda's DVI DDC channel
Date: Fri, 2 Aug 2013 07:54:57 -0500 [thread overview]
Message-ID: <51FBAC21.2040609@ti.com> (raw)
In-Reply-To: <1374570405-8301-2-git-send-email-tomi.valkeinen@ti.com>
On 07/23/2013 04:06 AM, Tomi Valkeinen wrote:
> Panda's DVI connector's DDC pins are connected to OMAP's third i2c bus.
> With non-DT, the bus number was 3, and that is what is used in the
> dss-common.c which contains the platform data for Panda's DVI.
>
> However, with DT, the bus number is 2. As we now only have DT boot for
> Panda, we have to change the bus number to make DVI EDID read
> operational.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
> arch/arm/mach-omap2/dss-common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/dss-common.c b/arch/arm/mach-omap2/dss-common.c
> index 393aeef..043e570 100644
> --- a/arch/arm/mach-omap2/dss-common.c
> +++ b/arch/arm/mach-omap2/dss-common.c
> @@ -42,7 +42,7 @@
>
> /* Using generic display panel */
> static struct tfp410_platform_data omap4_dvi_panel = {
> - .i2c_bus_num = 3,
> + .i2c_bus_num = 2,
> .power_down_gpio = PANDA_DVI_TFP410_POWER_DOWN_GPIO,
> };
>
>
completely dumb question :) :
why cant we have dts support for this instead of having to renumber
every time?
Example: if -EPROBEDEFER is incurred due to some unexpected dependency,
we'd have to redo the numbering in the kernel yet again.
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2013-08-02 12:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 9:06 [PATCH 0/2] OMAP: Panda DVI fix and a cleanup Tomi Valkeinen
2013-07-23 9:06 ` [PATCH 1/2] ARM: OMAP: dss-common: fix Panda's DVI DDC channel Tomi Valkeinen
2013-08-02 12:54 ` Nishanth Menon [this message]
2013-08-02 13:00 ` Tomi Valkeinen
2013-08-02 13:30 ` Nishanth Menon
2013-08-02 14:22 ` Tomi Valkeinen
2013-08-02 14:43 ` Nishanth Menon
2013-07-23 9:06 ` [PATCH 2/2] ARM: OMAP2+: Remove legacy DSS initialization for omap4 Tomi Valkeinen
2013-08-02 12:56 ` Nishanth Menon
2013-08-02 13:04 ` Tomi Valkeinen
2013-08-02 13:31 ` Nishanth Menon
2013-08-02 11:58 ` [PATCH 0/2] OMAP: Panda DVI fix and a cleanup Tomi Valkeinen
2013-08-02 12:46 ` Tony Lindgren
2013-08-02 12:52 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FBAC21.2040609@ti.com \
--to=nm@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).