From: csd@broadcom.com (Christian Daudt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: DT: binding fixup to align with vendor-prefixes.txt
Date: Fri, 2 Aug 2013 14:42:46 -0700 [thread overview]
Message-ID: <51FC27D6.8050607@broadcom.com> (raw)
In-Reply-To: <51FC262E.6090706@wwwdotorg.org>
On 13-08-02 02:35 PM, Stephen Warren wrote:
> On 08/02/2013 03:17 PM, Christian Daudt wrote:
>> [ this is a follow-up to this discussion:
>> http://archive.arm.linux.org.uk/lurker/message/20130730.230827.a1ceb12a.en.html ]
>> This patchset renames all uses of "bcm," name bindings to
>> "brcm," as they were done prior to knowing that brcm had
>> already been standardized as Broadcom vendor prefix
>> (in Documentation/devicetree/bindings/vendor-prefixes.txt).
>> This will not cause any churn on devices because none of
>> these bindings have made it into production yet.
>> Also rename the the following dt binding docs that had "bcm,"
>> in their name for consistency:
>> - bcm,kona-sdhci.txt -> kona-sdhci.txt
>> - bcm,kona-timer.txt -> kona-timer.txt
> Using "git format-patch -M" for renames would make it much easier to see
> that all that's happening is a file rename and/or whatever other diff is
> happening.
ok
> I'd actually prefer to go the other way on the file renaming, and name
> all binding files after the complete compatible value they describe,
> rather than removing the vendor prefix on some files. But, I don't feel
> strongly for files I don't directly own.
ok, I'll leave without then. Less chance of future churn :)
> Technically this change shouldn't be made since it's an incompatible
> change to the DT ABI, unless you keep all the old entries in the
> driver's match tables and just add the new entries rather than deleting
> the old ones. If you do that, it should be enough to placate anyone
> adamantly opposed to this change, I think.
>
Done.
Thanks for the quick review !
csd
prev parent reply other threads:[~2013-08-02 21:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 21:17 [PATCH] ARM: DT: binding fixup to align with vendor-prefixes.txt Christian Daudt
2013-08-02 21:35 ` Stephen Warren
2013-08-02 21:42 ` Christian Daudt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FC27D6.8050607@broadcom.com \
--to=csd@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).