linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: davinci: hawk: use gpio descriptor for card detect
Date: Tue, 22 Nov 2016 15:56:33 +0530	[thread overview]
Message-ID: <51a13cb8-082c-c6c8-c1a1-c39de252d022@ti.com> (raw)
In-Reply-To: <20161121161541.27048-4-ahaslam@baylibre.com>

On Monday 21 November 2016 09:45 PM, Axel Haslam wrote:
> Currently the mmc driver is polling the gpio to know if the
> card was removed.
> 
> By using a gpio descriptor instead of the platform callbacks, the
> driver will be able to register the gpio with the mmc core with API's
> designed for this purpose.
> 
> This has the advantage that an irq will be registered,
> and polling is no longer needed. Also, platform callbacks can be removed.
> 
> Signed-off-by: Axel Haslam <ahaslam@baylibre.com>

This patch looks good, provided it is not based of 1/3 and 2/3. There
are other boards in mach-davinci using the card detect and wp callbacks.
And some like board-dm365-evm.c have those pins routed through a CPLD.
So I guess there is more work to be done before platform callbacks can
completely be removed from MMC/SD driver. But the closer we get, the
better it is :)

Thanks,
Sekhar

  reply	other threads:[~2016-11-22 10:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-21 16:15 [PATCH 0/3] ARM: davinci: hawk: fix mmc gpio declaration Axel Haslam
2016-11-21 16:15 ` [PATCH 1/3] ARM: davinci: hawk: fix mmc card detect gpio Axel Haslam
2016-11-22  9:53   ` Sekhar Nori
2016-11-22 10:10     ` Axel Haslam
2016-11-22 10:21       ` Sekhar Nori
2016-11-21 16:15 ` [PATCH 2/3] ARM: davinci: hawk: remove mmc ro pin Axel Haslam
2016-11-22  9:56   ` Sekhar Nori
2016-11-21 16:15 ` [PATCH 3/3] ARM: davinci: hawk: use gpio descriptor for card detect Axel Haslam
2016-11-22 10:26   ` Sekhar Nori [this message]
2016-11-22 12:49     ` Axel Haslam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51a13cb8-082c-c6c8-c1a1-c39de252d022@ti.com \
    --to=nsekhar@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).