From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75278EB64DA for ; Mon, 10 Jul 2023 20:00:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9Ql45TOSE+S9N0tgfml+BLSAh7MaBsJ1H9FVcNBAy4U=; b=AmCpHUiuHcbddW LxWPO4VoDy4yBEwvBpi/aIRLOMNEWS/phjOzjzNZC+5F6lVNDI6lFDq6IuzjkLexejBdkfvIS/0gR VLzJ8f2E/am5cFAlLWQnD4FWqJflUEM6wTAdq7DqeaZdrDM3hLTjJUzBIgxJhcKUI9Bxw5yZkF2kV ufDIlUCZzcnPA0wAn7JBvH49ahNlhEZnm4ijs+8r3vuz24lZmpTMxhsyaFNd1n23Suj4N3b746oE5 p+LqZph+/uzpk5HPb3gGSc+8LzErMw6zuXbKjNRqi17r5586IRfQc90uaWvY68K3T/7NHrMeTcDAc Yb4I3PZthU2AUxT01AlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qIx3O-00Cc79-2x; Mon, 10 Jul 2023 20:00:14 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qIx3M-00Cc5s-09 for linux-arm-kernel@lists.infradead.org; Mon, 10 Jul 2023 20:00:13 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-3fbc59de0e2so51199075e9.3 for ; Mon, 10 Jul 2023 13:00:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689019209; x=1691611209; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fDVF60qAilYaG91C4u1IYCSH3KQRf6AdNGaAEoGvfFM=; b=NNq1wJegp+LAZycSqfE4hHlf2sPQC99bDlqk4ubSCnY+AP5HVzu2c9osNEmMW0W5zf RmscRPS5sof6EzRRHrQCTZFt3Do1Lgc7qmxB9NWqsSTnUqA6p1xRxmpXJDFw8J9kPMVf onum2H0EhKGyLCcLtNVGT0AdBm1ulGXypkrwAq3/9mY0hXfwv+SNBXtuKEVFacqyGEZ+ y8tX4CAidn+65NIr7u5CWKRv05LPnJvyX9TlOYduX+wVEWHKWqxES+kx0tklaAF28cT0 7oV0bgg3Px3ssz4qmht5lzHxEoPz75KbgxfdMl3wj0vWRmgsSfEoJdrOEGN6AQXtFP/7 0bvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689019209; x=1691611209; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fDVF60qAilYaG91C4u1IYCSH3KQRf6AdNGaAEoGvfFM=; b=bbp3TBBwn+/S4RikXfi0sGm+ThJBQjpvWSj7gnK0eE7Uhc9NCqbzUYT4RS1BemQ6sP rQ1iq1YOEETMCIqxX9sGiuWYzbUJ4cmp37v2Twvfbedo0N1Q0tvKJQHFyU4kpHYioLQu I12cLi4Y1KaxpIvJLy2c6u/RLPPws+DiYqKd2QQQ1f4vsdEzaG0nHk0Ar++u3yCCNYjx vrDI+lMTzUfGIO+KVS3YrbLcWQ+lP0jmPlWr3KG69ImauGOpyLC8EMu2HA49huU7Db+q +FMD/ok4oEADbd4IzMJxDS/dvXLeMdZja5+OOAjF9xrO1zv/hiSVbzSntYwrS06w0S9r NF2g== X-Gm-Message-State: ABy/qLbpfdapNYKIRwzC0ydrBf3xs2gthnJUg95+RDBXU8b1+zdoxtyf Imo9oiafHU2MToup/N3D22eYEA== X-Google-Smtp-Source: APBJJlGDvQmb2dW/BEgKveO28TYyio02FWkCpTGpsbBmFvS5kr9/mYi+3CNJaLCbTGI3oIhUgd7KNg== X-Received: by 2002:adf:dcca:0:b0:313:e953:65d0 with SMTP id x10-20020adfdcca000000b00313e95365d0mr12064440wrm.28.1689019209593; Mon, 10 Jul 2023 13:00:09 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id t23-20020a1709066bd700b00992025654c1sm146380ejs.179.2023.07.10.13.00.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Jul 2023 13:00:09 -0700 (PDT) Message-ID: <51a1c2e9-1165-c7ff-809d-b09e09d776e2@linaro.org> Date: Mon, 10 Jul 2023 22:00:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: imx_rproc: Document fsl,startup-delay-ms To: Marek Vasut , linux-remoteproc@vger.kernel.org Cc: Bjorn Andersson , Conor Dooley , Fabio Estevam , Krzysztof Kozlowski , Mathieu Poirier , NXP Linux Team , Peng Fan , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230707232444.374431-1-marex@denx.de> <8f40484e-1721-a2bc-2344-f9e59e51a935@linaro.org> <7a1d7a67-0a0c-8527-d430-30a1cb40de48@denx.de> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <7a1d7a67-0a0c-8527-d430-30a1cb40de48@denx.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230710_130012_088969_F9F89E27 X-CRM114-Status: GOOD ( 20.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/07/2023 15:46, Marek Vasut wrote: > On 7/10/23 14:52, Krzysztof Kozlowski wrote: >> On 10/07/2023 11:18, Marek Vasut wrote: >>> On 7/10/23 10:12, Krzysztof Kozlowski wrote: >>>> On 08/07/2023 01:24, Marek Vasut wrote: >>>>> Document fsl,startup-delay-ms property which indicates how long >>>>> the system software should wait until attempting to communicate >>>>> with the CM firmware. This gives the CM firmware a bit of time >>>>> to boot and get ready for communication. >>>>> >>>>> Signed-off-by: Marek Vasut >>>>> --- >>>>> Cc: Bjorn Andersson >>>>> Cc: Conor Dooley >>>>> Cc: Fabio Estevam >>>>> Cc: Krzysztof Kozlowski >>>>> Cc: Mathieu Poirier >>>>> Cc: NXP Linux Team >>>>> Cc: Peng Fan >>>>> Cc: Pengutronix Kernel Team >>>>> Cc: Rob Herring >>>>> Cc: Sascha Hauer >>>>> Cc: Shawn Guo >>>>> Cc: devicetree@vger.kernel.org >>>>> Cc: linux-arm-kernel@lists.infradead.org >>>>> Cc: linux-remoteproc@vger.kernel.org >>>>> --- >>>>> .../devicetree/bindings/remoteproc/fsl,imx-rproc.yaml | 5 +++++ >>>>> 1 file changed, 5 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml >>>>> index 0c3910f152d1d..c940199ce89df 100644 >>>>> --- a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml >>>>> +++ b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml >>>>> @@ -76,6 +76,11 @@ properties: >>>>> This property is to specify the resource id of the remote processor in SoC >>>>> which supports SCFW >>>>> >>>>> + fsl,startup-delay-ms: >>>>> + default: 0 >>>>> + description: >>>>> + CM firmware start up delay. >>>> >>>> I don't see particular improvements from v2 and no responses addressing >>>> my comment: >>>> https://lore.kernel.org/all/20221102112451.128110-2-peng.fan@oss.nxp.com/ >>> >>> I wasn't aware of this being submitted before, esp. since I wrote the >>> binding document from scratch. Which comment is not addressed, the type >>> ref is not present and the sentence starts with caps, so what is missing ? >> >> >> That the property looks like a hacky solution to some SW problem. Why >> this delay should be different on different boards? > > It probably depends more on the CM4 firmware that is being launched. The > ones I tested were fine with 50..500ms delay, but the delay was always > needed. If this is for some official remoteproc FW running on M4, then probably this could be implied by compatible. Otherwise, if this depends on actual M4 firmware which can totally vary between each board of the same type (I can run my own FW on M4, right?), then it is not suitable DT property. How it would even look like? You add here 500 ms for all known firmwares and then someone comes with FW requiring delay of 600 ms. > > Sure, it is a defect of the NXP provided SDK firmware, but that may not > be fixable in all cases. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel