From: james.morse@arm.com (James Morse)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] arm/arm64: KVM: enable 32 bits kvm vcpu events support
Date: Fri, 12 Oct 2018 12:35:48 +0100 [thread overview]
Message-ID: <51a366e2-1e40-8aac-4fe3-604b74542f29@arm.com> (raw)
In-Reply-To: <1539284855-4035-3-git-send-email-gengdongjiu@huawei.com>
Hi Dongjiu Geng,
On 11/10/2018 20:07, Dongjiu Geng wrote:
> The commit 539aee0edb9f ("KVM: arm64: Share the parts of
> get/set events useful to 32bit") shares the get/set events
> helper for arm64 and arm32,
Oops. I evidently didn't test this bit. Looks like I just depended on the symbol
to be defined, I didn't check the CAP was exposed.
> it is better also share the check
> for vcpu events capability to enable 32 bit kvm vcpu events
> support.
not just better, necessary for correctly-written user-space to know the feature
is supported. This last bit would be clearer as: "but forgot to share the cap
extension code."
Thanks for catching this!
Acked-by: James Morse <james.morse@arm.com>
Thanks,
James
prev parent reply other threads:[~2018-10-12 11:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 19:07 [PATCH v3 0/2] rename function name and enable 32bit vcpu events Dongjiu Geng
2018-10-11 19:07 ` [PATCH v3 1/2] arm/arm64: KVM: rename function kvm_arch_dev_ioctl_check_extension() Dongjiu Geng
2018-10-12 15:45 ` James Morse
2018-10-11 19:07 ` [PATCH v3 2/2] arm/arm64: KVM: enable 32 bits kvm vcpu events support Dongjiu Geng
2018-10-12 11:35 ` James Morse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51a366e2-1e40-8aac-4fe3-604b74542f29@arm.com \
--to=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).