From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06B2AC07C79 for ; Sun, 21 Apr 2024 16:07:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DCYbC/NoXutTIZVjoSaxAmEA7+y+VlHaHDWxEnQfL1E=; b=HFvKOEqVa6yr/LIrQfHV5DyZ4G 4nwSg4nTu/8g5hXqmkWmfp07eHtljLOgrPeIk5iucbg4eWfI0uXX0LcqP0EERpp3SwoWP2flmZjnA xfWIFOpn37oqxigFwrppLIqHDMgDmLY5sQBIPDMnWFpr/yGVYXuJXJ8b4yaVYcUvwpDQGumeevhjS VI8QXcrg7vExmyRqC5jN5nsC80tdpnzF9+wP2d2J4W1wI629SOcxzNxW3yxY9Hf5/aSTRS8X28SNp 6Daq2745yWL2PQijF9PprMfQNMjhxnWHrGTjd29KF1h1ts9fyO9SE794keHiXSMrm9kFSEnMgEMv2 zW0HC31g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ryZjC-0000000An3a-0dTM; Sun, 21 Apr 2024 16:07:42 +0000 Received: from mail.manjaro.org ([2a01:4f8:c0c:51f3::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ryZj8-0000000Amzh-1q59; Sun, 21 Apr 2024 16:07:40 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1713715655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VsbWtpJGTpVE59gMLUthsI5owfAuS8vpivZIQQQ1eIA=; b=Bdvv0JdpiuYrX4w/mGLWCWpiWk0/76kKVfTbP11g+yKcyKSMt7DoVECfFRf//g1f8moZcs zoUj0XNxDvp4JjNqPwYHHPCMHtc1N+2wRJnV20rCigi2zj1UQu+Eo7Oft2hGEwr39zGhQq X6l4ak3NsRp9S2N1ZYxHk3BmSao95pAqBwIpiA9uom9q24Hwfazaejk8IRRUDy9T6NaXEB DxECT69Kpvyu8V5ICo/ChhcwEM4+kCKxnMUo3/Ybr8Jb/6tGWSLSppykuRAaNLlxI1DB4O VGgVrLNgUFF+4YXZg+Atf7LJqZPr9GBEdJvHqZHhnYtAeW2/7A9+qnAcOQ08UA== Date: Sun, 21 Apr 2024 18:07:34 +0200 From: Dragan Simic To: Diederik de Haas Cc: Alexey Charkov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , linux-rockchip@lists.infradead.org, Daniel Lezcano , Viresh Kumar , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/5] RK3588 and Rock 5B dts additions: thermal, OPP and fan In-Reply-To: <3068718.7t0mGDVaCv@bagend> References: <20240229-rk-dts-additions-v3-0-6afe8473a631@gmail.com> <66689051.MzlzmSNrL9@bagend> <9f4c7615a6685ac42dccdbe35e57c357@manjaro.org> <3068718.7t0mGDVaCv@bagend> Message-ID: <51b07f627c5e16461d9c38dc41c0b957@manjaro.org> X-Sender: dsimic@manjaro.org Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240421_090738_866732_AE89843E X-CRM114-Status: GOOD ( 15.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Diederik, On 2024-04-20 19:53, Diederik de Haas wrote: > On Wednesday, 10 April 2024 11:28:09 CEST Dragan Simic wrote: >> > Can you rebase this patch set on Heiko's for-next branch [1]? >> > And then also fix the ordering of the nodes and the elements within >> > those nodes so that they match the current conventions? >> >> Ah, thanks, this is a good reminder about the proposal for the plan >> for moving forward, which I promised to send a while ago. :) >> >>> [1] >>> https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/log/?h=for-next > > I build a (Debian) kernel based off 6.9-rc4 + a whole bunch of patches, > including this patch series. I got someone on #debian-arm to try it out > on a > Rock 5B and the dmesg output showed a number of items wrt thermal and > OPP. > > Some items that I filtered out from that dmesg output: > > [ 3.211716] hwmon hwmon0: temp1_input not attached to any thermal > zone > [ 3.908339] panthor fb000000.gpu: EM: OPP:900000 is inefficient > [ 10.473061] cpu cpu0: EM: OPP:600000 is inefficient > [ 10.473233] energy_model: Accessing cpu4 policy failed > [ 10.585236] rockchip-thermal fec00000.tsadc: Missing rockchip,grf > property > > Attached is the full list of items I collected from that dmesg output > which > seem worth investigating. > > Maybe useful to investigate when moving forward? This is a nice report, thanks! I'm not sure what's going on with the mmc2 issues. Regarding the hym8563, hwmon, energy_model and rockchip-spi issues, I'll have a look into them and come back with an update. Regarding the multiple "OPP: is inefficient" warnings, it's already on my TO-DO list to perform a detailed (and repeatable) testing. My suspicion is that declaring the OPPs as inefficient actually isn't warranted, but we'll see what will be the test results. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel