linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Florian Sylvestre <fsylvestre@baylibre.com>,
	Julien Stephan <jstephan@baylibre.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Louis Kuo <louis.kuo@mediatek.com>,
	Paul Elder <paul.elder@ideasonboard.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	Andy Hsieh <andy.hsieh@mediatek.com>,
	Angelo Gioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 3/5] media: platform: mediatek: isp_30: add mediatek ISP3.0 sensor interface
Date: Tue, 30 Jul 2024 17:15:22 +0200	[thread overview]
Message-ID: <51bbc95c-00e7-41fd-a3eb-65a4eba5ebd0@web.de> (raw)
In-Reply-To: <20240729-add-mtk-isp-3-0-support-v6-3-c374c9e0c672@baylibre.com>

…
> +++ b/drivers/media/platform/mediatek/isp/isp_30/seninf/mtk_seninf_reg.h
> @@ -0,0 +1,117 @@
> +#ifndef __SENINF_REG_H__
> +#define __SENINF_REG_H__
…

How do you think about to omit leading underscores from such identifiers?
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier

Regards,
Markus


  parent reply	other threads:[~2024-07-30 15:17 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-29 14:47 [PATCH v6 0/5] Add Mediatek ISP3.0 Julien Stephan
2024-07-29 14:48 ` [PATCH v6 1/5] dt-bindings: media: add mediatek ISP3.0 sensor interface Julien Stephan
2024-07-29 14:57   ` AngeloGioacchino Del Regno
2024-07-29 15:08     ` AngeloGioacchino Del Regno
2024-07-30 12:38       ` Laurent Pinchart
2024-07-30 19:38   ` Rob Herring (Arm)
2024-07-29 14:48 ` [PATCH v6 2/5] dt-bindings: media: add mediatek ISP3.0 camsv Julien Stephan
2024-07-29 14:57   ` AngeloGioacchino Del Regno
2024-07-30 12:46     ` Laurent Pinchart
2024-07-30 19:40   ` Rob Herring (Arm)
2024-07-29 14:48 ` [PATCH v6 3/5] media: platform: mediatek: isp_30: add mediatek ISP3.0 sensor interface Julien Stephan
2024-07-30 13:29   ` Laurent Pinchart
2024-07-31 13:33     ` Julien Stephan
2024-07-31 13:51       ` Laurent Pinchart
2024-07-30 15:15   ` Markus Elfring [this message]
2024-07-31  6:19   ` CK Hu (胡俊光)
2024-07-29 14:48 ` [PATCH v6 4/5] media: platform: mediatek: isp_30: add mediatek ISP3.0 camsv Julien Stephan
2024-07-30 14:09   ` Laurent Pinchart
2024-07-30 14:34   ` Markus Elfring
2024-07-30 15:00   ` Markus Elfring
2024-07-31  2:59   ` CK Hu (胡俊光)
2024-07-31  8:29     ` Laurent Pinchart
2024-08-07  1:31       ` CK Hu (胡俊光)
2024-08-07 15:20         ` Laurent Pinchart
2024-07-31  3:05   ` CK Hu (胡俊光)
2024-07-31  3:35   ` CK Hu (胡俊光)
2024-07-31  5:14   ` CK Hu (胡俊光)
2024-07-31  5:48   ` CK Hu (胡俊光)
2024-07-29 14:48 ` [PATCH v6 5/5] arm64: dts: mediatek: mt8365: Add support for camera Julien Stephan
2024-07-29 15:08   ` AngeloGioacchino Del Regno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51bbc95c-00e7-41fd-a3eb-65a4eba5ebd0@web.de \
    --to=markus.elfring@web.de \
    --cc=andy.hsieh@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fsylvestre@baylibre.com \
    --cc=jstephan@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=louis.kuo@mediatek.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=paul.elder@ideasonboard.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).