From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95610C0015E for ; Tue, 15 Aug 2023 18:25:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uuyrLmZ82PddhVZSSbsWb1WvgG70QJC5lOCTbIrGFV4=; b=qrasgVxVxL4q6J I3GNVzHYeYNz9gZJqn9NbE1OUzybdmGRoSksyZ5Rc0j9UyLhSygaCcq3QTyNZ0S8PpT4h8Gmmv+s7 HogrBkpiMU9wgv8MySH3o1A0Xx65GdgRmnpDWSX43YyyZEcfRNyrloWWEMsP5tymZJFW5TEz7RcU5 s2LJx+wuzjfoOfW1ISXP9GN2XKq44FQv/aXwjEDzUOXPM90TgKW5Ayeh0zijGQO9VW2FUXEIllDdT vDgqjhOZrw3PlN3G9qPr9At35CkmhA0fTqU63oJdFmfI40TEpceTM9atzxma1fLQYftbP08UK1L9n d/3HGZ8B5GSzOm7SPvlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qVyjP-0029dg-09; Tue, 15 Aug 2023 18:25:27 +0000 Received: from out-4.mta0.migadu.com ([91.218.175.4]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qVyjM-0029d5-1P for linux-arm-kernel@lists.infradead.org; Tue, 15 Aug 2023 18:25:25 +0000 Message-ID: <51cc24cb-13d7-7352-db25-bb5f10baa830@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1692123918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BmnrvXvdD8lgpuFR05ob4D/kjINcLJM401vTSVLXNrM=; b=fRteu83GGLzHE57G2311l51six8Q6p2BxtX/kymFzDXHnCHF1u6j9gAVhn25BW4pFsySlP y0qqD0gp3iqhCN64N/S/StnIjr3lkQpxEr2a8OdBUaO28dbKBDCT6FFJVgLocaE7ON10r8 EVGMAAFJcp2OkdbE/CyN1dTXIJOYe6A= Date: Tue, 15 Aug 2023 19:25:12 +0100 MIME-Version: 1.0 Subject: Re: [PATCH net-next v4 4/9] dpll: netlink: Add DPLL framework base functions Content-Language: en-US To: Jakub Kicinski Cc: Jiri Pirko , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Milena Olech , Michal Michalik , linux-arm-kernel@lists.infradead.org, poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-clk@vger.kernel.org, Bart Van Assche , intel-wired-lan@lists.osuosl.org, Jiri Pirko References: <20230811200340.577359-1-vadim.fedorenko@linux.dev> <20230811200340.577359-5-vadim.fedorenko@linux.dev> <20230814202441.349586b4@kernel.org> <20230815095519.76d06274@kernel.org> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20230815095519.76d06274@kernel.org> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230815_112524_628216_0DF6350D X-CRM114-Status: GOOD ( 12.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15/08/2023 17:55, Jakub Kicinski wrote: > On Tue, 15 Aug 2023 16:18:16 +0100 Vadim Fedorenko wrote: >> On 15/08/2023 04:24, Jakub Kicinski wrote: >>> On Fri, 11 Aug 2023 21:03:35 +0100 Vadim Fedorenko wrote: >>>> + xa_for_each(&pin->dpll_refs, i, ref) { >>>> + const struct dpll_pin_ops *ops = dpll_pin_ops(ref); >>>> + struct dpll_device *dpll = ref->dpll; >>>> + >>>> + if (!ops->frequency_set) >>>> + return -EOPNOTSUPP; >>>> + ret = ops->frequency_set(pin, dpll_pin_on_dpll_priv(dpll, pin), >>>> + dpll, dpll_priv(dpll), freq, extack); >>>> + if (ret) >>>> + return ret; >>>> + __dpll_pin_change_ntf(pin); >>>> + } >>> >>> only one freq is reported in get, AFAICT, so why send a notification >>> after each ref is updated? >> >> The pin can be technically connected to several DPLLs and app may watch >> for the specific DPLL messages only. We would like to inform all users >> on any DPLL which has this pin connected to. > > How does this end up looking in the notifications? > __dpll_pin_change_ntf() only takes the pin object, from a quick read > it seems like it will generate the same notification multiple times. Oops... yeah, will move the notification outside of the loop. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel