From: David.Laight@ACULAB.COM (David Laight)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: Explicitly mark 64-bit constant as unsigned long
Date: Mon, 19 Nov 2018 12:07:16 +0000 [thread overview]
Message-ID: <51cf0f37dc694a858fcc422763f6ca72@AcuMS.aculab.com> (raw)
In-Reply-To: <20181117015456.101222-1-olof@lixom.net>
From: Olof Johansson
> Sent: 17 November 2018 01:55
...
> -#if (SCTLR_EL2_SET ^ SCTLR_EL2_CLEAR) != 0xffffffffffffffff
> +#if (SCTLR_EL2_SET ^ SCTLR_EL2_CLEAR) != 0xfffffffffffffffful
> #error "Inconsistent SCTLR_EL2 set/clear bits"
> #endif
Wouldn't this be clearer if written:
#if SCTLR_EL2_SET != ~SCTLR_EL2_CLEAR
which then begs the question of why there are separate 'set' and 'clear' masks.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
prev parent reply other threads:[~2018-11-19 12:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-17 1:54 [PATCH] arm64: Explicitly mark 64-bit constant as unsigned long Olof Johansson
2018-11-17 2:26 ` Will Deacon
2018-11-17 2:54 ` Olof Johansson
2018-11-19 12:07 ` David Laight [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51cf0f37dc694a858fcc422763f6ca72@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox