From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6C0AC433F5 for ; Wed, 16 Mar 2022 11:38:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UTrLtld9zOU092UuP6vq3DfYSR6N3h2SE5zRE6hABVk=; b=UQMw41TJpGsY7DCR+QUNopWNda iBDbwHPs6HZrAKjeg/8rpkv58Kz2uLril6BFRLNAYl/0PvkhuGxs4UGq2DPKJgqLagiV0fgiFydvU p4XQQhfpL4fEvjVb/N3F8jzJLc0U4UNu55W1MQZSnjL+MkrvRwLiGnk/UrkUDAbJJfRWbGF1CqiyU R6YOi+0SovAOXNybArMeR/YDWARlIyw0uyiE2gyBp58wmXEOJ8/ugrpmCugz8zIRnIfOY/Rth0bLd wYZjpO//rjcevqHOyVbdOi0atV4s/fMYa9/cVJimIMxRB4JLYFfJTOj1V4698AUL8QNxK+0/KhAam ffSugOQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nURxx-00CdaH-1H; Wed, 16 Mar 2022 11:37:21 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nURxu-00CdZ6-7T for linux-arm-kernel@lists.infradead.org; Wed, 16 Mar 2022 11:37:19 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BB9B3616C0; Wed, 16 Mar 2022 11:37:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0BB5C340E9; Wed, 16 Mar 2022 11:37:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647430636; bh=6WH0EimZCMbDaZr0hae+10LSN1K2DhLJLrI/GbfZwiM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Y/mT0c/UrmjY5a/crnP0XI/tOOBTFhFa0ymBuuqYIjelmGwDdC09Oupe6uN0B1tyc +O3SM8EPExJp14LFPTppk68xGjis9j7NJlyQiI33Gk2JgN6RYL7HXjBnCRsz2A1/5S Xvq1EPrX2HvuWS8tjPPQYuRdxbqk5JfGHA31Frb026tZ0nZuST4ZzeA0HebC+syRho cXHXZBGbB1DsGZKUzqb2FYS5gNTKg1bGp0vi5a2w1/yHnQsj0f+lMTZlTyij4uYPHI /MZUvwdFY78sDTNRSJlAibgB1/ian0a4FXkwlVHAWm4Uk8LTvXLJ+tAxUJjjs/6+hk NAojWYFR2ajVg== Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nURxq-00Eto0-9r; Wed, 16 Mar 2022 11:37:14 +0000 MIME-Version: 1.0 Date: Wed, 16 Mar 2022 11:37:14 +0000 From: Marc Zyngier To: Domenico Andreoli Cc: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Thomas Gleixner , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] PCI/MSI: mvebu: Re-enable arch fallbacks In-Reply-To: References: User-Agent: Roundcube Webmail/1.4.13 Message-ID: <51ec54c21ba7649046362169987c2ff0@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: domenico.andreoli@linux.com, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220316_043718_390899_2BF4CB53 X-CRM114-Status: GOOD ( 17.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-03-16 09:33, Domenico Andreoli wrote: > From: Domenico Andreoli > > Since v5.10, my QNAP happily barks at boot as follows (5.17.0-rc8): > > [ 0.923811] ------------[ cut here ]------------ > [ 0.928458] WARNING: CPU: 0 PID: 1 at drivers/pci/msi/msi.h:17 > pci_msi_setup_msi_irqs+0x54/0x6c > [ 0.937219] Modules linked in: > [ 0.940290] CPU: 0 PID: 1 Comm: swapper Not tainted > 5.17.0-rc8-marvell #6 > [ 0.947117] Hardware name: Marvell Kirkwood (Flattened Device Tree) > [ 0.953428] unwind_backtrace from show_stack+0x10/0x14 > [ 0.958698] show_stack from __warn+0xac/0xe4 > [ 0.963093] __warn from warn_slowpath_fmt+0x68/0x80 > [ 0.968098] warn_slowpath_fmt from pci_msi_setup_msi_irqs+0x54/0x6c > [ 0.974499] pci_msi_setup_msi_irqs from > __pci_enable_msi_range+0x260/0x340 > [ 0.981509] __pci_enable_msi_range from > pci_alloc_irq_vectors_affinity+0xb8/0xf8 > [ 0.989043] pci_alloc_irq_vectors_affinity from > xhci_run+0x164/0x474 > [ 0.995532] xhci_run from usb_add_hcd+0x444/0x6e0 > [ 1.000362] usb_add_hcd from usb_hcd_pci_probe+0x30c/0x37c > [ 1.005979] usb_hcd_pci_probe from xhci_pci_probe+0x10/0xec > [ 1.011689] xhci_pci_probe from pci_device_probe+0x74/0xe8 > [ 1.017305] pci_device_probe from really_probe+0x1c0/0x3f8 > [ 1.022921] really_probe from driver_probe_device+0x30/0xb0 > [ 1.028623] driver_probe_device from __driver_attach+0x11c/0x148 > [ 1.034762] __driver_attach from bus_for_each_dev+0x54/0x78 > [ 1.040466] bus_for_each_dev from bus_add_driver+0x170/0x1d8 > [ 1.046256] bus_add_driver from driver_register+0xac/0xf0 > [ 1.051783] driver_register from do_one_initcall+0x74/0x1b8 > [ 1.057495] do_one_initcall from kernel_init_freeable+0x1a8/0x1ec > [ 1.063723] kernel_init_freeable from kernel_init+0x10/0x108 > [ 1.069514] kernel_init from ret_from_fork+0x14/0x3c > [ 1.074604] Exception stack(0xc1835fb0 to 0xc1835ff8) > [ 1.079691] 5fa0: 00000000 > 00000000 00000000 00000000 > [ 1.087915] 5fc0: 00000000 00000000 00000000 00000000 00000000 > 00000000 00000000 00000000 > [ 1.096136] 5fe0: 00000000 00000000 00000000 00000000 00000013 > 00000000 > [ 1.102787] ---[ end trace 0000000000000000 ]--- > [ 1.107435] ------------[ cut here ]------------ > > > I bisected it down to commit 077ee78e392869e46ae (PCI/MSI: Make > arch_.*_msi_irq[s] fallbacks selectable). > > Re-enabling PCI/MSI arch fallbacks restores a clean bootlog. > > Cc: Thomas Gleixner > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Domenico Andreoli > > --- > arch/arm/mach-mvebu/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > Index: b/arch/arm/mach-mvebu/Kconfig > =================================================================== > --- a/arch/arm/mach-mvebu/Kconfig > +++ b/arch/arm/mach-mvebu/Kconfig > @@ -123,6 +123,7 @@ config MACH_KIRKWOOD > select ORION_IRQCHIP > select ORION_TIMER > select FORCE_PCI > + select PCI_MSI_ARCH_FALLBACKS if PCI_MSI > select PCI_QUIRKS > select PINCTRL_KIRKWOOD > help This really is papering over the real issue, which probably is that the platform *doesn't* support MSIs, and yet the PCI controller driver doesn't advertises that. See 645e9c38383d ("PCI: mediatek: Advertise lack of built-in MSI handling") for an example of how to fix your PCI controller driver. Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel