From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6047BC4363D for ; Wed, 23 Sep 2020 05:32:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2A8B21941 for ; Wed, 23 Sep 2020 05:32:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="l+kThxJY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="idO6wdrB"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="CudcLNp6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2A8B21941 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jm2Pt46jxFJcpIs5k1ROKO5ZRCEUeFFegSh38Y8mhCc=; b=l+kThxJY50ONWoV2vVcexCsvF zsmwTinjfM7qeiHrx3kZV47TiCRQ6pUat/9DW6lsViBkqpJEDCqx3Go7i1L5gE2DIIpMe3G5McnmR /IMgwqUvn/kt8RIVZyXZANiTu8gqzj9XC8lcevwIdqbgTKYZgru8L2gGcyAm1iFkXDcrbc4SQLT6L cKFdTjvy3OANf3vGkYA7IAN4Y5jJlipv7bw1Bx+HkCl+rapdQYgQBlPA92Iy6r16rIUJyIOhaCoZe 2v6yqTwe9BVAhxF51DNk1TkGrUfDJbU20VU/gXZoXWfNuouGqub5lI4/7remP5R7Zx3Xt6ABVWyxd 2WSgWqWxQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKxMc-000690-2T; Wed, 23 Sep 2020 05:30:46 +0000 Received: from esa4.microchip.iphmx.com ([68.232.154.123]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKxMZ-00068P-8R for linux-arm-kernel@lists.infradead.org; Wed, 23 Sep 2020 05:30:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1600839043; x=1632375043; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=zSuy1EcIiNrZpEDc76+PV8VqmcvIrWKgMmawDW06apI=; b=idO6wdrB4C14/YgtShGp+yz3zZ2XJUsTq5rwalxZ4jhaNe1N11pgjzQH WlgTJpWmvdLlK2q66CnVB8ap0j1gsTz+sbpY7ZOzwtJ5WpNvEM5ifnshI yslHWUkelVBrvu6UeSo4p8/URPCPnTyedGlzWq249Y/LKdD9dkAOB+kuq AK/ryVj0jgXPpf2NDy4F947Rppw+q5hZoALasbRutR0FIlXKj70xdKlAT t/2CzpIgkdg5tLA+t83VEL1A/6woxBuLF2NrQV8Z4i7Z9+RAEbiLEb0FO 4dV/yDGM76vNRwezPl9XblCZAvbe43lkpW1wNF7yL5izIFuxwKHC2EQFk A==; IronPort-SDR: LySbLzlW5w8+/pE9LFL5bzOIa3qc1DbN9JDRT4yD6mQcRpeCMAhoTZuqV5GFdN/E1RZW9efFBA V+HJoobcsf3XReEyXs83/F/uf163huBO+IYEvHWzPFyetCugjXzgiCVkuUDBwaRS7TmflYn8T8 saKG/OvCGFtWRXm4JscmVz2F2TNvpSIw3TQGQLCayZy9WugrRhujAC1MQzNvWbR9/etujWJ1C9 wHJe38hLDFEdJBALP8v/OWd5CxGNoJlE+We2PH8ypbp3beDGtBifgsHY3895bjnY/QOdr3QwA4 E7g= X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="87836742" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 22 Sep 2020 22:30:42 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Tue, 22 Sep 2020 22:30:39 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3 via Frontend Transport; Tue, 22 Sep 2020 22:30:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W7MuAcyLrupp0BE74fgE5p4wPlICT9RciVKlLg8Fg7RCdUd7qoa8RbfhB4+RNfB/beMj0vyCfz7s4qY9qH+25DbHSgFAgOp0jFL5NN71haBaE6qTc8e22OzcIGz0IRmnwgfPO4+7oPgAFg76pYq9+gyKpuKkzoOc2Ahg7Z5Igp7OaR0PE7TLHkzovB56RRsP+jHaAkbfZR9z2BYiyjSbcIee4xbX06g5BQoQePoKtU3M8C1KImJI9AikMHTiWoOmtSTekRJfyaplMxZiBZswtuhM51cKiPzSpxL64Lss/4zTY3nrytG7+vMXbvHU4DHIQ77MtmGjOLoSwPoaQxH8HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zSuy1EcIiNrZpEDc76+PV8VqmcvIrWKgMmawDW06apI=; b=N+jOO1PpGxVeKfAFUjXeJ9kHip0NAw3GM+oPtPBzRb4mREis2X2DrDckRwOIbBX8fXvoZt/Hy8ZcWIxs2bhk42hu3DLrjOY5A2mCQW/OrT9uZMhRCF+jR5yJVnY/Oerkjpu9WkhFfi9ivODswhbhhQZVNCt8sEB4/29YVSNPq+dOoVgSqi9sfYiDzovHfvElXu6Crp+76o0DZDiAvyJnfhuy7kP4cXjD5tWNRzSdR2EREmlN1XafeidsuTPwx7hd8TQkUaUiY2PKk+pkZtgu+ZwoHHKi+Hj49eGFyFm3Cg8eku0Ci/C0UpbmF2OtDqN1mNmO9n7pxI6iuJv+IF6XDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zSuy1EcIiNrZpEDc76+PV8VqmcvIrWKgMmawDW06apI=; b=CudcLNp6zFdgFdA55MnKUpCjbYUzy/wPTwdXVeDv9v6kssMxJgd8kglLa7d9AqNUkyJel7THWDRFON3OOE7s7Ex7poXSgzkxthoJPbYhOBqSW9QyjSYCE4V3cRioPJ93ukOdnk+9WcQKIH5OvczsWT/jU6jJVCpksdDo5We4GE0= Received: from DM5PR11MB1914.namprd11.prod.outlook.com (2603:10b6:3:112::12) by DM6PR11MB4513.namprd11.prod.outlook.com (2603:10b6:5:2a2::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.14; Wed, 23 Sep 2020 05:30:40 +0000 Received: from DM5PR11MB1914.namprd11.prod.outlook.com ([fe80::a8e8:d0bc:8b3c:d385]) by DM5PR11MB1914.namprd11.prod.outlook.com ([fe80::a8e8:d0bc:8b3c:d385%11]) with mapi id 15.20.3391.027; Wed, 23 Sep 2020 05:30:40 +0000 From: To: , , , Subject: Re: [PATCH 4/7] dmaengine: at_xdmac: adapt perid for mem2mem operations Thread-Topic: [PATCH 4/7] dmaengine: at_xdmac: adapt perid for mem2mem operations Thread-Index: AQHWkWqs0npVjkI8wkK878r6lyc5AA== Date: Wed, 23 Sep 2020 05:30:40 +0000 Message-ID: <520058c4-00a6-bbe3-2b60-93477be982fa@microchip.com> References: <20200914140956.221432-1-eugen.hristev@microchip.com> <20200914140956.221432-5-eugen.hristev@microchip.com> In-Reply-To: <20200914140956.221432-5-eugen.hristev@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 authentication-results: microchip.com; dkim=none (message not signed) header.d=none;microchip.com; dmarc=none action=none header.from=microchip.com; x-originating-ip: [82.77.80.152] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b87065a9-99f7-48a3-bb79-08d85f81cf5e x-ms-traffictypediagnostic: DM6PR11MB4513: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-bypassexternaltag: True x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MUT1WgsXBBT4/LavWiVbXqWxHoERW5teI/0hgHn4pxSHxnif4pSzk8+HF1d5dcqx6WLZZoYUZ4Ruwa+HDbEHgTw8KWh7ESSnpBtboX9IVI6vpdBBxS+YG1A8LU5tLvetGvX/K+w9FLfEYmEHCRkvgsqVY8KAenwTSZ4AjZ6uXb9g31MwKSv1/hEiLR6xvcEWhB3etIPxcL52B9XOd6InTJuGxs2iz4KveuNRAI8qpkBzhUAQYJ0YabTrFiEUSMz5X6PRUVYx9QUlNYmf3A2WM19ZqlfL++rLy2su6DLYiE/zWqT+MAo4p9wX48VzokZYNZ0Kd87PPMhuFimommvvgn3ev0W4hTzzUo3m/F0bJ5DkJ964fOyY6/OeMPMEvQhUSdKDAazw1IGa4tw47fghfpe3C1j5n0koaSPv+/Ma79Bb6T4zoQD+QsyZLWUzgVs2 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1914.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(396003)(376002)(346002)(136003)(366004)(64756008)(6486002)(4326008)(66476007)(66556008)(8936002)(6506007)(66946007)(31696002)(66446008)(8676002)(53546011)(316002)(71200400001)(5660300002)(107886003)(36756003)(76116006)(2906002)(6512007)(54906003)(110136005)(478600001)(86362001)(91956017)(2616005)(6636002)(186003)(31686004)(26005)(83380400001)(43740500002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: krqigUpZDZx0esNVSWSMhL6EvlHJZuMp4e8xRGbxTRpCFqNV0khJngAvOQOKVzrL7me9iLJZKptMv8rnEfyPA/XQNIG4nnzX3Rcs11NB0Jsqa8yzKuVOU66R+yCD9TyuqCRb9n4VEWwi8lE1Q0x8ucOB3bhsh+RVRJiFqSKJ34yoLjTxavVqWR/nMgwttFI4JT6qjV6DY4a0u+iqhxqP2D3RgtT8cxW0uLJI+CLJjyAvq9JOxLe7WJosMIzvvhtBLB7/HeHgkG/SAeip2wAH/+KG3+xHqvu/vYlwr26LH4KBuURfcsQQLpHaS8dXpGDRk3sn0HG06MASxww2o6DnDqat9KDyANGCRhXS6u0TEYouVeLDAYouH0Lya32OzmL4ZyE5703xPo/jUflL7nAp5v92DujbOIviK84HW7+vhGnI2/YCR3a44aNuCLdqRpZzN+qCl9dFR6kpJJZTemJV9C/lpCtKcnr3udJZcLsgsam9lhJp769ww/EZDN7cCTbQQ9volKlE8dXsPyViavCjbvS3Ew9YdfY868nOSBua5ThNkrC2aQPdk/Cnnkqps2O25t8yaPwMeC8SvbEdfdpEZ4MGFQs4bLuGqtReWXSoaDurxvy4QTumth0ne/3nGFZTkrHPrmHDFg3glFjf/kwzsw== Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1914.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b87065a9-99f7-48a3-bb79-08d85f81cf5e X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2020 05:30:40.6237 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gMxycrOF5+Ln2aTCjjSksQbcb32YtEsHjAYjhMg2IvwwNwChQ6JlZ7zEMP7B6BC3FDm/f0dtZ35UAzo7jNaQqVPRND1IrBsbDbgqjXK+KxE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4513 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200923_013043_417672_84775E24 X-CRM114-Status: GOOD ( 18.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/14/20 5:09 PM, Eugen Hristev wrote: > The PERID in the CC register for mem2mem operations must match an unused > PERID. > The PERID field is 7 bits, but the selected value is 0x3f. > On later products we can have more reserved PERIDs for actual peripherals, > thus this needs to be increased to maximum size. > Changing the value to 0x7f, which is the maximum for 7 bits field. > Maybe it is worth to explain that for memory-to-memory transfers, PERID should be set to an unused peripheral ID, and the maximum value seems the safest. Anyway with or without this addressed, one can add: Reviewed-by: Tudor Ambarus > Signed-off-by: Eugen Hristev > --- > drivers/dma/at_xdmac.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c > index fab19e00a7be..81bb90206092 100644 > --- a/drivers/dma/at_xdmac.c > +++ b/drivers/dma/at_xdmac.c > @@ -726,7 +726,7 @@ at_xdmac_interleaved_queue_desc(struct dma_chan *chan, > * match the one of another channel. If not, it could lead to spurious > * flag status. > */ > - u32 chan_cc = AT_XDMAC_CC_PERID(0x3f) > + u32 chan_cc = AT_XDMAC_CC_PERID(0x7f) > | AT_XDMAC_CC_DIF(0) > | AT_XDMAC_CC_SIF(0) > | AT_XDMAC_CC_MBSIZE_SIXTEEN > @@ -908,7 +908,7 @@ at_xdmac_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dest, dma_addr_t src, > * match the one of another channel. If not, it could lead to spurious > * flag status. > */ > - u32 chan_cc = AT_XDMAC_CC_PERID(0x3f) > + u32 chan_cc = AT_XDMAC_CC_PERID(0x7f) > | AT_XDMAC_CC_DAM_INCREMENTED_AM > | AT_XDMAC_CC_SAM_INCREMENTED_AM > | AT_XDMAC_CC_DIF(0) > @@ -1014,7 +1014,7 @@ static struct at_xdmac_desc *at_xdmac_memset_create_desc(struct dma_chan *chan, > * match the one of another channel. If not, it could lead to spurious > * flag status. > */ > - u32 chan_cc = AT_XDMAC_CC_PERID(0x3f) > + u32 chan_cc = AT_XDMAC_CC_PERID(0x7f) > | AT_XDMAC_CC_DAM_UBS_AM > | AT_XDMAC_CC_SAM_INCREMENTED_AM > | AT_XDMAC_CC_DIF(0) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel