linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: christophe.leroy@c-s.fr (leroy christophe)
To: linux-arm-kernel@lists.infradead.org
Subject: MAX7301 GPIO: Do not force SPI speed when using OF Platform
Date: Wed, 07 Aug 2013 13:31:11 +0200	[thread overview]
Message-ID: <52022FFF.3060507@c-s.fr> (raw)
In-Reply-To: <51EFAA19.4020905@antcom.de>

Hi,

You have to add the following in your dts:

spi-bits = <16>;

Regards
Christophe

Le 24/07/2013 12:19, Roland Stigge a ?crit :
> Hi,
>
> commit 047b93a35961f7a6561e6f5dcb040738f822b892 introduced the following
> to gpio-max7301.c:
>
> 	/* bits_per_word cannot be configured in platform data */
> -	spi->bits_per_word = 16;
> +	if (spi->dev.platform_data)
> +		spi->bits_per_word = 16;
>   	ret = spi_setup(spi);
>
> Comment is: "The bit_per_word can be set in the OF Device tree, so no
> need to force it as with the platform_data when using OF Platform"
>
> Can you please point me to the respective OF option? I couldn't find it
> under drivers/spi/spi* or Documentation/devicetree/bindings/spi/*.
>
> Thanks in advance,
>
> Roland
>

  reply	other threads:[~2013-08-07 11:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-24 10:19 MAX7301 GPIO: Do not force SPI speed when using OF Platform Roland Stigge
2013-08-07 11:31 ` leroy christophe [this message]
2013-08-07 12:17   ` Roland Stigge
2013-08-07 12:35     ` leroy christophe
2013-08-07 12:46       ` Roland Stigge
2013-08-07 15:20         ` leroy christophe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52022FFF.3060507@c-s.fr \
    --to=christophe.leroy@c-s.fr \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).