From: christophe.leroy@c-s.fr (leroy christophe)
To: linux-arm-kernel@lists.infradead.org
Subject: MAX7301 GPIO: Do not force SPI speed when using OF Platform
Date: Wed, 07 Aug 2013 17:20:18 +0200 [thread overview]
Message-ID: <520265B2.3080403@c-s.fr> (raw)
In-Reply-To: <5202418B.5090203@antcom.de>
Hi,
Le 07/08/2013 14:46, Roland Stigge a ?crit :
> Hi,
>
> On 08/07/2013 02:35 PM, leroy christophe wrote:
>>>> spi-bits = <16>;
>>> I tried this, both in the device's and in the controller's node. But it
>>> didn't work. However, as described, I didn't expect it to work, because
>>> there is no code present to handle "spi-bits". At least not in 3.10.
>>>
>>> Am I missing something? Otherwise, maybe something of the tree that you
>>> are talking about is missing from mainline still?
>>>
>>>
>> Strange. I'm using 3.8.13
>> I have it handled in drivers/spi/spi.c in function
>> of_register_spi_devices()
> 3.8.13's (as well as newer ones') drivers/spi/spi.c doesn't handle
> "spi-bits", see also
>
> https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/spi/spi.c?h=linux-3.8.y
>
> Maybe you have additional patches that are not in mainline, yet?
>
> Thanks,
>
> Roland
>
Yes you are right, I have the attached patch in addition which have been
in our code for long time and which has never been submitted for
inclusion in the mainline kernel.
Sorry about that, I will submit it.
Regards
Christophe
-------------- next part --------------
--- linux-3.8.13/drivers/spi/spi.c 2013-05-11 22:57:46.000000000 +0200
+++ linux/drivers/spi/spi.c 2013-08-06 18:15:34.000000000 +0200
@@ -870,6 +870,11 @@
if (of_find_property(nc, "spi-3wire", NULL))
spi->mode |= SPI_3WIRE;
+ /* Bits per word */
+ prop = of_get_property(nc, "spi-bits", &len);
+ if (prop && len >= sizeof(*prop)) {
+ spi->bits_per_word = prop[0];
+ }
/* Device speed */
prop = of_get_property(nc, "spi-max-frequency", &len);
if (!prop || len < sizeof(*prop)) {
prev parent reply other threads:[~2013-08-07 15:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 10:19 MAX7301 GPIO: Do not force SPI speed when using OF Platform Roland Stigge
2013-08-07 11:31 ` leroy christophe
2013-08-07 12:17 ` Roland Stigge
2013-08-07 12:35 ` leroy christophe
2013-08-07 12:46 ` Roland Stigge
2013-08-07 15:20 ` leroy christophe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520265B2.3080403@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).