From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF71CC433EF for ; Fri, 26 Nov 2021 10:24:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nntCwMq8liWix2zyTBsHVrxcNzZAQp5CBx9777zi26w=; b=zrRXMEAbAkTOVdNOCD7Njdxqr9 9uXFS7isLzkb+X5x606nwuEu2057ryQm/CWkKBqQNRgxxdRvyFh0kg9dtm60EMH0qvr1dNRTxR5Vg zDX7vDo1D265q10gzSLw9Vkk0jyEuKPqL7nONgC5P6dk1rsicyRDV9Lo//icIzuY4KfbfZagBr4J7 bnMSDp9pibv47BrX1dvsT6e/s1fnri1qEplY6MLV1+Rtfmi6uL8NIM/B/cP04+ri/qijjveG09Z51 BEm07mzcbgYtKTw0kNVx05u7jVpxOhYWul6oRxRKXB8VH0lcqvepsqzrRK9lg/8sOesPycFsn+Ix9 b3OqUp1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqYNK-009z2y-5y; Fri, 26 Nov 2021 10:22:39 +0000 Received: from relay03.th.seeweb.it ([2001:4b7a:2000:18::164]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqYND-009yyx-Mw; Fri, 26 Nov 2021 10:22:33 +0000 Received: from IcarusMOD.eternityproject.eu (unknown [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id 287EF201B4; Fri, 26 Nov 2021 11:22:22 +0100 (CET) Subject: Re: [PATCH v6 5/7] drm/mediatek: dpi: Add dpintf support To: Guillaume Ranquet , Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger Cc: Markus Schneider-Pargmann , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20211110130623.20553-1-granquet@baylibre.com> <20211110130623.20553-6-granquet@baylibre.com> From: AngeloGioacchino Del Regno Message-ID: <5205e450-9a10-ff50-2eb9-1fd93e928f28@somainline.org> Date: Fri, 26 Nov 2021 11:22:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211110130623.20553-6-granquet@baylibre.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211126_022231_931514_6B561B25 X-CRM114-Status: GOOD ( 21.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Il 10/11/21 14:06, Guillaume Ranquet ha scritto: > From: Markus Schneider-Pargmann > > dpintf is the displayport interface hardware unit. This unit is similar > to dpi and can reuse most of the code. > > This patch adds support for mt8195-dpintf to this dpi driver. Main > differences are: > - Some features/functional components are not available for dpintf > which are now excluded from code execution once is_dpintf is set > - dpintf can and needs to choose between different clockdividers based > on the clockspeed. This is done by choosing a different clock parent. > - There are two additional clocks that need to be managed. These are > only set for dpintf and will be set to NULL if not supplied. The > clk_* calls handle these as normal clocks then. > - Some register contents differ slightly between the two components. To > work around this I added register bits/masks with a DPINTF_ prefix > and use them where different. > > Based on a separate driver for dpintf created by > Jason-JH.Lin . > > Signed-off-by: Markus Schneider-Pargmann > Signed-off-by: Guillaume Ranquet Hello Guillaume, Markus Strictly speaking about functionality, the entire series is totally fine, however, I cannot give you a R-b on patches 6 and 7, since this code should *really* make use of phy_get(), like suggested by Vinod. In any case, for this patch: Reviewed-by: AngeloGioacchino Del Regno _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel