From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 08/12] dma: edma: Add one more required slot to MAX slots
Date: Mon, 12 Aug 2013 11:26:49 +0530 [thread overview]
Message-ID: <52087921.8040101@ti.com> (raw)
In-Reply-To: <1375719297-12871-9-git-send-email-joelf@ti.com>
On Monday 05 August 2013 09:44 PM, Joel Fernandes wrote:
> We'd now need a separate slot just for the channel and separate
> ones for the 2 linked sets, so we make adjustments to allocate
> an extra channel accordingly.
>
> Signed-off-by: Joel Fernandes <joelf@ti.com>
No need for a separate patch for this, just do this in the patch where
you include the two linked sets.
> ---
> drivers/dma/edma.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
> index a242269..df50a04 100644
> --- a/drivers/dma/edma.c
> +++ b/drivers/dma/edma.c
> @@ -48,7 +48,7 @@
>
> /* Max of 16 segments per channel to conserve PaRAM slots */
> #define MAX_NR_SG 16
> -#define EDMA_MAX_SLOTS MAX_NR_SG
> +#define EDMA_MAX_SLOTS (MAX_NR_SG+1)
> #define EDMA_DESCRIPTORS 16
>
> struct edma_desc {
> @@ -311,6 +311,9 @@ static struct dma_async_tx_descriptor *edma_prep_slave_sg(
>
> num_slots_needed = sg_len > MAX_NR_SG ? MAX_NR_SG : sg_len;
>
> + /* Allocate one extra to account for the channel itself */
> + num_slots_needed++;
You can do:
nslots = min(MAX_NR_SG, sg_len) + 1;
Thanks,
Sekhar
next prev parent reply other threads:[~2013-08-12 5:56 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 16:14 [PATCH v3 00/12] edma: Add support for SG lists of any length Joel Fernandes
2013-08-05 16:14 ` [PATCH v3 01/12] dma: edma: Setup parameters to DMA MAX_NR_SG at a time Joel Fernandes
2013-08-12 7:15 ` Sekhar Nori
2013-08-12 23:55 ` Joel Fernandes
2013-08-13 0:19 ` Joel Fernandes
2013-08-13 0:05 ` Joel Fernandes
2013-08-05 16:14 ` [PATCH v3 02/12] ARM: edma: Don't clear EMR of channel in edma_stop Joel Fernandes
2013-08-08 11:49 ` Sekhar Nori
2013-08-12 4:25 ` Sekhar Nori
2013-08-12 4:29 ` Joel Fernandes
2013-08-12 6:24 ` Sekhar Nori
2013-08-05 16:14 ` [PATCH v3 03/12] dma: edma: remove limits on number of slots Joel Fernandes
2013-08-12 7:17 ` Sekhar Nori
2013-08-05 16:14 ` [PATCH v3 04/12] dma: edma: Write out and handle MAX_NR_SG at a given time Joel Fernandes
2013-08-05 16:14 ` [PATCH v3 05/12] ARM: edma: Add function to enable interrupt for a PaRAM slot Joel Fernandes
2013-08-05 16:14 ` [PATCH v3 06/12] ARM: edma: Add pr_debug in edma_link Joel Fernandes
2013-08-05 16:14 ` [PATCH v3 07/12] dma: edma: Add function to dump a PaRAM set from PaRAM Joel Fernandes
2013-08-12 5:52 ` Sekhar Nori
2013-08-13 1:06 ` Joel Fernandes
2013-08-05 16:14 ` [PATCH v3 08/12] dma: edma: Add one more required slot to MAX slots Joel Fernandes
2013-08-12 5:56 ` Sekhar Nori [this message]
2013-08-12 13:31 ` Mark Brown
2013-08-12 18:19 ` Joel Fernandes
2013-08-13 1:08 ` Joel Fernandes
2013-08-05 16:14 ` [PATCH v3 09/12] dma: edma: Implement multiple linked sets for continuity Joel Fernandes
2013-08-12 18:56 ` Sekhar Nori
2013-08-13 1:00 ` Joel Fernandes
2013-08-05 16:14 ` [PATCH v3 10/12] dma: edma: Check if MAX_NR_SG is even in prep function Joel Fernandes
2013-08-05 16:14 ` [PATCH v3 11/12] dma: edma: Keep tracking of Pending interrupts (pending_acks) Joel Fernandes
2013-08-05 16:14 ` [PATCH v3 12/12] dma: edma: Return if nothing left todo in edma_execute Joel Fernandes
2013-08-16 5:57 ` [PATCH v3 00/12] edma: Add support for SG lists of any length Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52087921.8040101@ti.com \
--to=nsekhar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).