From: zonque@gmail.com (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] usb: musb dsps: fix pdev cast in suspend/resume
Date: Tue, 13 Aug 2013 17:45:08 +0200 [thread overview]
Message-ID: <520A5484.5060908@gmail.com> (raw)
In-Reply-To: <20130813153738.GJ27954@radagast>
On 13.08.2013 17:37, Felipe Balbi wrote:
> On Tue, Aug 13, 2013 at 02:40:30PM +0200, Daniel Mack wrote:
>> diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
>> index 5233804..f20218e 100644
>> --- a/drivers/usb/musb/musb_dsps.c
>> +++ b/drivers/usb/musb/musb_dsps.c
>> @@ -692,7 +692,7 @@ static int dsps_remove(struct platform_device *pdev)
>> #ifdef CONFIG_PM_SLEEP
>> static int dsps_suspend(struct device *dev)
>> {
>> - struct platform_device *pdev = to_platform_device(dev->parent);
>> + struct platform_device *pdev = to_platform_device(dev);
>> struct dsps_glue *glue = platform_get_drvdata(pdev);
>
> actually, can you get rid of the platform_device access here ? The
> following should work:
>
> struct dsps_glue *glue = dev_get_drvdata(dev);
>
Right, thank you Felipe. I just sent out v2.
Daniel
next prev parent reply other threads:[~2013-08-13 15:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 12:40 [PATCH] usb: musb dsps: fix pdev cast in suspend/resume Daniel Mack
2013-08-13 15:37 ` Felipe Balbi
2013-08-13 15:45 ` Daniel Mack [this message]
2013-08-21 8:50 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520A5484.5060908@gmail.com \
--to=zonque@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).