From: zonque@gmail.com (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] ASoC: pxa: pxa-ssp: add DT bindings
Date: Thu, 15 Aug 2013 15:43:14 +0200 [thread overview]
Message-ID: <520CDAF2.7010101@gmail.com> (raw)
In-Reply-To: <20130815133925.GA30073@sirena.org.uk>
On 15.08.2013 15:39, Mark Brown wrote:
> On Thu, Aug 15, 2013 at 12:51:31PM +0200, Daniel Mack wrote:
>
>> Hmm, and you don't like the approach either of having upstream ports and
>> assign users to it via phandles?
>
> I don't know what that means, sorry.
Well, we have the 'real' devices registered in DT like this:
ssp0: ssp at 41000000 {
compatible = "mrvl,pxa3xx-ssp";
reg = <0x41000000 0x40>;
interrupts = <24>;
clock-names = "pxa27x-ssp.0";
dmas = <&dma 13
&dma 14>;
dma-names = "rx", "tx";
};
And users, in that case, a ssp DAI, just reference a port like so:
ssp_dai0: ssp_dai at 0 {
compatible = "mrvl,pxa-ssp-dai";
port = <&ssp0>;
};
Is that something we can live with?
>> Also note that the last patch in that series ("ASoC: pxa: add DT
>> bindings for pxa2xx-pcm") can be omitted, as Lars pointed out. I'll have
>> to care for a proper solution at some point.
>
> I applied it since we were already adding a dummy device for the DAI. I
> can revert it if this work without that.
I'll send a cleanup patch once I have a better solution.
Daniel
next prev parent reply other threads:[~2013-08-15 13:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 8:42 [PATCH 0/5] ASoC: pxa dmaengine preparation patches Daniel Mack
2013-08-12 8:42 ` [PATCH 1/5] ALSA: move dmaengine implementation from ASoC to ALSA core Daniel Mack
2013-08-12 8:55 ` Daniel Mack
2013-08-15 10:18 ` Mark Brown
2013-08-12 8:42 ` [PATCH 2/5] ASoC: pxa: pxa-ssp: add DT bindings Daniel Mack
2013-08-15 10:33 ` Mark Brown
2013-08-15 10:51 ` Daniel Mack
2013-08-15 13:39 ` Mark Brown
2013-08-15 13:43 ` Daniel Mack [this message]
2013-08-15 14:01 ` Mark Brown
2013-08-12 8:42 ` [PATCH 3/5] ASoC: pxa: use snd_dmaengine_dai_dma_data Daniel Mack
2013-08-12 8:42 ` [PATCH 4/5] ASoC: pxa: pxa-ssp: set dma filter data from startup hook Daniel Mack
2013-08-12 8:42 ` [PATCH 5/5] ASoC: pxa: add DT bindings for pxa2xx-pcm Daniel Mack
2013-08-12 9:00 ` [alsa-devel] " Lars-Peter Clausen
2013-08-12 9:17 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520CDAF2.7010101@gmail.com \
--to=zonque@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).