linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] Documentation: devicetree: arm: cpus/cpu nodes bindings updates
Date: Thu, 15 Aug 2013 09:32:05 -0500	[thread overview]
Message-ID: <520CE665.8060907@gmail.com> (raw)
In-Reply-To: <1376559743-31848-2-git-send-email-lorenzo.pieralisi@arm.com>

On 08/15/2013 04:42 AM, Lorenzo Pieralisi wrote:
> In order to extend the current cpu nodes bindings to newer CPUs
> inclusive of AArch64 and to update support for older ARM CPUs this
> patch updates device tree documentation for the cpu nodes bindings.
> 
> Main changes:
>     - adds 64-bit bindings
>     - define usage of #address-cells
>     - defines behaviour on pre and post v7 uniprocessor systems
>     - adds ARM 11MPcore specific reg property definition
> 
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> ---
>  Documentation/devicetree/bindings/arm/cpus.txt | 424 ++++++++++++++++++++++---
>  1 file changed, 377 insertions(+), 47 deletions(-)
> 

The binding looks mostly fine to me.

[snip]

> +			    "faraday,fa526"
> +			    "intel,sa110"
> +			    "intel,sa1100"
> +			    "marvell,feroceon"
> +			    "marvell,mohawk"
> +			    "marvell,pj4"
> +			    "marvell,sheeva-v7"
> +			    "marvell,xsc3"
> +			    "marvell,xscale"

Better make sure the Marvell folks are happy with these. We don't need
another rename here. I'm too annoyed with all the renames to pay attention.

> +
> +Example 4 (ARM Cortex-A57 64-bit system running OS in AArch64):
> +

Going back to my comments that the dtb can't be dependent on the OS,
these 2 examples don't make sense.

> +
> +Example 5 (ARM Cortex-A57 64-bit system running OS in AArch32):

This example should be removed.

Rob

> +
> +cpus {
> +	#size-cells = <0>;
> +	#address-cells = <2>;
> +
> +	cpu at 0 {
> +		device_type = "cpu";
> +		compatible = "arm,cortex-a57";
> +		reg = <0x0 0x0>;
> +	};
> +
> +	cpu at 1 {
> +		device_type = "cpu";
> +		compatible = "arm,cortex-a57";
> +		reg = <0x0 0x1>;
> +	};
> +
> +	cpu at 100 {
> +		device_type = "cpu";
> +		compatible = "arm,cortex-a57";
> +		reg = <0x0 0x100>;
> +	};
> +
> +	cpu at 101 {
> +		device_type = "cpu";
> +		compatible = "arm,cortex-a57";
> +		reg = <0x0 0x101>;
> +	};
> +};
> 

  reply	other threads:[~2013-08-15 14:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-15  9:42 [PATCH 0/2] ARM DT cpus/cpu and topology bindings Lorenzo Pieralisi
2013-08-15  9:42 ` [PATCH 1/2] Documentation: devicetree: arm: cpus/cpu nodes bindings updates Lorenzo Pieralisi
2013-08-15 14:32   ` Rob Herring [this message]
2013-08-15 15:22     ` Lorenzo Pieralisi
2013-08-19 10:34       ` Afzal Mohammed
2013-09-13 16:57       ` Lorenzo Pieralisi
2013-09-13 20:51         ` Rob Herring
2013-09-14  7:49           ` Andrew Lunn
2013-09-16  8:55           ` Lorenzo Pieralisi
2013-09-15  8:36         ` Andrew Lunn
2013-09-16  8:57           ` Lorenzo Pieralisi
2013-08-16 23:15   ` Stephen Warren
2013-08-28 19:45   ` Grant Likely
2013-08-15  9:42 ` [PATCH 2/2] Documentation: DT: arm: define CPU topology bindings Lorenzo Pieralisi
2013-09-13 16:39   ` Lorenzo Pieralisi
2013-09-13 21:07   ` Rob Herring
2013-09-16  9:10     ` Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=520CE665.8060907@gmail.com \
    --to=robherring2@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).