From: mkl@pengutronix.de (Marc Kleine-Budde)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND] can: mcp251x: Replace power callbacks with regulator API
Date: Sun, 18 Aug 2013 10:00:34 +0200 [thread overview]
Message-ID: <52107F22.80002@pengutronix.de> (raw)
In-Reply-To: <1376773805.878998573@f169.i.mail.ru>
On 08/17/2013 11:10 PM, Alexander Shiyan wrote:
[...]
>>> - xceiver-supply: Regulator that powers the CAN transceiver
>>
>> which translates into:
>>
>>> priv->reg_xceiver = devm_regulator_get(&pdev->dev, "xceiver");
>>
>> Can you please use "xceiver" instead of "transceiver", so that future DT
>> binding will fit the scheme.
>
> OK. I am not ready to add DT support yet, but it can be added later,
DT support can be added later, I just want to make sure that you use
"xceiver" for the regulator, so that you don't need to change any code
if DT is added.
> so v2 will contain 3 parts:
If you mean series v3 consists of three patches....
> 1 - Replace power callbacks with regulator API
> 2 - Eliminate mcp251x_platform_data->irq_flags
> 3 - Replace oscillator_frequency with CLK API (and remove mcp251x.h header)
>
> Are you OK with such changes?
...them I'm okay :)
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 259 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130818/53d32f03/attachment-0001.sig>
prev parent reply other threads:[~2013-08-18 8:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 12:00 [PATCH RESEND] can: mcp251x: Replace power callbacks with regulator API Alexander Shiyan
2013-08-09 7:37 ` Marc Kleine-Budde
2013-08-17 2:03 ` Haojian Zhuang
2013-08-17 2:19 ` Haojian Zhuang
2013-08-17 4:30 ` Alexander Shiyan
2013-08-17 4:37 ` Haojian Zhuang
2013-08-20 8:46 ` Marc Kleine-Budde
2013-08-21 0:46 ` Haojian Zhuang
2013-08-17 19:59 ` Marc Kleine-Budde
2013-08-17 21:10 ` Alexander Shiyan
2013-08-18 8:00 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52107F22.80002@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).