* [PATCH] dma: imx-sdma: remove the unused completion
@ 2013-07-05 7:50 Huang Shijie
2013-07-06 5:13 ` Shawn Guo
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Huang Shijie @ 2013-07-05 7:50 UTC (permalink / raw)
To: linux-arm-kernel
After the patch: "2ccaef0 dma: imx-sdma: make channel0 operations atomic",
the "done" completion is not used any more.
Just remove it.
Signed-off-by: Huang Shijie <b32955@freescale.com>
---
drivers/dma/imx-sdma.c | 7 -------
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index 1e44b8c..2c02a9d 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -243,7 +243,6 @@ struct sdma_engine;
* @event_id1 for channels that use 2 events
* @word_size peripheral access size
* @buf_tail ID of the buffer that was processed
- * @done channel completion
* @num_bd max NUM_BD. number of descriptors currently handling
*/
struct sdma_channel {
@@ -255,7 +254,6 @@ struct sdma_channel {
unsigned int event_id1;
enum dma_slave_buswidth word_size;
unsigned int buf_tail;
- struct completion done;
unsigned int num_bd;
struct sdma_buffer_descriptor *bd;
dma_addr_t bd_phys;
@@ -547,8 +545,6 @@ static void sdma_tasklet(unsigned long data)
{
struct sdma_channel *sdmac = (struct sdma_channel *) data;
- complete(&sdmac->done);
-
if (sdmac->flags & IMX_DMA_SG_LOOP)
sdma_handle_channel_loop(sdmac);
else
@@ -812,9 +808,6 @@ static int sdma_request_channel(struct sdma_channel *sdmac)
sdma->channel_control[channel].current_bd_ptr = sdmac->bd_phys;
sdma_set_channel_priority(sdmac, MXC_SDMA_DEFAULT_PRIORITY);
-
- init_completion(&sdmac->done);
-
return 0;
out:
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] dma: imx-sdma: remove the unused completion
2013-07-05 7:50 [PATCH] dma: imx-sdma: remove the unused completion Huang Shijie
@ 2013-07-06 5:13 ` Shawn Guo
2013-08-19 6:33 ` Huang Shijie
2013-08-19 8:47 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2013-07-06 5:13 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jul 05, 2013 at 03:50:55PM +0800, Huang Shijie wrote:
> After the patch: "2ccaef0 dma: imx-sdma: make channel0 operations atomic",
> the "done" completion is not used any more.
>
> Just remove it.
>
> Signed-off-by: Huang Shijie <b32955@freescale.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] dma: imx-sdma: remove the unused completion
2013-07-05 7:50 [PATCH] dma: imx-sdma: remove the unused completion Huang Shijie
2013-07-06 5:13 ` Shawn Guo
@ 2013-08-19 6:33 ` Huang Shijie
2013-08-19 8:47 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Huang Shijie @ 2013-08-19 6:33 UTC (permalink / raw)
To: linux-arm-kernel
? 2013?07?05? 15:50, Huang Shijie ??:
> After the patch: "2ccaef0 dma: imx-sdma: make channel0 operations atomic",
> the "done" completion is not used any more.
>
> Just remove it.
>
> Signed-off-by: Huang Shijie <b32955@freescale.com>
> ---
> drivers/dma/imx-sdma.c | 7 -------
> 1 files changed, 0 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index 1e44b8c..2c02a9d 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -243,7 +243,6 @@ struct sdma_engine;
> * @event_id1 for channels that use 2 events
> * @word_size peripheral access size
> * @buf_tail ID of the buffer that was processed
> - * @done channel completion
> * @num_bd max NUM_BD. number of descriptors currently handling
> */
> struct sdma_channel {
> @@ -255,7 +254,6 @@ struct sdma_channel {
> unsigned int event_id1;
> enum dma_slave_buswidth word_size;
> unsigned int buf_tail;
> - struct completion done;
> unsigned int num_bd;
> struct sdma_buffer_descriptor *bd;
> dma_addr_t bd_phys;
> @@ -547,8 +545,6 @@ static void sdma_tasklet(unsigned long data)
> {
> struct sdma_channel *sdmac = (struct sdma_channel *) data;
>
> - complete(&sdmac->done);
> -
> if (sdmac->flags & IMX_DMA_SG_LOOP)
> sdma_handle_channel_loop(sdmac);
> else
> @@ -812,9 +808,6 @@ static int sdma_request_channel(struct sdma_channel *sdmac)
> sdma->channel_control[channel].current_bd_ptr = sdmac->bd_phys;
>
> sdma_set_channel_priority(sdmac, MXC_SDMA_DEFAULT_PRIORITY);
> -
> - init_completion(&sdmac->done);
> -
> return 0;
> out:
>
Hi Vinod:
Could you merge this patch?
thanks
Huang Shijie
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] dma: imx-sdma: remove the unused completion
2013-07-05 7:50 [PATCH] dma: imx-sdma: remove the unused completion Huang Shijie
2013-07-06 5:13 ` Shawn Guo
2013-08-19 6:33 ` Huang Shijie
@ 2013-08-19 8:47 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2013-08-19 8:47 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jul 05, 2013 at 03:50:55PM +0800, Huang Shijie wrote:
> After the patch: "2ccaef0 dma: imx-sdma: make channel0 operations atomic",
> the "done" completion is not used any more.
>
> Just remove it.
>
> Signed-off-by: Huang Shijie <b32955@freescale.com>
Applied, thanks
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-08-19 8:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-05 7:50 [PATCH] dma: imx-sdma: remove the unused completion Huang Shijie
2013-07-06 5:13 ` Shawn Guo
2013-08-19 6:33 ` Huang Shijie
2013-08-19 8:47 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).