From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tegra: split tegra_pmc_init() in two
Date: Tue, 20 Aug 2013 23:44:04 +0200	[thread overview]
Message-ID: <5213E324.2020000@gmail.com> (raw)
In-Reply-To: <1377034065-26373-1-git-send-email-swarren@wwwdotorg.org>
On 08/20/2013 11:27 PM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Tegra's board file currently initializes clocks much earlier than those
> for most other ARM SoCs. The reason is:
>
> * The PMC HW block is involved in the path of some interrupts (i.e. it
> inverts, or not, the IRQ input pin dedicated to the PMIC).
>
> * So, that part of the PMC must be initialized early so that the IRQ
> polarity is correct.
>
> * The PMC initialization is currently monolithic, and the PMC has some
> clock inputs, so the init routine ends up calling of_clk_get_by_name(),
> and hence clocks must be set up early too.
>
> In order to defer clock initialization to the more typical location,
> split out the portions of tegra_pmc_init() that are truly IRQ-related
> into a separate tegra_pmc_init_irq(), which can be called from the
> machine descriptor's .init_irq() function, and defer the rest until
> the machine descriptor's .init_machine() function. This allows the
> clock initiliazation to happen from the machine descriptor's
> .init_time() function, as is typical.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> Sebastian, this should help with your of_clock_init() series. Feel free
> to include this patch in your series unless someone raises objections to
> it. It's based on next-20130819, but I think it should apply many other
> places without any issue, and certainly on top of wherever Tegra's
> for-3.12/soc branch got applies within the arm-soc git repo. If you want
> me to take it for 3.13, just let me know.
Stephen,
thanks for looking into it so fast. I prefer to include it and send it
with the other patches. Besides tegra, also imx, mvebu, and vexpress
required to move things around a bit, so I wait for the someone to
comment on their mach changes first.
For the final patch set, I guess your Signed-off on this is sufficient
to convince Olof or Russell to take it.
Sebastian
next prev parent reply	other threads:[~2013-08-20 21:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-20 21:27 [PATCH] ARM: tegra: split tegra_pmc_init() in two Stephen Warren
2013-08-20 21:44 ` Sebastian Hesselbarth [this message]
2013-09-17 20:04 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=5213E324.2020000@gmail.com \
    --to=sebastian.hesselbarth@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).