From: zonque@gmail.com (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] usb: musb dsps: fix pdev cast in suspend/resume
Date: Wed, 21 Aug 2013 10:50:34 +0200 [thread overview]
Message-ID: <52147F5A.90801@gmail.com> (raw)
In-Reply-To: <1376397630-26863-1-git-send-email-zonque@gmail.com>
On 13.08.2013 14:40, Daniel Mack wrote:
> dsps_suspend() and dsps_resume() are called with the device that has the
> glue assigned as drvdata. Using dev->parent seems wrong and causes a
> NULL pointer exception on an AM33xx board.
>
> The code was introduced by commit c68bb4c6 ("usb: musb: dsps: control
> module handling (quirk)") but I wonder whether it was ever used.
>
> Signed-off-by: Daniel Mack <zonque@gmail.com>
Felipe, is this one good to go in?
Thanks,
Daniel
> ---
> drivers/usb/musb/musb_dsps.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
> index 5233804..f20218e 100644
> --- a/drivers/usb/musb/musb_dsps.c
> +++ b/drivers/usb/musb/musb_dsps.c
> @@ -692,7 +692,7 @@ static int dsps_remove(struct platform_device *pdev)
> #ifdef CONFIG_PM_SLEEP
> static int dsps_suspend(struct device *dev)
> {
> - struct platform_device *pdev = to_platform_device(dev->parent);
> + struct platform_device *pdev = to_platform_device(dev);
> struct dsps_glue *glue = platform_get_drvdata(pdev);
> const struct dsps_musb_wrapper *wrp = glue->wrp;
> int i;
> @@ -705,7 +705,7 @@ static int dsps_suspend(struct device *dev)
>
> static int dsps_resume(struct device *dev)
> {
> - struct platform_device *pdev = to_platform_device(dev->parent);
> + struct platform_device *pdev = to_platform_device(dev);
> struct dsps_glue *glue = platform_get_drvdata(pdev);
> const struct dsps_musb_wrapper *wrp = glue->wrp;
> int i;
>
prev parent reply other threads:[~2013-08-21 8:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 12:40 [PATCH] usb: musb dsps: fix pdev cast in suspend/resume Daniel Mack
2013-08-13 15:37 ` Felipe Balbi
2013-08-13 15:45 ` Daniel Mack
2013-08-21 8:50 ` Daniel Mack [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52147F5A.90801@gmail.com \
--to=zonque@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).