* [PATCH v2] ARM: at91: at91sam9260: add missing pinctrl on mmc
@ 2013-08-21 7:42 ludovic.desroches at atmel.com
2013-08-21 8:07 ` Nicolas Ferre
0 siblings, 1 reply; 4+ messages in thread
From: ludovic.desroches at atmel.com @ 2013-08-21 7:42 UTC (permalink / raw)
To: linux-arm-kernel
From: Ludovic Desroches <ludovic.desroches@atmel.com>
pinctrl-names was missing causing mmc pinctrl to never be requested. Moreover,
add minimal pin configuration to not cause error if overloading is forgotten
in board files.
Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
---
v2:
- add minimal pin configuration
arch/arm/boot/dts/at91sam9260.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi
index 84c4bef..b4de52a 100644
--- a/arch/arm/boot/dts/at91sam9260.dtsi
+++ b/arch/arm/boot/dts/at91sam9260.dtsi
@@ -477,6 +477,8 @@
interrupts = <9 4 0>;
#address-cells = <1>;
#size-cells = <0>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_mmc0_clk &pinctrl_mmc0_slot1_cmd_dat0>;
status = "disabled";
};
--
1.7.11.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] ARM: at91: at91sam9260: add missing pinctrl on mmc
2013-08-21 7:42 [PATCH v2] ARM: at91: at91sam9260: add missing pinctrl on mmc ludovic.desroches at atmel.com
@ 2013-08-21 8:07 ` Nicolas Ferre
2013-08-21 8:56 ` Ludovic Desroches
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Ferre @ 2013-08-21 8:07 UTC (permalink / raw)
To: linux-arm-kernel
On 21/08/2013 09:42, ludovic.desroches at atmel.com :
> From: Ludovic Desroches <ludovic.desroches@atmel.com>
>
> pinctrl-names was missing causing mmc pinctrl to never be requested. Moreover,
> add minimal pin configuration to not cause error if overloading is forgotten
> in board files.
>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
(modified the "interrupts" property to add the macro definition).
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
stacked in at91-3.12-dt.
Due to macro change, I can't tag it for -stable. We have to remember to
add it when it is accepted upstream.
thanks.
> ---
>
> v2:
> - add minimal pin configuration
>
> arch/arm/boot/dts/at91sam9260.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi
> index 84c4bef..b4de52a 100644
> --- a/arch/arm/boot/dts/at91sam9260.dtsi
> +++ b/arch/arm/boot/dts/at91sam9260.dtsi
> @@ -477,6 +477,8 @@
> interrupts = <9 4 0>;
> #address-cells = <1>;
> #size-cells = <0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_mmc0_clk &pinctrl_mmc0_slot1_cmd_dat0>;
> status = "disabled";
> };
>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] ARM: at91: at91sam9260: add missing pinctrl on mmc
2013-08-21 8:07 ` Nicolas Ferre
@ 2013-08-21 8:56 ` Ludovic Desroches
2013-08-21 9:10 ` Nicolas Ferre
0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Desroches @ 2013-08-21 8:56 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Aug 21, 2013 at 10:07:47AM +0200, Nicolas Ferre wrote:
> On 21/08/2013 09:42, ludovic.desroches at atmel.com :
> >From: Ludovic Desroches <ludovic.desroches@atmel.com>
> >
> >pinctrl-names was missing causing mmc pinctrl to never be requested. Moreover,
> >add minimal pin configuration to not cause error if overloading is forgotten
> >in board files.
> >
> >Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> >Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
>
> (modified the "interrupts" property to add the macro definition).
>
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
After discussing with Jean-Christophe keeping the first version of the patch
seems a better choice because the user will be notified if he forgets to
overload pin configuration instead of thinking that everything goes right and
having a default pin configuration that could not fit its configuration.
>
> stacked in at91-3.12-dt.
>
> Due to macro change, I can't tag it for -stable. We have to remember
> to add it when it is accepted upstream.
>
> thanks.
>
> >---
> >
> >v2:
> > - add minimal pin configuration
> >
> > arch/arm/boot/dts/at91sam9260.dtsi | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> >diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi
> >index 84c4bef..b4de52a 100644
> >--- a/arch/arm/boot/dts/at91sam9260.dtsi
> >+++ b/arch/arm/boot/dts/at91sam9260.dtsi
> >@@ -477,6 +477,8 @@
> > interrupts = <9 4 0>;
> > #address-cells = <1>;
> > #size-cells = <0>;
> >+ pinctrl-names = "default";
> >+ pinctrl-0 = <&pinctrl_mmc0_clk &pinctrl_mmc0_slot1_cmd_dat0>;
> > status = "disabled";
> > };
> >
> >
>
>
> --
> Nicolas Ferre
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] ARM: at91: at91sam9260: add missing pinctrl on mmc
2013-08-21 8:56 ` Ludovic Desroches
@ 2013-08-21 9:10 ` Nicolas Ferre
0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Ferre @ 2013-08-21 9:10 UTC (permalink / raw)
To: linux-arm-kernel
On 21/08/2013 10:56, Ludovic Desroches :
> On Wed, Aug 21, 2013 at 10:07:47AM +0200, Nicolas Ferre wrote:
>> On 21/08/2013 09:42, ludovic.desroches at atmel.com :
>>> From: Ludovic Desroches <ludovic.desroches@atmel.com>
>>>
>>> pinctrl-names was missing causing mmc pinctrl to never be requested. Moreover,
>>> add minimal pin configuration to not cause error if overloading is forgotten
>>> in board files.
>>>
>>> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
>>> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
>>
>> (modified the "interrupts" property to add the macro definition).
>>
>> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>
> After discussing with Jean-Christophe keeping the first version of the patch
> seems a better choice because the user will be notified if he forgets to
> overload pin configuration instead of thinking that everything goes right and
> having a default pin configuration that could not fit its configuration.
Ah, okay: that makes sense.
>> stacked in at91-3.12-dt.
So I replace the patch.
Thanks,
>>
>> Due to macro change, I can't tag it for -stable. We have to remember
>> to add it when it is accepted upstream.
>>
>> thanks.
>>
>>> ---
>>>
>>> v2:
>>> - add minimal pin configuration
>>>
>>> arch/arm/boot/dts/at91sam9260.dtsi | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi
>>> index 84c4bef..b4de52a 100644
>>> --- a/arch/arm/boot/dts/at91sam9260.dtsi
>>> +++ b/arch/arm/boot/dts/at91sam9260.dtsi
>>> @@ -477,6 +477,8 @@
>>> interrupts = <9 4 0>;
>>> #address-cells = <1>;
>>> #size-cells = <0>;
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&pinctrl_mmc0_clk &pinctrl_mmc0_slot1_cmd_dat0>;
>>> status = "disabled";
>>> };
>>>
>>>
>>
>>
>> --
>> Nicolas Ferre
>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-08-21 9:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-21 7:42 [PATCH v2] ARM: at91: at91sam9260: add missing pinctrl on mmc ludovic.desroches at atmel.com
2013-08-21 8:07 ` Nicolas Ferre
2013-08-21 8:56 ` Ludovic Desroches
2013-08-21 9:10 ` Nicolas Ferre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox