From: john.stultz@linaro.org (John Stultz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 2/2] clocksource: dw_apb_timer_of: Fix read_sched_clock
Date: Wed, 21 Aug 2013 13:39:28 -0700 [thread overview]
Message-ID: <52152580.90508@linaro.org> (raw)
In-Reply-To: <1377115342.1554.21.camel@linux-builds1>
On 08/21/2013 01:02 PM, Dinh Nguyen wrote:
> On Wed, 2013-08-21 at 21:07 +0200, ZY - pavel wrote:
>> On Wed 2013-08-21 09:04:07, Linus Walleij wrote:
>>> On Thu, Aug 15, 2013 at 1:29 AM, <dinguyen@altera.com> wrote:
>>>
>>>> - sched_io_base = iobase + 0x04;
>>>> + sched_io_base = iobase;
>>>> sched_rate = rate;
>>>> }
>>>>
>>>> static u32 read_sched_clock(void)
>>>> {
>>>> - return __raw_readl(sched_io_base);
>>>> + return ~__raw_readl(sched_io_base + 0x4);
>>> So what about #define what 0x04 is?
>>>
>>> #define MY_FOO_REGISTER_OFFSET 0x04
>>>
>>> raw_readl(sched_io_base + MY_FOO_REGISTER_OFFSET);
>> That define is already there, #define APBTMR_N_CURRENT_VALUE 0x04, but
>> it is in .c file, not in header.
> I'll send a V2 that will address this comment and Stephen Warren's.
Please be sure to CC Daniel Lezcano <daniel.lezcano@linaro.org> on
future versions as he's now maintaining the drivers/clocksource directory.
thanks
-john
next prev parent reply other threads:[~2013-08-21 20:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 23:29 [PATCHv2 1/2] ARM: dts: Change dw-apb-timer-osc and dw-apb-timer-sp to just dw-apb-timer dinguyen at altera.com
2013-08-14 23:29 ` [PATCHv2 2/2] clocksource: dw_apb_timer_of: Fix read_sched_clock dinguyen at altera.com
2013-08-21 7:04 ` Linus Walleij
2013-08-21 19:07 ` Pavel Machek
2013-08-21 20:02 ` Dinh Nguyen
2013-08-21 20:39 ` John Stultz [this message]
2013-08-16 22:48 ` [PATCHv2 1/2] ARM: dts: Change dw-apb-timer-osc and dw-apb-timer-sp to just dw-apb-timer Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52152580.90508@linaro.org \
--to=john.stultz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).